Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: count reviewer failures inside the serialized settings update (#11869)

Adam Eivyaeb768ccffcd
diff --git a/server/services/codeReview.js b/server/services/codeReview.js
index 5bf1156a5f..f196c2c0a6 100644
--- a/server/services/codeReview.js
+++ b/server/services/codeReview.js
@@ -101,24 +101,25 @@ export async function reportReviewerFailure(reviewer, error, now = Date.now()) {
const isQuota = explicitReason === 'quota' || isReviewerQuotaFailure(result)
const isExplicitUnavailable = explicitReason === 'unavailable'
- const settings = await getSettings().catch(() => null)
- const prior = settings?.codeReview?.reviewerHealth?.[reviewer]
- const priorCount = Number(prior?.failureCount) || 0
- const failureCount = priorCount + 1
- const isRepeatedFailure = failureCount >= 2
const isProvider = isProviderReviewer(reviewer)
- if (!isConfigFault && !isMalformed && !isQuota && !isExplicitUnavailable && !isRepeatedFailure && !isProvider) {
+ if (!isConfigFault && !isMalformed && !isQuota && !isExplicitUnavailable && !isProvider) {
return false
}
- const shouldPause = isQuota || isExplicitUnavailable || isRepeatedFailure || (Number(prior?.pausedUntil) > now)
- const pauseReason = isQuota ? 'quota' : (isExplicitUnavailable ? 'unavailable' : (isRepeatedFailure ? 'unavailable' : (prior?.reason || 'unavailable')))
-
+ // The failure count and pause decision derive from the persisted record
+ // inside the serialized update, so concurrent failures each see the others.
// Reviewer telemetry is not a user action. The standalone claim bridge must
// not initialize the live user-action database while updating local health.
+ let shouldPause = false
+ let pauseReason = null
await updateSettingsWith((current) => {
const existing = current.codeReview?.reviewerHealth?.[reviewer] || {}
+ const failureCount = (Number(existing.failureCount) || 0) + 1
+ const isRepeatedFailure = failureCount >= 2
+ shouldPause = isQuota || isExplicitUnavailable || isRepeatedFailure || (Number(existing.pausedUntil) > now)
+ pauseReason = isQuota ? 'quota' : (isExplicitUnavailable ? 'unavailable' : (isRepeatedFailure ? 'unavailable' : (existing.reason || 'unavailable')))
+
let entry
if (isMalformed) {
entry = {
diff --git a/server/services/codeReview.test.js b/server/services/codeReview.test.js
index b9cdcef90a..822efc765d 100644
--- a/server/services/codeReview.test.js
+++ b/server/services/codeReview.test.js
@@ -487,6 +487,22 @@ describe('codeReview helpers', () => {
})
})
+ it('counts concurrent provider failures against the persisted record and pauses on the second', async () => {
+ const reviewer = 'provider:opencode-zen'
+ mockedSettings.current = { codeReview: { reviewerFallbackGroups: [[reviewer], ['claude']] } }
+ const transient = { error: 'Unexpected server error. Check server logs for details.' }
+ await Promise.all([
+ reportReviewerFailure(reviewer, transient, 1000),
+ reportReviewerFailure(reviewer, transient, 1000),
+ ])
+ expect(mockedSettings.current.codeReview.reviewerHealth[reviewer]).toMatchObject({
+ pausedUntil: 1000 + REVIEWER_PAUSE_MS,
+ reason: 'unavailable',
+ failureCount: 2,
+ })
+ expect(pickAvailableReviewerGroups(mockedSettings.current.codeReview, 1000)).toEqual(['claude'])
+ })
+
it('recognizes free API quota limits and pauses provider for 24h', async () => {
mockedSettings.current = { codeReview: {
reviewerFallbackGroups: [['provider:opencode-orcarouter'], ['provider:nvidia-nim'], ['claude']],