Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: live preview img.decode() waits for a bridged src instead of rejecting (#10765)

Adam Eivyb0d354da91db
diff --git a/server/services/musicVideo/documentPreview.js b/server/services/musicVideo/documentPreview.js
index 644776c72c..31a76dfd92 100644
--- a/server/services/musicVideo/documentPreview.js
+++ b/server/services/musicVideo/documentPreview.js
@@ -71,6 +71,7 @@ const BOOTSTRAP = `(() => {
const map = new Map(); // key → { url, size, used, media: Set<WeakRef> } for files received
const waiting = new Map(); // key → callbacks awaiting the parent's answer
const assigned = new WeakMap(); // element → token of its latest src assignment (a stale answer must not win)
+ const inflight = new WeakMap(); // element → { promise, done } while a bridged src awaits the parent's blob
let keys = null; // the manifest; null until the parent posts it
let resolveAssets;
window.PORTOS_MV_PREVIEW = true;
@@ -115,14 +116,19 @@ const BOOTSTRAP = `(() => {
if (!waiting.has(key)) { waiting.set(key, []); post({ type: 'portos-mv:request', key }); }
waiting.get(key).push(callback);
};
+ // A bridged src lands after the parent answers, so decode()/complete must see the assignment as pending until then.
+ const settle = (el, token) => { const hold = inflight.get(el); if (hold && hold.token === token) { inflight.delete(el); hold.done(); } };
const apply = (el, desc, value, token) => {
const key = keyOf(value);
- if (!keys.has(key)) return desc.set.call(el, value);
+ if (!keys.has(key)) { desc.set.call(el, value); return settle(el, token); }
request(key, (entry) => {
if (assigned.get(el) !== token) return;
- if (!entry) return desc.set.call(el, value);
- if (el instanceof HTMLMediaElement || el instanceof HTMLSourceElement) entry.media.add(new WeakRef(el));
- desc.set.call(el, entry.url);
+ if (!entry) desc.set.call(el, value);
+ else {
+ if (el instanceof HTMLMediaElement || el instanceof HTMLSourceElement) entry.media.add(new WeakRef(el));
+ desc.set.call(el, entry.url);
+ }
+ settle(el, token);
});
};
// A promise of a bridged file's blob: URL (null when unavailable), for uses other than a media src.
@@ -141,11 +147,24 @@ const BOOTSTRAP = `(() => {
set(value) {
const token = {};
assigned.set(this, token);
+ const stale = inflight.get(this);
+ if (stale) { inflight.delete(this); stale.done(); }
if (!relative(value)) return desc.set.call(this, value);
+ let done;
+ inflight.set(this, { token, done: () => done(), promise: new Promise((resolve) => { done = resolve; }) });
if (!keys) { pending.push([this, desc, value, token]); return; }
apply(this, desc, value, token);
} });
}
+ // decode() called straight after a bridged src assignment must wait for the real src, or it rejects on an empty image.
+ const decode = HTMLImageElement.prototype.decode;
+ HTMLImageElement.prototype.decode = function() {
+ const hold = inflight.get(this);
+ return hold ? hold.promise.then(() => decode.call(this)) : decode.call(this);
+ };
+ const complete = Object.getOwnPropertyDescriptor(HTMLImageElement.prototype, 'complete');
+ if (complete && complete.get) Object.defineProperty(HTMLImageElement.prototype, 'complete', { configurable: true, enumerable: complete.enumerable,
+ get() { return !inflight.has(this) && complete.get.call(this); } });
const contract = () => {
const c = globalThis.portosComposition;
return c ? { durationSec: c.durationSec, fps: c.fps, width: c.width, height: c.height, formats: c.formats || null, layout: typeof c.layout === 'function' } : null;
diff --git a/server/services/musicVideo/documentRender.browser.test.js b/server/services/musicVideo/documentRender.browser.test.js
index 27d2b31f64..b0aa954d71 100644
--- a/server/services/musicVideo/documentRender.browser.test.js
+++ b/server/services/musicVideo/documentRender.browser.test.js
@@ -352,6 +352,35 @@ describe.skipIf(!canRun)('layered template with real Chrome and ffmpeg', () => {
expect(result.reused).not.toBe(result.first);
}, 30000);
+ it('lets img.decode() and complete wait for a bridged src instead of rejecting on an unset image', async () => {
+ const created = await projects.createProject({ name: 'Synthetic bridge decode' });
+ await projects.mutateProjectRecord(created.id, (current) => ({ project: { ...current,
+ audioAnalysis: { durationSec: 1, beats: [0], downbeats: [0], sections: [{ id: 'song', label: 'Verse', startSec: 0, endSec: 1 }] },
+ composition: { mode: 'document' },
+ scenes: [{ sceneId: 'card', startSec: 0, endSec: 1, visualLayer: 'card', cardText: '' }],
+ } }));
+ await importDocumentTemplate(created.id);
+ const page = await browser.newPage();
+ await page.setContent((await buildDocumentPreview(await projects.getProject(created.id))).html);
+ const result = await page.evaluate(async () => {
+ const canvas = document.createElement('canvas');
+ canvas.width = canvas.height = 2;
+ const blob = await new Promise((resolve) => canvas.toBlob(resolve, 'image/png'));
+ addEventListener('message', ({ data }) => {
+ if (data?.type !== 'portos-mv:request') return;
+ setTimeout(() => postMessage({ type: 'portos-mv:asset', key: data.key, blob }, '*'), 50);
+ });
+ postMessage({ type: 'portos-mv:manifest', keys: ['media/a.png'] }, '*');
+ const img = new Image();
+ img.src = 'media/a.png';
+ const pendingComplete = img.complete;
+ await img.decode();
+ return { pendingComplete, complete: img.complete, src: img.src.slice(0, 5), width: img.naturalWidth };
+ });
+ await page.close();
+ expect(result).toEqual({ pendingComplete: false, complete: true, src: 'blob:', width: 2 });
+ }, 30000);
+
it('keeps event frames identical across shuffled seeks, an excerpt and a full render, and freezes silence', async () => {
const created = await projects.createProject({ name: 'Synthetic event proof' });
const base = { durationSec: 0.2, narrativeFunction: 'Mark the story turn', mediumRationale: 'Exact code graphics' };