Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

Drop people from Cast & sets plate lighting too

atomanticb1069cd64390
diff --git a/server/services/musicVideo/castAndSetsPlan.js b/server/services/musicVideo/castAndSetsPlan.js
index 5cdb92e3cc..26284126dd 100644
--- a/server/services/musicVideo/castAndSetsPlan.js
+++ b/server/services/musicVideo/castAndSetsPlan.js
@@ -11,8 +11,8 @@
* outside inspiration and only reach it as text.
* - `expressions` — a 2×3 expression sheet including the signature gesture.
* - `looks` — the wardrobe lookbook, one panel per look.
- * - `set:<id>` — one EMPTY plate per set: any sentence of the description
- * or look that puts a person in it is dropped. Plates do
+ * - `set:<id>` — one EMPTY plate per set: any sentence of the description,
+ * lighting or look that puts a person in it is dropped. Plates do
* not depend on the character, so they render alongside it.
* - `test:<n>` — the protagonist in a set: conditioned on that set's plate,
* the character sheet and the looks sheet.
@@ -105,6 +105,9 @@ function buildProceduralImagePlan(direction, { revisionNotes = {} } = {}) {
for (const set of direction.sets || []) {
const key = `set:${set.id}`;
const role = set.imageRole || 'background';
+ // Only a cutout plate is meant to hold a subject.
+ const clean = (text) => (role === 'cutout' ? text : withoutPeople(text, direction.protagonist?.name));
+ const lighting = clean(set.lighting || '');
plan[key] = {
key,
kind: 'plate',
@@ -114,8 +117,8 @@ function buildProceduralImagePlan(direction, { revisionNotes = {} } = {}) {
deps: [],
refKeys: [],
prompt: join(
- (PROCEDURAL_ROLE_PROMPTS[role] || PROCEDURAL_ROLE_PROMPTS.background)(set),
- set.lighting && `Lighting: ${set.lighting}`,
+ (PROCEDURAL_ROLE_PROMPTS[role] || PROCEDURAL_ROLE_PROMPTS.background)({ ...set, description: clean(set.description) || set.name }),
+ lighting && `Lighting: ${lighting}`,
role === 'background' && world.depth && `Depth: ${world.depth}`,
style && `Look: ${style}`,
revisionNotes[key] && `Revision: ${revisionNotes[key]}`,
@@ -200,6 +203,7 @@ export function buildCastAndSetsImagePlan(project, direction, { revisionNotes =
const plateStyle = withoutPeople(style, p.name);
for (const set of direction.sets || []) {
const key = `set:${set.id}`;
+ const plateLight = withoutPeople(set.lighting, p.name);
plan[key] = {
key,
kind: 'plate',
@@ -210,7 +214,7 @@ export function buildCastAndSetsImagePlan(project, direction, { revisionNotes =
prompt: join(
'Empty set plate, no people',
withoutPeople(set.description, p.name) || set.name,
- set.lighting && `Lighting: ${set.lighting}`,
+ plateLight && `Lighting: ${plateLight}`,
plateStyle && `Look: ${plateStyle}`,
'Photorealistic music video location still',
note(key),
diff --git a/server/services/musicVideo/castAndSetsService.test.js b/server/services/musicVideo/castAndSetsService.test.js
index 79ccf0c75b..b3211c582a 100644
--- a/server/services/musicVideo/castAndSetsService.test.js
+++ b/server/services/musicVideo/castAndSetsService.test.js
@@ -812,13 +812,13 @@ it('keeps people out of set plates: no mood board person in the look, no charact
const personBoard = { ...board, style: { prompt: 'An adult woman with tousled curls sits alone beside a rain-speckled window. Amber haze.' } };
service.__setCastAndSetsDepsForTests(testDeps({ loadBoard: async () => personBoard }));
runPrompt.mockResolvedValue({ text: JSON.stringify({ ...DIRECTION, look: 'amber haze, 35mm grain',
- sets: DIRECTION.sets.map((set) => (set.id === 'harbor' ? { ...set, description: 'a wet stone quay. She sits on the edge of the quay. Keeper watches the tide.' } : set)) }) });
+ sets: DIRECTION.sets.map((set) => (set.id === 'harbor' ? { ...set, description: 'a wet stone quay. She sits on the edge of the quay. Keeper watches the tide.', lighting: 'sodium orange. She is lit from the lamp, then looks up into the lens.' } : set)) }) });
const project = await seed({ concept: { prompt: 'an escape', style: 'grainy 1980s film, soft glow', subjects: [] } });
await service.startCastAndSets(project.id);
await runTo(project.id, 'review');
const plate = (key) => jobs.findLast((j) => keyOf(j) === key).params.prompt;
- expect(plate('set:harbor')).toContain('a wet stone quay. Lighting');
- expect(plate('set:harbor')).not.toMatch(/She sits|Keeper watches/);
+ expect(plate('set:harbor')).toContain('a wet stone quay. Lighting: sodium orange.');
+ expect(plate('set:harbor')).not.toMatch(/She sits|Keeper watches|She is lit/);
expect(plate('set:lab')).toContain('Look: amber haze, 35mm grain');
expect(jobs.some((j) => j.params.prompt.includes('tousled curls'))).toBe(false);