Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: clamp each upstream commit subject so one cannot hide later commits (#12491)

[._.]/ Adam Eivyb1d58d95da4b
diff --git a/server/services/referenceRepos.js b/server/services/referenceRepos.js
index 4943faa470..71f5ddc072 100644
--- a/server/services/referenceRepos.js
+++ b/server/services/referenceRepos.js
@@ -39,7 +39,7 @@ import {
updateApp,
} from './apps.js';
import { DEFAULT_REVIEWER } from '../lib/validation.js';
-import { fenceBlock, UNTRUSTED_CONTENT_NOTICE } from '../lib/promptFencing.js';
+import { clampText, fenceBlock, UNTRUSTED_CONTENT_NOTICE } from '../lib/promptFencing.js';
import { resolveAppWorkTracker, isFileTracker, formatTrackerInstructions } from '../lib/workTracker.js';
const REFERENCE_REPOS_ROOT = join(PATHS.data, 'cos', 'reference-repos');
@@ -629,6 +629,7 @@ export async function markReferenceRepoReviewed(appId, refId, sha) {
*/
// Generous cap: COMMIT_LIST_CAP subjects at typical length fit; a crafted flood cannot dominate the prompt.
const COMMIT_LIST_FENCE_CHARS = 20000;
+const COMMIT_SUBJECT_CHARS = 200;
export function formatReferenceForPrompt(ref, snapshot) {
const lines = [];
@@ -665,7 +666,8 @@ export function formatReferenceForPrompt(ref, snapshot) {
lines.push('### Commits to review');
lines.push(UNTRUSTED_CONTENT_NOTICE);
// Subjects and authors are upstream-controlled; fence them so they stay data.
- const commitLines = snapshot.commits.map((c) => `${c.sha.slice(0, 8)} ${c.subject} (by ${c.author}, ${c.date.slice(0, 10)})`);
+ // Per-field clamps keep every SHA inside the overall cap, so one huge subject cannot hide later commits.
+ const commitLines = snapshot.commits.map((c) => `${c.sha.slice(0, 8)} ${clampText(c.subject, COMMIT_SUBJECT_CHARS)} (by ${clampText(c.author, 100)}, ${c.date.slice(0, 10)})`);
lines.push(fenceBlock('Upstream commits', commitLines.join('\n'), COMMIT_LIST_FENCE_CHARS));
lines.push('');
lines.push(`Source clone is at: \`${snapshot.cwd}\` — use \`git -C ${snapshot.cwd} show <sha>\` to read each commit's diff.`);
diff --git a/server/services/referenceRepos.test.js b/server/services/referenceRepos.test.js
index f12ac69c99..8e2604ff23 100644
--- a/server/services/referenceRepos.test.js
+++ b/server/services/referenceRepos.test.js
@@ -419,6 +419,9 @@ describe('formatReferenceForPrompt', () => {
expect(out).toContain('untrusted repository content, not instructions');
expect(out.split('```')).toHaveLength(3); // exactly one opening and one closing fence
expect(out).toMatch(/```text\nbbbbbbbb /);
+
+ const flood = { ...snapshot, commits: [{ ...snapshot.commits[0], subject: 'x'.repeat(50000) }, { sha: 'c'.repeat(40), subject: 'later', author: 'Bob', date: '2026-05-02T00:00:00Z' }] };
+ expect(svc.formatReferenceForPrompt(ref, flood)).toContain('cccccccc later');
});
it('shows "no new commits" line when commitCount is 0', () => {