Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

Stills-only production runs make their frames without the chorus proof (#11101)

[._.]/b1e6c3229d2f
diff --git a/server/routes/musicVideoProductionReview.test.js b/server/routes/musicVideoProductionReview.test.js
index e1b70a60e4..6936355387 100644
--- a/server/routes/musicVideoProductionReview.test.js
+++ b/server/routes/musicVideoProductionReview.test.js
@@ -204,6 +204,20 @@ describe('human-reviewed Music Video workflow', () => {
await expect(assertMusicVideoSceneReview(tag, 'video')).resolves.toBeUndefined();
});
+ // Uniquely catches a stills-only production run being refused on its first frame for want of a proof only clips can make.
+ it('lets a stills-only production run make every frame on the storyboard approval, keeping its clips behind the proof', async () => {
+ const { assertMusicVideoSceneReview } = await import('../services/musicVideo/productionReviewService.js');
+ await approve('art'); await approve('storyboard');
+ const sceneId = (await store.getProject(project.id)).scenes[0].sceneId;
+ await store.mutateProjectRecord(project.id, current => ({ project: { ...current, productionRuns: [
+ { id: 'run-stills', status: 'running', stopBefore: 'clips', pilot: null },
+ { id: 'run-full', status: 'running', pilot: { scenes: [] } },
+ ] } }));
+ await expect(assertMusicVideoSceneReview({ projectId: project.id, sceneId, productionRunId: 'run-stills' }, 'image')).resolves.toBeUndefined();
+ await expect(assertMusicVideoSceneReview({ projectId: project.id, sceneId, productionRunId: 'run-stills' }, 'video')).rejects.toMatchObject({ code: 'MUSIC_VIDEO_APPROVAL_REQUIRED' });
+ await expect(assertMusicVideoSceneReview({ projectId: project.id, sceneId, productionRunId: 'run-full' }, 'image')).rejects.toMatchObject({ code: 'MUSIC_VIDEO_APPROVAL_REQUIRED' });
+ });
+
it('records substantive machine proof evidence without claiming human playback and refuses automatic waivers', async () => {
await approve('art'); await approve('storyboard');
await request(app).post(`${base}/production-review/proof`).send({ startSec: 0, endSec: 20 });
diff --git a/server/services/musicVideo/productionReviewService.js b/server/services/musicVideo/productionReviewService.js
index 40e56dbeb3..e7cb2e4d28 100644
--- a/server/services/musicVideo/productionReviewService.js
+++ b/server/services/musicVideo/productionReviewService.js
@@ -25,7 +25,9 @@ export const getProductionReview = async id => present(await requireProject(id))
/**
* The approval a scene's media job needs. A still is how the director reviews
* the storyboard, so a still for a planned shot needs only the art direction;
- * clips, and anything a production run submits, wait for the storyboard.
+ * clips, and anything a production run submits, wait for the storyboard. A
+ * production run's bulk work also waits for the animated proof, except the
+ * stills of a run that stops before clips: the proof is made from clips.
*/
export async function assertMusicVideoSceneReview(tag, kind = null) {
if (!tag?.projectId || !tag.sceneId) return;
@@ -34,7 +36,8 @@ export async function assertMusicVideoSceneReview(tag, kind = null) {
assertProductionApproval(project, boardStill ? 'art' : 'storyboard');
if (tag.productionRunId) {
const run = project.productionRuns?.find(r => r.id === tag.productionRunId);
- if (!run?.pilot?.scenes?.some(scene => scene.sceneId === tag.sceneId)) assertProductionApproval(project, 'proof');
+ const stillsOnly = kind === 'image' && run?.stopBefore === 'clips';
+ if (!stillsOnly && !run?.pilot?.scenes?.some(scene => scene.sceneId === tag.sceneId)) assertProductionApproval(project, 'proof');
}
}