Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: default quality-check pull requests to following the saved policy

Adam Eivyb65186db49fb
diff --git a/client/src/components/apps/AppQualityRunner.jsx b/client/src/components/apps/AppQualityRunner.jsx
index 8c92d347f7..8a5228e4e2 100644
--- a/client/src/components/apps/AppQualityRunner.jsx
+++ b/client/src/components/apps/AppQualityRunner.jsx
@@ -35,7 +35,7 @@ export default function AppQualityRunner({ app, children }) {
});
const [mode, setMode] = useState('file-issues');
const [auditDepth, setAuditDepth] = useState('quick');
- const [prCompletion, setPrCompletion] = useState('draft');
+ const [prCompletion, setPrCompletion] = useState('inherit');
const [effort, setEffort] = useState('');
const [busy, setBusy] = useState(false);
const [error, setError] = useState('');
diff --git a/client/src/components/apps/AppQualityRunner.test.jsx b/client/src/components/apps/AppQualityRunner.test.jsx
index 0c45833928..54df1d342b 100644
--- a/client/src/components/apps/AppQualityRunner.test.jsx
+++ b/client/src/components/apps/AppQualityRunner.test.jsx
@@ -41,7 +41,7 @@ it('launches missing checks with visible mode and effort, then exposes held runn
fireEvent.click(screen.getByText('Use high effort'));
fireEvent.click(button);
await screen.findByRole('link', { name: 'Open runner settings' });
- expect(startMaintenanceRun).toHaveBeenCalledWith({ appId: 'app-1', providerId: 'codex', model: 'gpt-5', effort: 'high', mode: 'fix', prCompletion: 'draft', claimBetweenAudits: false, taskTypes: ['security', 'ux'] }, { silent: true });
+ expect(startMaintenanceRun).toHaveBeenCalledWith({ appId: 'app-1', providerId: 'codex', model: 'gpt-5', effort: 'high', mode: 'fix', prCompletion: 'inherit', claimBetweenAudits: false, taskTypes: ['security', 'ux'] }, { silent: true });
expect(button).toBeEnabled();
});
@@ -104,7 +104,7 @@ it('preserves run overrides when reopening the drawer for one category', async (
expect(screen.getByLabelText('Mode')).toHaveValue('fix');
fireEvent.click(screen.getByRole('button', { name: 'Run now' }));
await waitFor(() => expect(startMaintenanceRun).toHaveBeenCalledWith(
- { appId: 'app-1', providerId: 'codex', model: 'gpt-5', effort: 'high', mode: 'fix', prCompletion: 'draft', claimBetweenAudits: false, taskTypes: ['security'], explicitCheck: true },
+ { appId: 'app-1', providerId: 'codex', model: 'gpt-5', effort: 'high', mode: 'fix', prCompletion: 'inherit', claimBetweenAudits: false, taskTypes: ['security'], explicitCheck: true },
{ silent: true }
));
});
@@ -253,17 +253,17 @@ it('keeps a start response when an older status request resolves afterwards', as
expect(screen.getByRole('button', { name: 'Stop remaining checks' })).toBeInTheDocument();
});
-it('defaults audit fixes to draft review and lets the user explicitly inherit saved policy', async () => {
+it('defaults audit fixes to the saved policy and lets the user explicitly choose draft review', async () => {
startMaintenanceRun.mockResolvedValue({ run: { id: 'draft-run', status: 'completed', steps: [] } });
render(<MemoryRouter><AppQualityRunner app={app} /></MemoryRouter>);
fireEvent.change(await findEnabledByLabelText('Mode'), { target: { value: 'fix' } });
- expect(screen.getByLabelText('Pull requests')).toHaveValue('draft');
+ expect(screen.getByLabelText('Pull requests')).toHaveValue('inherit');
fireEvent.click(await findEnabledByRole('button', { name: 'Run 2 checks now' }));
- await waitFor(() => expect(startMaintenanceRun).toHaveBeenLastCalledWith(expect.objectContaining({ mode: 'fix', prCompletion: 'draft', claimBetweenAudits: false }), { silent: true }));
- fireEvent.change(await findEnabledByLabelText('Pull requests'), { target: { value: 'inherit' } });
+ await waitFor(() => expect(startMaintenanceRun).toHaveBeenLastCalledWith(expect.objectContaining({ mode: 'fix', prCompletion: 'inherit', claimBetweenAudits: false }), { silent: true }));
+ fireEvent.change(await findEnabledByLabelText('Pull requests'), { target: { value: 'draft' } });
fireEvent.click(await findEnabledByRole('button', { name: 'Run 2 checks now' }));
await waitFor(() => expect(startMaintenanceRun).toHaveBeenCalledTimes(2));
- expect(startMaintenanceRun.mock.lastCall[0].prCompletion).toBe('inherit');
+ expect(startMaintenanceRun.mock.lastCall[0].prCompletion).toBe('draft');
});