Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: stop Data Manager from offering one-click purge of message drafts, accounts and Review Hub data (#10912)

Adam Eivyb6d4c4d23ad9
diff --git a/client/src/pages/DataManager.test.jsx b/client/src/pages/DataManager.test.jsx
index 950b48c190..93c616bc86 100644
--- a/client/src/pages/DataManager.test.jsx
+++ b/client/src/pages/DataManager.test.jsx
@@ -120,7 +120,7 @@ const scopedOverview = {
dataDir: 'data',
categories: [
{ key: 'images', path: 'data/images', label: 'Images', description: 'Uploaded and generated images', archivable: true, deletable: true, purgeScope: 'items', classified: true, size: 2000, fileCount: 2 },
- { key: 'messages', path: 'data/messages', label: 'Messages', description: 'Email and messaging data', archivable: true, deletable: true, purgeScope: 'category', classified: true, size: 1000, fileCount: 5 },
+ { key: 'screenshots', path: 'data/screenshots', label: 'Screenshots', description: 'Task screenshots and images dropped into shell sessions', archivable: true, deletable: true, purgeScope: 'category', classified: true, size: 1000, fileCount: 5 },
{ key: 'legacy', path: 'data/legacy', label: 'Legacy', description: 'From a server that predates purgeScope', archivable: false, deletable: true, classified: true, size: 500, fileCount: 1 },
],
};
@@ -177,9 +177,9 @@ describe('DataManager per-item purge (#3327)', () => {
it('keeps the category-wide Purge button for category-scoped and legacy rows', async () => {
render(<DataManager />);
- await waitFor(() => expect(screen.getAllByText('Messages').length).toBeGreaterThan(0));
+ await waitFor(() => expect(screen.getAllByText('Screenshots').length).toBeGreaterThan(0));
- expandRow('Messages');
+ expandRow('Screenshots');
await waitFor(() => expect(screen.getByRole('button', { name: /Purge/ })).toBeInTheDocument());
// A server that predates purgeScope omits the field — the button must not
@@ -199,7 +199,7 @@ const busyOverview = {
dataDir: 'data',
categories: [
{ key: 'training-runs', path: 'data/training-runs', label: 'LoRA Training Runs', description: 'Training checkpoints', archivable: false, deletable: true, purgeScope: 'category', classified: true, busy: true, busyReason: BUSY_REASON, size: 2000, fileCount: 9 },
- { key: 'messages', path: 'data/messages', label: 'Messages', description: 'Email and messaging data', archivable: true, deletable: true, purgeScope: 'category', classified: true, busy: false, busyReason: null, size: 1000, fileCount: 5 },
+ { key: 'screenshots', path: 'data/screenshots', label: 'Screenshots', description: 'Task screenshots and images dropped into shell sessions', archivable: true, deletable: true, purgeScope: 'category', classified: true, busy: false, busyReason: null, size: 1000, fileCount: 5 },
],
};
@@ -222,9 +222,9 @@ describe('DataManager busy categories (#3342)', () => {
it('keeps the Purge button for an idle category in the same list', async () => {
render(<DataManager />);
- await waitFor(() => expect(screen.getAllByText('Messages').length).toBeGreaterThan(0));
+ await waitFor(() => expect(screen.getAllByText('Screenshots').length).toBeGreaterThan(0));
- expandRow('Messages');
+ expandRow('Screenshots');
await waitFor(() => expect(screen.getByRole('button', { name: /Purge/ })).toBeInTheDocument());
});
@@ -257,7 +257,7 @@ describe('DataManager busy categories (#3342)', () => {
await waitFor(() => expect(screen.getAllByText('LoRA Training Runs').length).toBeGreaterThan(0));
expandRow('LoRA Training Runs');
- expandRow('Messages');
+ expandRow('Screenshots');
await waitFor(() => expect(screen.getByRole('button', { name: /Purge/ })).toBeInTheDocument());
// The stale training-runs detail arrives last and must be dropped.
@@ -281,9 +281,9 @@ describe('DataManager busy categories (#3342)', () => {
purgeDataCategory.mockImplementation(() => new Promise((res) => { resolvePurge = res; }));
render(<DataManager />);
- await waitFor(() => expect(screen.getAllByText('Messages').length).toBeGreaterThan(0));
+ await waitFor(() => expect(screen.getAllByText('Screenshots').length).toBeGreaterThan(0));
- expandRow('Messages');
+ expandRow('Screenshots');
await waitFor(() => expect(screen.getByRole('button', { name: /Purge/ })).toBeInTheDocument());
fireEvent.click(screen.getByRole('button', { name: /Purge/ }));
fireEvent.click(screen.getByRole('button', { name: 'Purge' }));
@@ -291,7 +291,7 @@ describe('DataManager busy categories (#3342)', () => {
expandRow('LoRA Training Runs');
await waitFor(() => expect(screen.getByText(BUSY_REASON)).toBeInTheDocument());
- resolvePurge({ category: 'messages', subPath: null });
+ resolvePurge({ category: 'screenshots', subPath: null });
await waitFor(() => expect(getDataOverview).toHaveBeenCalledTimes(2));
expect(screen.getByText(BUSY_REASON)).toBeInTheDocument();
expect(screen.queryByRole('button', { name: /Purge/ })).not.toBeInTheDocument();
@@ -404,20 +404,20 @@ describe('DataManager treemap + selection panel', () => {
});
getDataCategory.mockReset().mockImplementation((key) => Promise.resolve({
key,
- items: key === 'messages' ? [{ name: 'inbox-archive', type: 'directory', size: 900, fileCount: 4 }] : [],
+ items: key === 'screenshots' ? [{ name: 'inbox-archive', type: 'directory', size: 900, fileCount: 4 }] : [],
}));
});
it('selects a category from its tile and nests its entries in the map', async () => {
render(<DataManager />);
- const tile = await screen.findByRole('button', { name: /^Messages/, pressed: false });
+ const tile = await screen.findByRole('button', { name: /^Screenshots/, pressed: false });
fireEvent.click(tile);
- await waitFor(() => expect(screen.getByRole('button', { name: /^Messages/, pressed: true })).toBeInTheDocument());
+ await waitFor(() => expect(screen.getByRole('button', { name: /^Screenshots/, pressed: true })).toBeInTheDocument());
// Entry name shows in the nested tile and in the expanded row's table.
await waitFor(() => expect(screen.getAllByText('inbox-archive').length).toBe(2));
const panel = screen.getByRole('complementary', { name: 'Selection details' });
- expect(panel).toHaveTextContent('data/messages');
+ expect(panel).toHaveTextContent('data/screenshots');
expect(panel).toHaveTextContent('Reclaimable');
});
@@ -439,7 +439,7 @@ describe('DataManager treemap + selection panel', () => {
await waitFor(() => expect(panel).toHaveTextContent('Worth a look'));
const shortlist = panel.querySelector('ul');
- expect(shortlist).toHaveTextContent('Messages');
+ expect(shortlist).toHaveTextContent('Screenshots');
expect(shortlist).toHaveTextContent('Legacy');
expect(shortlist).not.toHaveTextContent('Images');
expect(panel).toHaveTextContent('4 GB');
@@ -604,12 +604,12 @@ describe('DataManager training-run sources and individual cleanup', () => {
it('prevents overlapping item cleanup and an already-open bucket purge', async () => {
getDataOverview.mockResolvedValue({ ...busyOverview, categories: [{ ...busyOverview.categories[1] }] });
- getDataCategory.mockResolvedValue({ key: 'messages', items: [{ name: 'example-account', type: 'directory', size: 100 }] });
+ getDataCategory.mockResolvedValue({ key: 'screenshots', items: [{ name: 'example-account', type: 'directory', size: 100 }] });
purgeDataCategory.mockReset();
render(<DataManager />);
- await screen.findAllByText('Messages');
- expandRow('Messages');
- const remove = await screen.findByRole('button', { name: 'Delete example-account from Messages' });
+ await screen.findAllByText('Screenshots');
+ expandRow('Screenshots');
+ const remove = await screen.findByRole('button', { name: 'Delete example-account from Screenshots' });
fireEvent.click(screen.getByRole('button', { name: 'Purge' }));
expect(remove).toBeDisabled();
fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
@@ -619,7 +619,7 @@ it('prevents overlapping item cleanup and an already-open bucket purge', async (
fireEvent.click(screen.getByRole('button', { name: 'Delete' }));
expect(screen.getByRole('button', { name: 'Purge' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'Export backup (keeps originals)' })).toBeDisabled();
- await act(async () => finish({ category: 'messages', subPath: 'example-account' }));
+ await act(async () => finish({ category: 'screenshots', subPath: 'example-account' }));
});
diff --git a/server/routes/dataManager.test.js b/server/routes/dataManager.test.js
index c3e9ba5c43..ccc0381dae 100644
--- a/server/routes/dataManager.test.js
+++ b/server/routes/dataManager.test.js
@@ -37,9 +37,9 @@ describe('DELETE /api/data/:category', () => {
});
it('treats a bodiless request as a whole-category purge', async () => {
- const res = await request(makeApp()).delete('/api/data/messages').send({});
+ const res = await request(makeApp()).delete('/api/data/screenshots').send({});
expect(res.status).toBe(200);
- expect(purgeCategory).toHaveBeenCalledWith('messages', { subPath: undefined });
+ expect(purgeCategory).toHaveBeenCalledWith('screenshots', { subPath: undefined });
});
it('rejects a malformed subPath before the service is reached', async () => {
diff --git a/server/services/dataManager.busy.test.js b/server/services/dataManager.busy.test.js
index dd37507382..c3790b40ef 100644
--- a/server/services/dataManager.busy.test.js
+++ b/server/services/dataManager.busy.test.js
@@ -46,7 +46,7 @@ beforeEach(() => {
seed('image-clean-tmp', 'init-0000.png');
seed('training-runs', 'run-0001');
seed('update-detached', 'pid');
- seed('messages', 'index.json');
+ seed('screenshots', 'shot.png');
imageCleanTmpBusy.mockReset().mockImplementation(idle);
trainingRunsBusy.mockReset().mockImplementation(idle);
updateDetachedBusy.mockReset().mockImplementation(idle);
@@ -82,9 +82,9 @@ describe('purgeCategory — CATEGORY_BUSY refusal', () => {
});
it('leaves a category with no busyCheck completely unaffected', async () => {
- expect(CATEGORIES.messages.busyCheck).toBeUndefined();
- await purgeCategory('messages');
- expect(existsSync(dataPath('messages', 'index.json'))).toBe(false);
+ expect(CATEGORIES.screenshots.busyCheck).toBeUndefined();
+ await purgeCategory('screenshots');
+ expect(existsSync(dataPath('screenshots', 'shot.png'))).toBe(false);
});
// "Could not verify" and "nothing is running" must not collapse into the same
@@ -113,7 +113,7 @@ describe('busy state on the read paths', () => {
const { categories } = await getDataOverview();
const training = categories.find(c => c.key === 'training-runs');
expect(training).toMatchObject({ busy: true, busyReason: '2 LoRA training run(s) queued or running' });
- expect(categories.find(c => c.key === 'messages')).toMatchObject({ busy: false, busyReason: null });
+ expect(categories.find(c => c.key === 'screenshots')).toMatchObject({ busy: false, busyReason: null });
});
it('never leaks the busyCheck function into the payload', async () => {
diff --git a/server/services/dataManager.categories.test.js b/server/services/dataManager.categories.test.js
index 82b4252dc2..4289d99ab6 100644
--- a/server/services/dataManager.categories.test.js
+++ b/server/services/dataManager.categories.test.js
@@ -153,11 +153,25 @@ describe('dataManager purge scope (#3327)', () => {
// Uploads and renders that other records point at: reclaimable one at a time.
expect(CATEGORIES.images.purgeScope).toBe('items');
expect(CATEGORIES.videos.purgeScope).toBe('items');
- // Drafts live in Postgres; screenshots are task scratch — still wipeable whole.
- expect(CATEGORIES.messages.purgeScope).toBe('category');
+ // Screenshots are task scratch — still wipeable whole.
expect(CATEGORIES.screenshots.purgeScope).toBe('category');
});
+ // Issue #10912: these directories hold user-authored state with no other copy
+ // (drafts and the send-attempt audit, todos and assessment reports). Each entry
+ // records why it is protected; the table is the audit trail, not an inference.
+ const USER_STATE_CATEGORIES = {
+ messages: 'drafts, the delivery_unknown send audit, triage rules and account config',
+ review: 'Review Hub todos, pending CoS action requests and security assessment reports',
+ };
+ it.each(Object.entries(USER_STATE_CATEGORIES))(
+ 'never offers a purge for %s, which holds %s',
+ (key) => {
+ expect(CATEGORIES[key]).toMatchObject({ archivable: true, deletable: false });
+ expect(CATEGORIES[key].purgeScope).toBeUndefined();
+ }
+ );
+
it('protects durable backup admission authority from archive and both purge forms', async () => {
expect(CATEGORIES['backup-admission']).toMatchObject({ archivable: false, deletable: false });
await expect(archiveCategory('backup-admission')).rejects.toThrow(/is not archivable/);
@@ -187,12 +201,16 @@ describe('dataManager purge scope (#3327)', () => {
await expect(purgeCategory('beeper', { subPath: 'attachments' })).rejects.toThrow(/is not purgeable/);
await expect(purgeCategory('peer-execution')).rejects.toThrow(/is not purgeable/);
await expect(purgeCategory('peer-execution', { subPath: 'fixture-operation/evidence.json' })).rejects.toThrow(/is not purgeable/);
+ for (const options of [undefined, { subPath: 'account' }]) {
+ await expect(purgeCategory('messages', options)).rejects.toMatchObject({ status: 403, code: 'CATEGORY_NOT_PURGEABLE' });
+ await expect(purgeCategory('review', options)).rejects.toMatchObject({ status: 403, code: 'CATEGORY_NOT_PURGEABLE' });
+ }
});
it('fails closed when a deletable category has no recognized purgeScope', async () => {
- const original = CATEGORIES.messages.purgeScope;
- CATEGORIES.messages.purgeScope = 'typo';
- await expect(purgeCategory('messages')).rejects.toThrow(/only supports per-item purge/);
- CATEGORIES.messages.purgeScope = original;
+ const original = CATEGORIES.screenshots.purgeScope;
+ CATEGORIES.screenshots.purgeScope = 'typo';
+ await expect(purgeCategory('screenshots')).rejects.toThrow(/only supports per-item purge/);
+ CATEGORIES.screenshots.purgeScope = original;
});
});
diff --git a/server/services/dataManager.itemPurge.test.js b/server/services/dataManager.itemPurge.test.js
index d32fc65dc0..f778856c74 100644
--- a/server/services/dataManager.itemPurge.test.js
+++ b/server/services/dataManager.itemPurge.test.js
@@ -36,9 +36,9 @@ beforeEach(() => {
writeFileSync(dataPath('images', 'render-0001.png'), 'png');
writeFileSync(dataPath('images', 'render-0002.png'), 'png');
writeFileSync(dataPath('images', '.scratch', 'work.tmp'), 'tmp');
- // `messages` stays category-scoped.
- mkdirSync(dataPath('messages', 'account'), { recursive: true });
- writeFileSync(dataPath('messages', 'index.json'), '{}');
+ // `screenshots` stays category-scoped (and deletable: messages/review are not).
+ mkdirSync(dataPath('screenshots', 'account'), { recursive: true });
+ writeFileSync(dataPath('screenshots', 'index.json'), '{}');
});
describe('purgeCategory — item-scoped categories (#3327)', () => {
@@ -92,29 +92,29 @@ describe('purgeCategory — item-scoped categories (#3327)', () => {
describe('purgeCategory — category-scoped categories keep their behavior', () => {
it('empties the directory when no subPath is given', async () => {
- const result = await purgeCategory('messages');
- expect(result).toEqual({ category: 'messages', subPath: null });
- expect(existsSync(dataPath('messages', 'index.json'))).toBe(false);
- expect(existsSync(dataPath('messages', 'account'))).toBe(false);
- expect(existsSync(dataPath('messages'))).toBe(true);
+ const result = await purgeCategory('screenshots');
+ expect(result).toEqual({ category: 'screenshots', subPath: null });
+ expect(existsSync(dataPath('screenshots', 'index.json'))).toBe(false);
+ expect(existsSync(dataPath('screenshots', 'account'))).toBe(false);
+ expect(existsSync(dataPath('screenshots'))).toBe(true);
});
it('removes a named subdirectory recursively', async () => {
- writeFileSync(dataPath('messages', 'account', 'inbox.json'), '{}');
- await purgeCategory('messages', { subPath: 'account' });
- expect(existsSync(dataPath('messages', 'account'))).toBe(false);
- expect(existsSync(dataPath('messages', 'index.json'))).toBe(true);
+ writeFileSync(dataPath('screenshots', 'account', 'inbox.json'), '{}');
+ await purgeCategory('screenshots', { subPath: 'account' });
+ expect(existsSync(dataPath('screenshots', 'account'))).toBe(false);
+ expect(existsSync(dataPath('screenshots', 'index.json'))).toBe(true);
});
// A caller that meant to name an entry and produced an empty string must not
// land in the branch that empties the whole directory.
it('400s an empty subPath instead of widening it into a whole-category wipe', async () => {
- await expect(purgeCategory('messages', { subPath: '' })).rejects.toThrow(/single entry/);
- expect(existsSync(dataPath('messages', 'index.json'))).toBe(true);
+ await expect(purgeCategory('screenshots', { subPath: '' })).rejects.toThrow(/single entry/);
+ expect(existsSync(dataPath('screenshots', 'index.json'))).toBe(true);
});
it('still refuses a nested subPath', async () => {
- await expect(purgeCategory('messages', { subPath: '../images/render-0001.png' })).rejects.toThrow(/single entry/);
+ await expect(purgeCategory('screenshots', { subPath: '../images/render-0001.png' })).rejects.toThrow(/single entry/);
expect(existsSync(dataPath('images', 'render-0001.png'))).toBe(true);
});
});
diff --git a/server/services/dataManager.js b/server/services/dataManager.js
index 5164283382..4c6775bf84 100644
--- a/server/services/dataManager.js
+++ b/server/services/dataManager.js
@@ -145,7 +145,11 @@ export const CATEGORIES = {
'meatspace': { label: 'MeatSpace', description: 'Body metrics, blood tests, eyes', archivable: true, deletable: false },
'media-collections': { label: 'Media Collections', description: 'Media collection records', archivable: true, deletable: false },
'media-sketches': { label: 'Media Sketches', description: 'Saved sketch canvases used as render inputs', archivable: true, deletable: false },
- 'messages': { label: 'Messages', description: 'Email and messaging data', archivable: true, deletable: true, purgeScope: 'category' },
+ // Not deletable: drafts, the send-attempt audit (`delivery_unknown` records
+ // that stop a possibly-sent message being resent), triage rules and account
+ // configuration are user-authored and not regenerable. Only the mail cache is
+ // reproducible, and it is bounded per account, so no cache-only purge is offered.
+ 'messages': { label: 'Messages', description: 'Message accounts, drafts, triage rules and cached mail — drafts and rules are not regenerable', archivable: true, deletable: false },
'model-personality': { label: 'Model Personality', description: 'Model personality probe results and settings', archivable: true, deletable: false },
'model-tests': { label: 'Model Capability Tests', description: 'Throwaway agent sandboxes from the capability test suite — recreated per run, safe to purge', archivable: false, deletable: true, purgeScope: 'category' },
'music': { label: 'Music', description: 'Uploaded and generated background tracks', archivable: true, deletable: false },
@@ -169,7 +173,9 @@ export const CATEGORIES = {
// cache of anything re-fetchable, so it is neither archivable nor deletable.
'rapid-reader-library': { label: 'Rapid Reader Shelf', description: 'Saved books for Rapid Reader — pasted and URL-imported prose kept on this machine, not regenerable', archivable: false, deletable: false },
'repos': { label: 'Cloned Repos', description: 'Git repositories cloned by agents', archivable: false, deletable: true, purgeScope: 'category' },
- 'review': { label: 'Review', description: 'Review hub items', archivable: true, deletable: true, purgeScope: 'category' },
+ // Not deletable: user todos, pending CoS action requests and private security
+ // assessment reports live here and have no other copy.
+ 'review': { label: 'Review', description: 'Review Hub todos, action requests and assessment reports', archivable: true, deletable: false },
'rigging': { label: 'Rigging Clip Library', description: 'User-dropped animation-bearing GLB source files for retargeting — the only copy of assets you supplied', archivable: false, deletable: false },
'runs': { label: 'AI Runs', description: 'Agent run logs and outputs', archivable: true, deletable: true, purgeScope: 'category' },
'screenshots': { label: 'Screenshots', description: 'Task screenshots and images dropped into shell sessions — shell drops auto-delete after 7 days, others after 30 days unless an open task still uses them', archivable: true, deletable: true, purgeScope: 'category' },
diff --git a/server/services/review.js b/server/services/review.js
index a015d95eac..933ed0612b 100644
--- a/server/services/review.js
+++ b/server/services/review.js
@@ -69,8 +69,8 @@ const ARCHIVE_ELIGIBLE_STATUSES = new Set(['completed', 'dismissed']);
// Module-level cache of the parsed items.json, keyed on file identity (mtime +
// size) rather than an in-process "loaded" flag: `dataManager.js` registers
-// `review` as archivable/deletable, so `data/review/` can be archived or
-// deleted out from under this process while it runs, and a flag-based cache
+// `review` as archivable, so `data/review/` can still be replaced out from
+// under this process while it runs (restore, or a manual delete), and a flag-based cache
// would keep serving a since-deleted file's contents forever. `saveItems`
// INVALIDATES the cache after every write rather than seeding it from what it
// wrote: two saveItems calls can interleave (a route and a cosEvents handler
diff --git a/server/services/systemResources.js b/server/services/systemResources.js
index 63b09691b4..71ea2809b9 100644
--- a/server/services/systemResources.js
+++ b/server/services/systemResources.js
@@ -48,7 +48,6 @@ const LOW_RISK_DATA_CATEGORIES = new Set([
'image-clean-tmp',
'insights',
'jira-reports',
- 'review',
'runs',
'screenshots',
'tools',