Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: share migration-safe install data seeding (#11993)

Adam Eivyb93f52ba3bae
diff --git a/scripts/lib/seedDataDir.js b/scripts/lib/seedDataDir.js
new file mode 100644
index 0000000000..f03bdfa458
--- /dev/null
+++ b/scripts/lib/seedDataDir.js
@@ -0,0 +1,38 @@
+import { cpSync, existsSync, mkdirSync, readdirSync, statSync } from 'fs';
+import { join } from 'path';
+import { isSeedableReferencePath } from './migrationOwnedPaths.js';
+
+/**
+ * Seed a fresh or existing install without overwriting its records. Migration-
+ * owned paths must never land before migrations derive them from user data.
+ * Logging is opt-in so boot smoke can seed its disposable install silently.
+ */
+export function seedDataDir({ referenceDir, dataDir, log = () => {} }) {
+ const isSeedable = isSeedableReferencePath(referenceDir);
+ const created = !existsSync(dataDir);
+ if (created) {
+ log('📁 Creating data directory from data.reference...');
+ mkdirSync(dataDir, { recursive: true });
+ cpSync(referenceDir, dataDir, { recursive: true, filter: isSeedable });
+ } else {
+ const ensureSampleContent = (srcDir, destDir) => {
+ for (const item of readdirSync(srcDir)) {
+ const srcPath = join(srcDir, item);
+ if (!isSeedable(srcPath)) continue;
+ const destPath = join(destDir, item);
+ if (statSync(srcPath).isDirectory()) {
+ if (!existsSync(destPath)) {
+ log(`📁 Creating missing directory: ${item}`);
+ mkdirSync(destPath, { recursive: true });
+ }
+ ensureSampleContent(srcPath, destPath);
+ } else if (!existsSync(destPath)) {
+ log(`📄 Creating missing file: ${destPath.replace(dataDir + '/', '')}`);
+ cpSync(srcPath, destPath);
+ }
+ }
+ };
+ ensureSampleContent(referenceDir, dataDir);
+ }
+ return { created };
+}
diff --git a/scripts/lib/seedDataDir.test.js b/scripts/lib/seedDataDir.test.js
new file mode 100644
index 0000000000..a8088d2475
--- /dev/null
+++ b/scripts/lib/seedDataDir.test.js
@@ -0,0 +1,46 @@
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'fs';
+import { tmpdir } from 'os';
+import { join } from 'path';
+import { seedDataDir } from './seedDataDir.js';
+
+describe('seedDataDir migration safety', () => {
+ let root;
+ let referenceDir;
+ let dataDir;
+
+ beforeEach(() => {
+ root = mkdtempSync(join(tmpdir(), 'portos-seed-data-'));
+ referenceDir = join(root, 'data.reference');
+ dataDir = join(root, 'data');
+ mkdirSync(join(referenceDir, 'cos'), { recursive: true });
+ // Simulate an accidentally reintroduced seed for migration 339's output.
+ writeFileSync(join(referenceDir, 'cos/config.json'), 'shipped default');
+ writeFileSync(join(referenceDir, 'cos/starter.json'), 'starter content');
+ });
+
+ afterEach(() => rmSync(root, { recursive: true, force: true }));
+
+ it.each(['fresh', 'existing'])('never creates a migration-owned file in a %s install', (install) => {
+ if (install === 'existing') mkdirSync(dataDir);
+ seedDataDir({ referenceDir, dataDir });
+ expect(existsSync(join(dataDir, 'cos/config.json'))).toBe(false);
+ });
+
+ it('preserves the bytes of an existing migration-owned file', () => {
+ mkdirSync(join(dataDir, 'cos'), { recursive: true });
+ const original = Buffer.from([0, 255, 10, 123, 125]);
+ writeFileSync(join(dataDir, 'cos/config.json'), original);
+ seedDataDir({ referenceDir, dataDir });
+ expect(readFileSync(join(dataDir, 'cos/config.json'))).toEqual(original);
+ });
+
+ it('copies a missing ordinary file without replacing customized content on upgrade', () => {
+ mkdirSync(join(dataDir, 'cos'), { recursive: true });
+ writeFileSync(join(referenceDir, 'cos/custom.json'), 'shipped customization');
+ writeFileSync(join(dataDir, 'cos/custom.json'), 'user customization');
+ seedDataDir({ referenceDir, dataDir });
+ expect(readFileSync(join(dataDir, 'cos/starter.json'), 'utf8')).toBe('starter content');
+ expect(readFileSync(join(dataDir, 'cos/custom.json'), 'utf8')).toBe('user customization');
+ });
+});
diff --git a/scripts/setup-data.js b/scripts/setup-data.js
index f079884060..d4c57405d0 100644
--- a/scripts/setup-data.js
+++ b/scripts/setup-data.js
@@ -1,10 +1,10 @@
#!/usr/bin/env node
-import { existsSync, mkdirSync, cpSync, readdirSync, statSync, readFileSync, renameSync, rmdirSync } from 'fs';
+import { existsSync, readdirSync, readFileSync, renameSync, rmdirSync } from 'fs';
import { dirname, join } from 'path';
import { fileURLToPath } from 'url';
import { md5, buildPromptDriftTables } from './migrations/_lib.js';
-import { isSeedableReferencePath } from './lib/migrationOwnedPaths.js';
+import { seedDataDir } from './lib/seedDataDir.js';
import { mergeJsonStarterTargets } from './lib/mergeJsonStarter.js';
import { rewriteAppsPortosRoot } from './lib/rewriteAppsPortosRoot.js';
@@ -13,14 +13,6 @@ const rootDir = join(__dirname, '..');
const dataDir = join(rootDir, 'data');
const referenceDir = join(rootDir, 'data.reference');
-// Absolute data.reference paths this script must never copy: a migration builds
-// each of them from the install's own records, and setup-data runs BEFORE
-// run-migrations — so seeding one makes the migration see its output as already
-// present, no-op, and leave shipped defaults where the user's settings were.
-// See scripts/migrations/340-cos-config-seed-repair.js for the case that
-// prompted it.
-const isSeedable = isSeedableReferencePath(referenceDir);
-
console.log('📁 Setting up data directory...');
// One-shot cleanup for installs that predate the migrations-out-of-data move:
@@ -54,40 +46,11 @@ const rewritePortosRootPlaceholder = () => {
}
};
-if (!existsSync(dataDir)) {
- console.log('📁 Creating data directory from data.reference...');
- mkdirSync(dataDir, { recursive: true });
- cpSync(referenceDir, dataDir, { recursive: true, filter: isSeedable });
- rewritePortosRootPlaceholder();
- console.log('✅ Data directory created');
-} else {
- // Ensure all subdirectories and files exist without overwriting existing files
- const ensureSampleContent = (srcDir, destDir) => {
- const items = readdirSync(srcDir);
- for (const item of items) {
- const srcPath = join(srcDir, item);
- if (!isSeedable(srcPath)) continue;
- const destPath = join(destDir, item);
- const stat = statSync(srcPath);
-
- if (stat.isDirectory()) {
- if (!existsSync(destPath)) {
- console.log(`📁 Creating missing directory: ${item}`);
- mkdirSync(destPath, { recursive: true });
- }
- ensureSampleContent(srcPath, destPath);
- } else if (!existsSync(destPath)) {
- console.log(`📄 Creating missing file: ${destPath.replace(dataDir + '/', '')}`);
- cpSync(srcPath, destPath);
- }
- }
- };
-
- ensureSampleContent(referenceDir, dataDir);
- rewritePortosRootPlaceholder();
-
- console.log('✅ Data directory already exists, ensured subdirectories and files');
-}
+const { created } = seedDataDir({ referenceDir, dataDir, log: console.log });
+rewritePortosRootPlaceholder();
+console.log(created
+ ? '✅ Data directory created'
+ : '✅ Data directory already exists, ensured subdirectories and files');
// Merge new top-level entries from data.reference's structured JSON files into
// the user's existing copies, leaving customized entries untouched. Without
diff --git a/scripts/smoke-boot.js b/scripts/smoke-boot.js
index dc27ad5bf0..35cbb737bf 100644
--- a/scripts/smoke-boot.js
+++ b/scripts/smoke-boot.js
@@ -32,7 +32,7 @@ import { dirname, join } from 'path';
import { DATA_ROOT_ENV, DISPOSABLE_ROOT_MARKER } from '../server/lib/dataRoot.js';
import { SMOKE_BOOT_ENV } from '../server/lib/runtimeEnv.js';
import { isDirectlyInvoked } from './lib/directInvocation.js';
-import { isSeedableReferencePath } from './lib/migrationOwnedPaths.js';
+import { seedDataDir } from './lib/seedDataDir.js';
import { rewriteAppsPortosRoot } from './lib/rewriteAppsPortosRoot.js';
const __dirname = dirname(fileURLToPath(import.meta.url));
@@ -69,7 +69,7 @@ export function createSmokeRoot({ codeRoot = CODE_ROOT, tmpBase = tmpdir() } = {
const referenceDir = join(root, 'data.reference');
const dataDir = join(root, 'data');
cpSync(join(codeRoot, 'data.reference'), referenceDir, { recursive: true, dereference: true });
- cpSync(referenceDir, dataDir, { recursive: true, filter: isSeedableReferencePath(referenceDir) });
+ seedDataDir({ referenceDir, dataDir });
rewriteAppsPortosRoot(dataDir, codeRoot);
} catch (err) {
rmSync(root, { recursive: true, force: true });