Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: keep incomplete image forms from requesting prompt previews
[._.]/ Adam Eivyb9df07ec22c1
diff --git a/client/src/hooks/useImageGenPageRuntime.js b/client/src/hooks/useImageGenPageRuntime.jsindex 76a5a3b57c..0effc93e4d 100644--- a/client/src/hooks/useImageGenPageRuntime.js+++ b/client/src/hooks/useImageGenPageRuntime.js@@ -336,7 +336,9 @@ export function useImageGenPageRuntime() {...(uploadedReferenceCount ? { uploadedReferenceCount, referenceStrengths } : {}),};})();- const modelInputPreview = useModelInputPreview(previewImagePrompt, previewBody, { enabled: !form.remix.pending });+ const modelInputPreview = useModelInputPreview(previewImagePrompt, previewBody, {+ enabled: !form.remix.pending && !derived.cloudNeedsPrompt && !derived.editImageMissing,+ });const submitGenerationPayload = async () => {const { payload, initFields, referenceFields, hasInputImages } = buildGenerationPayload();diff --git a/client/src/hooks/useModelInputPreview.js b/client/src/hooks/useModelInputPreview.jsindex f32028c421..661b006f21 100644--- a/client/src/hooks/useModelInputPreview.js+++ b/client/src/hooks/useModelInputPreview.js@@ -22,10 +22,13 @@ export function useModelInputPreview(fetchPreview, body, { enabled = true } = {}.then((preview) => { if (current === generation.current) setState({ preview, error: null }); }).catch((err) => { if (current === generation.current) setState({ preview: null, error: err?.message || 'Preview failed' }); });}, PREVIEW_DELAY_MS);- return () => clearTimeout(timer);+ return () => {+ clearTimeout(timer);+ generation.current++;+ };}, [fetchPreview, key]);- return state;+ return enabled ? state : { preview: null, error: null };}export default useModelInputPreview;diff --git a/client/src/hooks/useModelInputPreview.test.js b/client/src/hooks/useModelInputPreview.test.jsindex 9d5275e022..33559e4ed2 100644--- a/client/src/hooks/useModelInputPreview.test.js+++ b/client/src/hooks/useModelInputPreview.test.js@@ -32,4 +32,20 @@ describe('useModelInputPreview', () => {await act(async () => { vi.advanceTimersByTime(500); });expect(result.current).toEqual({ preview: null, error: 'Codex Imagegen is disabled' });});++ it('hides the preview when disabled and drops an in-flight refusal', async () => {+ vi.useFakeTimers();+ let rejectPreview;+ const fetchPreview = vi.fn(() => new Promise((_resolve, reject) => { rejectPreview = reject; }));+ const { result, rerender } = renderHook(+ ({ enabled }) => useModelInputPreview(fetchPreview, { prompt: 'a fox' }, { enabled }),+ { initialProps: { enabled: true } },+ );+ await act(async () => { vi.advanceTimersByTime(500); });+ rerender({ enabled: false });+ expect(result.current).toEqual({ preview: null, error: null });+ await act(async () => { rejectPreview(new Error('stale refusal')); });+ rerender({ enabled: true });+ expect(result.current).toEqual({ preview: null, error: null });+ });});diff --git a/client/src/pages/ImageGen.promptPreview.test.jsx b/client/src/pages/ImageGen.promptPreview.test.jsxindex 988971d974..bd5c4e75c6 100644--- a/client/src/pages/ImageGen.promptPreview.test.jsx+++ b/client/src/pages/ImageGen.promptPreview.test.jsx@@ -1,4 +1,4 @@-import { beforeEach, describe, expect, it, vi } from 'vitest';+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';import { act, fireEvent, screen, waitFor } from '@testing-library/react';import {@@ -18,6 +18,7 @@ await loadImageGenPage();// The preview body is the Generate request with the upload named by count// (no bytes ride a JSON body), and the box keeps only the typed words.describe('ImageGen prompt preview', () => {+ afterEach(() => vi.useRealTimers());beforeEach(() => {resetImageGenMockState();state.settings = { imageGen: { mode: 'codex' } };@@ -31,6 +32,21 @@ describe('ImageGen prompt preview', () => {vi.stubGlobal('createImageBitmap', vi.fn(() => Promise.reject(new Error('no decoder'))));});+ it('leaves an untouched Codex form quiet but previews image-only edits', async () => {+ await renderImageGenPage('/media/image');+ vi.useFakeTimers();+ fireEvent.change(screen.getByLabelText('Prompt'), { target: { value: ' ' } });+ await act(async () => { vi.advanceTimersByTime(1000); });+ expect(state.previewImagePrompt).not.toHaveBeenCalled();++ await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'pick-init' })); });+ await act(async () => { vi.advanceTimersByTime(500); });+ expect(state.previewImagePrompt).toHaveBeenCalledWith(+ expect.objectContaining({ prompt: '', uploadedInitImage: true }),+ { silent: true },+ );+ });+it('previews the request with the upload counted and shows the additions as chips', async () => {await renderImageGenPage('/media/image');fireEvent.change(screen.getByLabelText('Prompt'), { target: { value: 'a red fox' } });