Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: verify claim reviewer identities before dispatch (#13522)

Adam Eivybeba3d5b9b92
diff --git a/server/services/claimReviewerPreflight.js b/server/services/claimReviewerPreflight.js
new file mode 100644
index 0000000000..60d8bf3333
--- /dev/null
+++ b/server/services/claimReviewerPreflight.js
@@ -0,0 +1,38 @@
+import { ServerError } from '../lib/errorHandler.js';
+
+/** Check the resolved roster before any claim prompt is rendered. */
+export async function preflightClaimReviewers(app, config, { metadata = {}, appOverrideMetadata = {}, explicit = {}, taskType = 'claim-work' } = {}) {
+ if (!config.usernames.length && !config.optionalReviewers.some(r => r.startsWith('@'))) return '';
+ // Keep forge I/O out of the common local-reviewer-only dispatch graph.
+ const { resolveAppForgeTarget } = await import('../lib/workTracker.js');
+ const { target } = await resolveAppForgeTarget(app);
+ if (!target) return ''; // An unresolved target is not proof an identity is missing.
+ const { preflightReviewerIdentities } = await import('./reviewerIdentity.js');
+ const result = await preflightReviewerIdentities({
+ usernames: config.usernames,
+ optionalReviewers: config.optionalReviewers,
+ forge: target.forge,
+ host: target.apiHost,
+ });
+ const describe = entry => {
+ const field = config.usernames.some(u => u.toLowerCase() === entry.token.toLowerCase())
+ ? 'usernames' : 'optionalReviewers';
+ const setting = Array.isArray(explicit[field])
+ ? `the claim request (${field})`
+ : Array.isArray(appOverrideMetadata[field])
+ ? `Apps → Automation → ${taskType} → Reviewers (taskMetadata.${field})`
+ : Array.isArray(metadata[field])
+ ? `Tasks → Schedule → ${taskType} → Reviewers (taskMetadata.${field})`
+ : `Settings → Code Reviewers (${field})`;
+ return `@${entry.token}: ${entry.reason}. Repair the @${entry.token} entry in ${setting}.`;
+ };
+ if (result.requiredMissing.length) {
+ throw new ServerError(`Claim dispatch blocked: required reviewer identity configuration fault. ${result.requiredMissing.map(describe).join(' ')}`, {
+ status: 409,
+ code: 'REVIEWER_IDENTITY_NOT_FOUND',
+ context: { reviewers: result.requiredMissing.map(e => e.token) },
+ });
+ }
+ if (!result.optionalMissing.length) return '';
+ return `\n\n## Reviewer identity preflight\n${result.optionalMissing.map(describe).join(' ')} These reviewers remain optional and were not verified as available. Report this configuration fault in the run summary; do not change the saved roster.\n`;
+}
diff --git a/server/services/cosTaskClaimWork.js b/server/services/cosTaskClaimWork.js
index f82d40bdff..d0ea56fb26 100644
--- a/server/services/cosTaskClaimWork.js
+++ b/server/services/cosTaskClaimWork.js
@@ -24,6 +24,7 @@ import { resolveAppPrCompletion } from '../lib/prDisposition.js';
import { ServerError } from '../lib/errorHandler.js';
import { getAppTaskTypeOverrides } from './apps.js';
import { getCodeReviewDefaults } from './codeReview.js';
+import { preflightClaimReviewers } from './claimReviewerPreflight.js';
import {
appendClaimOverrideContext,
appendPrefetchedIssueContext,
@@ -53,7 +54,7 @@ import {
* prompt. Shared by `buildClaimWorkTask` and the work-item picker route, so the
* items offered are scanned with the SAME author filter the claim agent will use.
*
- * @returns {Promise<{ metadata: object, interval: object }>}
+ * @returns {Promise<{ metadata: object, interval: object, appOverrideMetadata: object }>}
*/
export async function resolveClaimWorkMetadata(app, taskType = 'claim-work') {
const taskSchedule = await import('./taskSchedule.js');
@@ -71,7 +72,7 @@ export async function resolveClaimWorkMetadata(app, taskType = 'claim-work') {
);
const sanitizedAppMeta = sanitizeTaskMetadata(strippedAppOverride);
if (sanitizedAppMeta) Object.assign(metadata, sanitizedAppMeta);
- return { metadata, interval };
+ return { metadata, interval, appOverrideMetadata: sanitizedAppMeta || {} };
}
/**
@@ -185,7 +186,7 @@ export async function buildClaimWorkTask(app, {
// The tracker probe (a `git` shell-out), the configured claim-work metadata,
// and the Code Review Defaults are mutually independent — only the prompt-body
// read below depends on them, so overlap the three.
- const [wt, { metadata, interval }, codeReviewDefaults] = await Promise.all([
+ const [wt, { metadata, interval, appOverrideMetadata }, codeReviewDefaults] = await Promise.all([
resolveAppWorkTracker(app),
resolveClaimWorkMetadata(app),
getCodeReviewDefaults().catch(() => null)
@@ -208,6 +209,9 @@ export async function buildClaimWorkTask(app, {
reviewers, usernames, optionalReviewers, reviewerMaxRounds, reviewerModels, reviewerEfforts,
prCompletion: effectivePrCompletion
});
+ const reviewerIdentityNotice = await preflightClaimReviewers(app, claimReviewers, {
+ metadata, appOverrideMetadata, explicit: { usernames, optionalReviewers }, taskType: 'claim-work',
+ });
const {
reviewers: reviewersList,
reviewerModels: promptReviewerModels,
@@ -225,7 +229,7 @@ export async function buildClaimWorkTask(app, {
const targetRef = normalizeWorkItemRef(target);
const swarmBlock = targetRef ? '' : resolveSwarmBlock(promptTaskType, metadata.swarmCount);
- const prompt = applyAppPlaceholders(`${swarmBlock}${template}`, app)
+ const prompt = reviewerIdentityNotice + applyAppPlaceholders(`${swarmBlock}${template}`, app)
// Function-form replacers so literal `$`/`$1` in the substituted text isn't
// interpreted as a backreference (see the scheduler's same-pattern note).
.replace(/\{reviewers\}/g, () => reviewersCsv || 'none')
@@ -274,7 +278,7 @@ export async function buildClaimWorkTask(app, {
* prompt builder resolves the same list back off the task record (#4770).
*/
async function resolveClaimReviewerPrompt(app) {
- const [{ metadata }, codeReviewDefaults] = await Promise.all([
+ const [{ metadata, appOverrideMetadata }, codeReviewDefaults] = await Promise.all([
resolveClaimWorkMetadata(app),
getCodeReviewDefaults().catch(() => null)
]);
@@ -283,12 +287,13 @@ async function resolveClaimReviewerPrompt(app) {
// resolving from the defaults alone would silently drop a pinned override.
const effectivePrCompletion = metadata?.prCompletion ?? resolveAppPrCompletion(app, metadata);
const config = claimReviewersFrom(metadata, codeReviewDefaults, { prCompletion: effectivePrCompletion });
+ const reviewerIdentityNotice = await preflightClaimReviewers(app, config, { metadata, appOverrideMetadata });
const { reviewers: list, reviewerModels, reviewerEfforts, csv } = config;
return {
csv,
taskMetadata: reviewerConfigMetadata(config),
effortBlock: appendReviewerEffortBlock(list, reviewerEfforts, reviewerModels),
- localReviewerBlock: buildLocalReviewerInstructions(list, reviewerModels, reviewerEfforts, { enforceIsolation: true }),
+ localReviewerBlock: reviewerIdentityNotice + buildLocalReviewerInstructions(list, reviewerModels, reviewerEfforts, { enforceIsolation: true }),
};
}
diff --git a/server/services/cosTaskGenerator.js b/server/services/cosTaskGenerator.js
index fdd56a112e..2e9dabe3d6 100644
--- a/server/services/cosTaskGenerator.js
+++ b/server/services/cosTaskGenerator.js
@@ -2015,7 +2015,9 @@ export async function emitOnDemandEmpty({ taskScheduleMod, request, targetApp, t
const appId = targetApp?.id || null;
const parkInfo = await taskScheduleMod.getPerpetualParkInfo(request.taskType, appId).catch(() => null);
const isDetectorDriven = taskConfig?.perpetual === true || request.taskType === 'branch-reconcile';
- const outcome = parkInfo ? 'parked' : (isDetectorDriven ? 'transient' : 'idle');
+ const outcome = skip?.gate === 'reviewer-identity'
+ ? 'transient'
+ : parkInfo ? 'parked' : (isDetectorDriven ? 'transient' : 'idle');
// Layered Intelligence skips (e.g. a provider that can't drive an agent) record
// an actionable last-run reason. Surface it so a manual "Run" toasts WHY it
@@ -2023,6 +2025,7 @@ export async function emitOnDemandEmpty({ taskScheduleMod, request, targetApp, t
// generic "nothing to do". Read the freshest record — the skip's recordRun
// landed after `targetApp` was loaded. Best-effort; a read failure just omits it.
let reason = null;
+ if (skip?.gate === 'reviewer-identity') reason = skip.reason;
if (outcome === 'idle' && appId && request.taskType === 'layered-intelligence') {
const { getAppById } = await import('./apps.js');
const app = await getAppById(appId).catch(() => null);
@@ -2048,7 +2051,9 @@ export async function emitOnDemandEmpty({ taskScheduleMod, request, targetApp, t
// way that won't self-clear, and pass the remedy through. No verdict, an
// unprobeable CLI, or a healthy one all leave `forge` null and keep the
// generic copy — the failure really was a blip, or at least not one we can name.
- let forge = null;
+ let forge = skip?.gate === 'reviewer-identity'
+ ? { cli: 'reviewer identity', remedy: skip.reason }
+ : null;
const verdict = outcome === 'transient' && skip?.gate === 'perpetual-work' ? skip : null;
if (verdict?.remedy) {
// The detector already knew the fault AND the way out — a per-repo permission
@@ -2732,22 +2737,36 @@ export async function prepareManagedAppImprovementTask(taskType, app, state, {
// Resolve completion before rendering reviewers, including claim flows that
// own their PR while intentionally disabling CoS worktree provisioning.
applyAppWorktreeDefault(metadata, app);
- const baseDescription = await buildImprovementTaskDescription({
- promptTemplate: applyAuditModeWrapper(applyDepfreeMode(applyReleaseOptions(promptTemplate, promptTaskType, metadata), promptTaskType, metadata), modeInstructions),
- app, promptTaskType, metadata,
- blocks: {
- referenceData: referenceDataBlock,
- trackerInstructions: trackerFiling.trackerInstructions,
- modeInstructions,
- prData: prDataBlock,
- inFlightBranches: inFlightBranchesBlock,
- zombieIssues: zombieIssuesBlock,
- repoSyncReport: repoSyncReportBlock,
- repoFullName: prRepoFullName,
- defaultBranch: prDefaultBranch,
- planConstraint: planConstraintBlock
- }
- });
+ let baseDescription;
+ try {
+ baseDescription = await buildImprovementTaskDescription({
+ promptTemplate: applyAuditModeWrapper(applyDepfreeMode(applyReleaseOptions(promptTemplate, promptTaskType, metadata), promptTaskType, metadata), modeInstructions),
+ app, promptTaskType, metadata,
+ reviewerTaskType: taskType, reviewerOverrideMetadata: appOverride?.taskMetadata,
+ blocks: {
+ referenceData: referenceDataBlock,
+ trackerInstructions: trackerFiling.trackerInstructions,
+ modeInstructions,
+ prData: prDataBlock,
+ inFlightBranches: inFlightBranchesBlock,
+ zombieIssues: zombieIssuesBlock,
+ repoSyncReport: repoSyncReportBlock,
+ repoFullName: prRepoFullName,
+ defaultBranch: prDefaultBranch,
+ planConstraint: planConstraintBlock
+ }
+ });
+ } catch (err) {
+ if (err.code !== 'REVIEWER_IDENTITY_NOT_FOUND') throw err;
+ emitLog('info', err.message, { appId: app.id, analysisType: taskType });
+ const { recordPreflightOutcome } = await import('./preflightTaskCard.js');
+ await recordPreflightOutcome({
+ requestId: preflightCardId?.replace(/^preflight-/, '') || `reviewer-identity-${app.id}-${taskType}-${Date.now().toString(36)}`,
+ taskType, appId: app.id, appName: app.name,
+ outcome: 'failed', reason: err.code, note: err.message,
+ });
+ return skipped('reviewer-identity', { reason: err.message, detail: err.context });
+ }
const taskDataInputs = await resolveTaskDataInputs(interval.dataInputs, {
app, taskMetadata: metadata, taskType: promptTaskType,
trustedPullRequestData: prDataBlock,
diff --git a/server/services/cosTaskGenerator.providerPin.test.js b/server/services/cosTaskGenerator.providerPin.test.js
index b3c85c0504..0bc7e27364 100644
--- a/server/services/cosTaskGenerator.providerPin.test.js
+++ b/server/services/cosTaskGenerator.providerPin.test.js
@@ -13,12 +13,35 @@
*/
import { describe, it, expect, beforeEach, vi } from 'vitest';
+import { __resetReviewerIdentityCache } from './reviewerIdentity.js';
+import { buildClaimWorkTask, buildJiraTicketTask } from './cosTaskClaimWork.js';
+import { emitOnDemandEmpty } from './cosTaskGenerator.js';
+import { cosEvents } from './cosEvents.js';
vi.mock('./taskPromptService.js', () => ({
getTaskPrompt: vi.fn(async () => 'Improve {appName} at {repoPath}\n{issueAuthorFilter}\n{issueExcludeLabels}\nReviewers: {reviewers}'),
getStagePrompt: vi.fn(async () => 'Improve {appName} at {repoPath}\n{issueAuthorFilter}\n{issueExcludeLabels}\nReviewers: {reviewers}'),
}));
+const getCodeReviewDefaultsMock = vi.fn(async () => ({ reviewers: ['codex'], usernames: [], optionalReviewers: [] }));
+vi.mock('./codeReview.js', async original => ({
+ ...await original(), getCodeReviewDefaults: (...args) => getCodeReviewDefaultsMock(...args),
+}));
+const identityLookup = vi.fn(async () => ({}));
+vi.mock('./github.js', async original => ({ ...await original(), execGh: (...args) => identityLookup(...args) }));
+const targetMock = vi.fn(async () => ({ tracker: 'github', target: { forge: 'github', apiHost: 'github.example.test' } }));
+vi.mock('../lib/workTracker.js', async original => ({ ...await original(),
+ resolveAppForgeTarget: (...args) => targetMock(...args),
+ resolveAppWorkTracker: vi.fn(async () => ({ resolved: 'github', source: 'test' })),
+}));
+const recordPreflightOutcome = vi.fn(async () => {});
+const finishPreflightCard = vi.fn(async () => {});
+vi.mock('./preflightTaskCard.js', () => ({
+ recordPreflightOutcome: (...args) => recordPreflightOutcome(...args),
+ finishPreflightCard: (...args) => finishPreflightCard(...args),
+ preflightReporter: () => vi.fn(async () => {}),
+}));
+
const getTaskIntervalMock = vi.fn(async () => ({ type: 'weekly', taskMetadata: {} }));
vi.mock('./taskSchedule.js', () => ({
INTERVAL_TYPES: { PERPETUAL: 'perpetual', WEEKLY: 'weekly' },
@@ -238,3 +261,90 @@ describe('prepareManagedAppImprovementTask skip result', () => {
expect(prepared).toMatchObject({ task: null, pendingPerpetualDispatch: null, skip: { gate: 'install-wide-target', reason: null } });
});
});
+
+
+describe('claim dispatch reviewer identity preflight (#13522)', () => {
+ beforeEach(() => {
+ vi.clearAllMocks();
+ __resetReviewerIdentityCache();
+ identityLookup.mockReset().mockResolvedValue({});
+ targetMock.mockResolvedValue({ tracker: 'github', target: { forge: 'github', apiHost: 'github.example.test' } });
+ getTaskIntervalMock.mockResolvedValue({ type: 'weekly', taskMetadata: {} });
+ getAppTaskTypeOverridesMock.mockResolvedValue({});
+ getCodeReviewDefaultsMock.mockResolvedValue({ reviewers: ['codex'], usernames: ['missing-reviewer'], optionalReviewers: [] });
+ });
+
+ const prepare = () => prepareManagedAppImprovementTask('claim-issue', APP, STATE, { skipPreconditions: true });
+ const missing = () => { throw Object.assign(new Error('gh: Not Found (HTTP 404)'), { ghStderr: 'gh: Not Found (HTTP 404)' }); };
+
+ it('blocks the scheduled prompt and records the exact default entry; repeated dispatch reuses the identity cache', async () => {
+ identityLookup.mockImplementation(missing);
+ const prepared = await prepare();
+ expect(prepared.task).toBeNull();
+ expect(prepared.skip).toMatchObject({ gate: 'reviewer-identity', detail: { reviewers: ['missing-reviewer'] } });
+ expect(prepared.skip.reason).toContain('@missing-reviewer');
+ expect(prepared.skip.reason).toContain('Settings → Code Reviewers (usernames)');
+ expect(recordPreflightOutcome).toHaveBeenCalledWith(expect.objectContaining({ outcome: 'failed', reason: 'REVIEWER_IDENTITY_NOT_FOUND', note: prepared.skip.reason }));
+ await prepare();
+ expect(identityLookup).toHaveBeenCalledTimes(1);
+ expect(identityLookup).toHaveBeenCalledWith(['api', '--hostname', 'github.example.test', 'users/missing-reviewer'], 8000);
+ const emitted = vi.fn();
+ cosEvents.on('schedule:on-demand-empty', emitted);
+ try {
+ await emitOnDemandEmpty({ taskScheduleMod: { getPerpetualParkInfo: async () => null }, request: { id: 'request-1', taskType: 'claim-issue' }, targetApp: APP, taskConfig: { perpetual: false }, skip: prepared.skip });
+ expect(emitted).toHaveBeenCalledWith(expect.objectContaining({ outcome: 'transient', reason: prepared.skip.reason, forge: { cli: 'reviewer identity', remedy: prepared.skip.reason } }));
+ } finally {
+ cosEvents.off('schedule:on-demand-empty', emitted);
+ }
+ });
+
+ it('blocks both manual claim builders before returning a prompt and names a task override entry', async () => {
+ identityLookup.mockImplementation(missing);
+ getTaskIntervalMock.mockResolvedValue({ type: 'weekly', taskMetadata: { usernames: ['missing-reviewer'] } });
+ await expect(buildClaimWorkTask(APP)).rejects.toMatchObject({ code: 'REVIEWER_IDENTITY_NOT_FOUND', message: expect.stringContaining('Tasks → Schedule → claim-work → Reviewers (taskMetadata.usernames)') });
+ await expect(buildJiraTicketTask(APP, 'TEST-123')).rejects.toMatchObject({ code: 'REVIEWER_IDENTITY_NOT_FOUND' });
+ expect(identityLookup).toHaveBeenCalledTimes(1);
+ });
+
+ it('names the per-app settings entry when an app override supplied the missing reviewer', async () => {
+ identityLookup.mockImplementation(missing);
+ getAppTaskTypeOverridesMock.mockResolvedValue({ 'claim-issue': { taskMetadata: { usernames: ['missing-reviewer'] } } });
+ const prepared = await prepare();
+ expect(prepared.skip.reason).toContain('Apps → Automation → claim-issue → Reviewers (taskMetadata.usernames)');
+ });
+
+ it('preserves healthy reviewer roster and prompt metadata', async () => {
+ const { task, skip } = await prepare();
+ expect(skip).toBeNull();
+ expect(task.description).toContain('Reviewers: codex,@missing-reviewer');
+ expect(task.metadata.usernames).toEqual(['missing-reviewer']);
+ expect(task.description).not.toContain('Reviewer identity preflight');
+ expect(recordPreflightOutcome).not.toHaveBeenCalled();
+ });
+
+ it('does not classify authentication failure as a missing identity', async () => {
+ identityLookup.mockRejectedValue(new Error('HTTP 401: Bad credentials'));
+ const { task, skip } = await prepare();
+ expect(skip).toBeNull();
+ expect(task.description).toContain('@missing-reviewer');
+ expect(recordPreflightOutcome).not.toHaveBeenCalled();
+ });
+
+ it('reports a verified-missing optional entry without blocking or rewriting its roster', async () => {
+ identityLookup.mockImplementation(missing);
+ getCodeReviewDefaultsMock.mockResolvedValue({ reviewers: ['codex'], usernames: ['missing-reviewer'], optionalReviewers: ['@missing-reviewer'] });
+ const { task, skip } = await prepare();
+ expect(skip).toBeNull();
+ expect(task.description).toContain('@missing-reviewer~opt');
+ expect(task.description).toContain('Reviewer identity preflight');
+ expect(task.description).toContain('Report this configuration fault in the run summary');
+ expect(task.metadata.optionalReviewers).toEqual(['@missing-reviewer']);
+ });
+
+ it('does not send GitHub identity probes to a GitLab target', async () => {
+ targetMock.mockResolvedValue({ tracker: 'gitlab', target: { forge: 'gitlab', apiHost: null } });
+ const { task } = await prepare();
+ expect(task.description).toContain('@missing-reviewer');
+ expect(identityLookup).not.toHaveBeenCalled();
+ });
+});
diff --git a/server/services/cosTaskPreStepBlocks.js b/server/services/cosTaskPreStepBlocks.js
index e2c548821e..d051804401 100644
--- a/server/services/cosTaskPreStepBlocks.js
+++ b/server/services/cosTaskPreStepBlocks.js
@@ -31,6 +31,7 @@ import { resolveClaimReviewerConfig, reviewerConfigMetadata, SWARM_COUNT_MIN, IS
import { emitLog } from './cosEvents.js';
import { getActiveApps } from './apps.js';
import { getCodeReviewDefaults } from './codeReview.js';
+import { preflightClaimReviewers } from './claimReviewerPreflight.js';
import { NON_ACTIONABLE_ISSUE_LABELS } from './perpetualWork.js';
import { DISPATCH_HINT_FANOUT_GUIDANCE } from '../lib/dispatchLabels.js';
import { applyAppPlaceholders } from '../lib/appPromptPlaceholders.js';
@@ -1057,7 +1058,7 @@ export async function resolvePrWatcherBlock(app, taskType, metadata, taskSchedul
* reviewers stamps the resolved bundle back onto `metadata` (see below), the
* same way `applyPlanIdMetadata` writes `planId`.
*/
-export async function buildImprovementTaskDescription({ promptTemplate, app, promptTaskType, metadata, blocks }) {
+export async function buildImprovementTaskDescription({ promptTemplate, app, promptTaskType, metadata, blocks, reviewerTaskType = promptTaskType, reviewerOverrideMetadata = {} }) {
// Resolve the `{reviewers}` the agent is told to run. When the task itself
// didn't pin reviewers, fall back to the user's PortOS Code Review Defaults
// (Settings → Code Reviewers) rather than a hardcoded reviewer —
@@ -1072,6 +1073,10 @@ export async function buildImprovementTaskDescription({ promptTemplate, app, pro
// receive it without needing a new placeholder.
const codeReviewDefaults = await getCodeReviewDefaults().catch(() => null);
const claimReviewers = resolveClaimReviewerConfig(metadata, codeReviewDefaults, codeReviewDefaults?.reviewers);
+ const rendersReviewers = /\{reviewers\}/.test(promptTemplate);
+ const reviewerIdentityNotice = rendersReviewers
+ ? await preflightClaimReviewers(app, claimReviewers, { metadata, appOverrideMetadata: reviewerOverrideMetadata, taskType: reviewerTaskType })
+ : '';
const {
reviewers: promptReviewers,
reviewerModels: promptReviewerModels,
@@ -1091,9 +1096,6 @@ export async function buildImprovementTaskDescription({ promptTemplate, app, pro
// sanitizeTaskMetadata, so read it from `metadata`. Empty for non-issue
// trackers and when swarm is off.
const swarmBlock = resolveSwarmBlock(promptTaskType, metadata.swarmCount);
- // Does this template drive its own reviewers? Gates the two reviewer blocks
- // appended after the substitutions below, and the persisted bundle.
- const rendersReviewers = /\{reviewers\}/.test(promptTemplate);
// Persist what the prompt just named, so `resolveReviewerConfig(task.metadata, …)`
// at spawn time reads back THIS list instead of re-deriving the install-wide
// Code Review Defaults — that is what lets the reviewer pin be emitted once,
@@ -1108,7 +1110,7 @@ export async function buildImprovementTaskDescription({ promptTemplate, app, pro
.replace(/\{modeInstructions\}/g, () => blocks.modeInstructions || '')
.replace(/\{trackerInstructions\}/g, () => blocks.trackerInstructions);
- return applyAppPlaceholders(withBlocks, app)
+ return reviewerIdentityNotice + applyAppPlaceholders(withBlocks, app)
// Function form — reviewersCsv can carry a user-set reviewerModels pin,
// and normalizeReviewerModel allows `$` in that free text (only `[`, `]`,
// `,`, and line breaks/tabs are forbidden), so a string replacement would