Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix(cos): remove unused task generator wrapper (#12578)
[._.]/ Adam Eivyc9193764b4d1
diff --git a/docs/plans/2026-07-08-layered-intelligence-scheduled-task-migration.md b/docs/plans/2026-07-08-layered-intelligence-scheduled-task-migration.mdindex bb85acb065..aaccf7c979 100644--- a/docs/plans/2026-07-08-layered-intelligence-scheduled-task-migration.md+++ b/docs/plans/2026-07-08-layered-intelligence-scheduled-task-migration.md@@ -24,7 +24,7 @@ like the other scheduled tasks.** Drop the cross-app sweep entirely.## Key finding — the scheduled-task system can't run a deterministic handlerThe `taskSchedule.js` / `SELF_IMPROVEMENT_TASK_TYPES` system is **hardwired to-spawn one coding agent per fire.** `generateManagedAppImprovementTaskForType`+spawn one coding agent per fire.** `prepareManagedAppImprovementTask`(`cosTaskGenerator.js:1540`) always terminates by emitting an agent prompt(`taskType:'internal'`); deterministic per-type work (e.g. `branch-reconcile`,`reference-watch`) exists only as *pre-steps that prepare the agent prompt*, neverdiff --git a/docs/plans/2026-07-09-programmatic-io-scheduled-tasks.md b/docs/plans/2026-07-09-programmatic-io-scheduled-tasks.mdindex de67907950..a10d165ce0 100644--- a/docs/plans/2026-07-09-programmatic-io-scheduled-tasks.md+++ b/docs/plans/2026-07-09-programmatic-io-scheduled-tasks.md@@ -39,7 +39,7 @@ A task-type registry gains two optional async hooks (co-located with the task tyother config; resolved by id at dispatch/completion time):- **`buildTaskInput(app, config)` → `{ promptAugmentation?, context?, skip?: { reason } }`**- Runs before spawn, inside `generateManagedAppImprovementTaskForType`+ Runs before spawn, inside `prepareManagedAppImprovementTask`(`cosTaskGenerator.js:1665`) after metadata assembly and alongside the existingperpetual work-detector gate (`:1744`, which is already the precedent for aprogrammatic "should we even spawn?" check). For LI: the park-check + `gatherSources`@@ -115,7 +115,7 @@ provider → non-interactive but still a visible agent card. This is exactly theinstalls).2. **Hook interface + registry.** Add optional `buildTaskInput`/`processTaskOutput`resolution keyed by task type. Wire `buildTaskInput` into- `generateManagedAppImprovementTaskForType`; wire `processTaskOutput` into+ `prepareManagedAppImprovementTask`; wire `processTaskOutput` into`finalizeAgent`/`processAgentCompletion`.3. **Sentinel payload.** Extend `ingestDoneSentinel` to parse an optional JSON`payload`; thread it into `agentResult`. Back-compat preserved.diff --git a/server/services/cosTaskGenerator.auditMode.test.js b/server/services/cosTaskGenerator.auditMode.test.jsindex 2136ad1ec5..e5b352e43c 100644--- a/server/services/cosTaskGenerator.auditMode.test.js+++ b/server/services/cosTaskGenerator.auditMode.test.js@@ -81,7 +81,7 @@ vi.mock('../lib/gitRemote.js', async (importActual) => ({readOriginRemoteUrl: vi.fn(async () => null),}));-import { generateManagedAppImprovementTaskForType } from './cosTaskGenerator.js';+import { prepareManagedAppImprovementTask } from './cosTaskGenerator.js';import { generateTaskFromJob } from './autonomousJobs/skillTemplates.js';import { buildLightContextPrompt } from './agentPromptBuilder.js';import { declaresNoCommitCriterion } from './taskTypeHooks.js';@@ -110,8 +110,10 @@ const makeApp = (overrides = {}) => ({const STATE = { config: { confidenceAutoApproval: { enabled: false }, idleReviewPriority: 'MEDIUM' } };/** The ordinary scheduled lane. */-const generate = (taskType, options = {}) =>- generateManagedAppImprovementTaskForType(taskType, makeApp(), STATE, options);+const generate = async (taskType, options = {}) => {+ const prepared = await prepareManagedAppImprovementTask(taskType, makeApp(), STATE, options);+ return prepared.task;+};/*** The FINAL text an agent sees: the rendered mission plus the operating@@ -164,7 +166,7 @@ describe('issues-only audit dispatch never acquires code-shipping instructions (const { getTaskInterval } = await import('./taskSchedule.js');getTaskInterval.mockResolvedValue({ type: 'weekly', taskMetadata: { fileIssues: false, openPR: true, useWorktree: true } });promptTemplate.body = 'Reviewers: {reviewers}';- const task = await generateManagedAppImprovementTaskForType('security', makeApp({ defaultPrCompletion: appPolicy }), STATE, { skipPreconditions: true });+ const { task } = await prepareManagedAppImprovementTask('security', makeApp({ defaultPrCompletion: appPolicy }), STATE, { skipPreconditions: true });expect(task.metadata.prCompletion).toBe(expectedPolicy);expect(task.description).toContain(`Reviewers: ${reviewers}`);});diff --git a/server/services/cosTaskGenerator.js b/server/services/cosTaskGenerator.jsindex b130eb6f84..50bb4455ae 100644--- a/server/services/cosTaskGenerator.js+++ b/server/services/cosTaskGenerator.js@@ -1251,9 +1251,13 @@ export async function queueDueInstallWideImprovementTasks({}/**- * Queue eligible self-improvement and app improvement tasks as system tasks- * Called during every evaluation to ensure system tasks are queued even when user tasks exist- * Tasks are queued to COS-TASKS.md and will be picked up in Priority 2+ * Queue eligible self-improvement and app improvement tasks as system tasks.+ * Called by evaluation (`maybeQueueImprovementTasks`) only when no user tasks+ * are pending and COS auto-run is `execute`, by `runImprovementCheckOnce`, by+ * the post-startup queue in `cos.js`, and by `refillPerpetualForCompletedAgent`.+ * The latter three gate on `canQueueImprovementTasks` before allowing this+ * COS-TASKS.md write.+ * Tasks are picked up in Priority 2.*/export async function queueEligibleImprovementTasks(state, cosTaskData, {ignoreTaskId = null, wakeAfterRecord = true, perpetualContinuation = null,@@ -1869,15 +1873,6 @@ async function generateManagedAppImprovementTask(app, state, { ignoreTaskId = nureturn { task, pendingPerpetualDispatch, preflightCardId: stolenCardId };}-/**- * Generate a managed app improvement task for a specific type- * Used by on-demand task processing and can be called directly- *- * @param {string} taskType - The type of improvement task (e.g., 'security-audit', 'code-quality')- * @param {Object} app - The managed app object- * @param {Object} state - Current CoS state- * @returns {Object} Generated task- */// How many CONSECUTIVE transient skips (across evaluations) applyPerpetualWorkGate// tolerates at `debug` before escalating to `warn` — see noteTransientProbe's// return value.@@ -2506,10 +2501,9 @@ const skipped = (gate, { reason = null, cli = null, remedy = null, detail = null* that is returned as `pendingPerpetualDispatch` (`null`, or* `{ taskType, appId, signature }`) alongside the task, so the caller can* record it (via `recordDeferredPerpetualDispatch`) at whatever point the- * task's admission is certain. `generateManagedAppImprovementTaskForType`- * below is the thin direct-caller wrapper that records immediately; the- * queue, on-demand, and idle-review paths call this function directly and- * defer the record until their own spawn-engine admission succeeds (#6871).+ * task's admission is certain. The queue, on-demand, and idle-review paths call+ * this function directly and defer the record until their own spawn-engine+ * admission succeeds (#6871).** Always resolves to ONE shape, `{ task, pendingPerpetualDispatch, skip }`:* `skip` is `null` when a task was built, otherwise@@ -2836,30 +2830,3 @@ export async function prepareManagedAppImprovementTask(taskType, app, state, {return { task, pendingPerpetualDispatch, skip: null };}--/**- * Generate a managed app improvement task for a specific type.- * Used by on-demand task processing and can be called directly.- *- * Thin wrapper over `prepareManagedAppImprovementTask` (above) that records- * any deferred perpetual-dispatch signature immediately — the shape every- * direct caller got before the queue, on-demand, and idle-review paths needed- * to defer that record until their own admission gate passes. Those three- * callers use `prepareManagedAppImprovementTask` directly instead (see- * `queueEligibleImprovementTasks`, `onDemandDrain.js`, `generateIdleReviewTask`).- *- * @param {string} taskType - The type of improvement task (e.g., 'security-audit', 'code-quality')- * @param {Object} app - The managed app object- * @param {Object} state - Current CoS state- * @returns {Promise<Object|null>} Generated task, or null when nothing is eligible.- */-export async function generateManagedAppImprovementTaskForType(taskType, app, state, opts = {}) {- const taskSchedule = await import('./taskSchedule.js');- const prepared = await prepareManagedAppImprovementTask(taskType, app, state, opts);- // Guard on `prepared.task`, matching every other caller of prepare — task- // and pendingPerpetualDispatch are always constructed together, but this- // keeps the guard from silently drifting if that ever changes.- if (!prepared.task) return null;- await recordDeferredPerpetualDispatch(prepared.pendingPerpetualDispatch, taskSchedule);- return prepared.task;-}diff --git a/server/services/cosTaskGenerator.providerPin.test.js b/server/services/cosTaskGenerator.providerPin.test.jsindex c06dbc6999..b3c85c0504 100644--- a/server/services/cosTaskGenerator.providerPin.test.js+++ b/server/services/cosTaskGenerator.providerPin.test.js@@ -67,7 +67,7 @@ vi.mock('./perpetualWork.js', async importOriginal => ({import { detectActionableWork } from './perpetualWork.js';import { recordPerpetualStall } from './taskSchedule.js';-import { generateManagedAppImprovementTaskForType, prepareManagedAppImprovementTask } from './cosTaskGenerator.js';+import { prepareManagedAppImprovementTask } from './cosTaskGenerator.js';import { resolveClaimWorkMetadata } from './cosTaskClaimWork.js';const APP = { id: 'app-1', name: 'Example App', repoPath: '/tmp/example-repo' };@@ -75,8 +75,10 @@ const STATE = { config: { confidenceAutoApproval: { enabled: false }, idleReview// `ux` has no buildTaskInput hook — exactly the class of task type the pin used to// be inert for.-const generate = (taskType = 'ux') =>- generateManagedAppImprovementTaskForType(taskType, APP, STATE, { skipPreconditions: true });+const generate = async (taskType = 'ux') => {+ const prepared = await prepareManagedAppImprovementTask(taskType, APP, STATE, { skipPreconditions: true });+ return prepared.task;+};describe('per-app provider/model pin on a task type with no buildTaskInput hook', () => {beforeEach(() => {@@ -155,7 +157,7 @@ describe('pipeline stage provider precedence', () => {getAppTaskTypeOverridesMock.mockResolvedValue({ ux: { providerId: 'opencode-tui', model: 'app-model' } });const task = await generate();expect(task.metadata).toMatchObject({ provider: 'claude-cli', providerId: 'claude-cli', model: 'local-model', effort: 'low' });- const overridden = await generateManagedAppImprovementTaskForType('ux', APP, STATE, {+ const { task: overridden } = await prepareManagedAppImprovementTask('ux', APP, STATE, {skipPreconditions: true, providerOverride: { provider: 'opencode-tui', model: 'explicit-model', effort: 'high' },});expect(overridden.metadata).toMatchObject({ provider: 'opencode-tui', model: 'explicit-model', effort: 'high' });diff --git a/server/services/cosTaskGenerator.referenceWatch.test.js b/server/services/cosTaskGenerator.referenceWatch.test.jsindex 4376106ae7..4b38e71d01 100644--- a/server/services/cosTaskGenerator.referenceWatch.test.js+++ b/server/services/cosTaskGenerator.referenceWatch.test.js@@ -3,7 +3,7 @@** `reference-watch` reaches an agent by two paths: the on-commit trigger* (`triggerReferenceAnalysis` in referenceRepos.js) and the WEEKLY scheduled- * task (`generateManagedAppImprovementTaskForType` here). Only the former used+ * task (`prepareManagedAppImprovementTask` here). Only the former used* to expand the v3 prompt's `{trackerInstructions}` block, so every scheduled* run shipped the literal string `{trackerInstructions}` under "## Where to* record proposals" — leaving the agent to guess where to file, and on a@@ -91,7 +91,7 @@ vi.mock('../lib/gitRemote.js', async (importActual) => ({readOriginRemoteUrl: vi.fn(async () => null),}));-import { generateManagedAppImprovementTaskForType } from './cosTaskGenerator.js';+import { prepareManagedAppImprovementTask } from './cosTaskGenerator.js';const SNAPSHOT = {head: 'a'.repeat(40),@@ -112,8 +112,10 @@ const makeApp = (overrides = {}) => ({const STATE = { config: { confidenceAutoApproval: { enabled: false }, idleReviewPriority: 'MEDIUM' } };-const generate = (app, taskType = 'reference-watch') =>- generateManagedAppImprovementTaskForType(taskType, app, STATE, { skipPreconditions: true });+const generate = async (app, taskType = 'reference-watch') => {+ const prepared = await prepareManagedAppImprovementTask(taskType, app, STATE, { skipPreconditions: true });+ return prepared.task;+};describe('scheduled reference-watch prompt assembly (#3140)', () => {beforeEach(() => {diff --git a/server/services/cosTaskGenerator.test.js b/server/services/cosTaskGenerator.test.jsindex 5e3c8e115c..5dc74c0429 100644--- a/server/services/cosTaskGenerator.test.js+++ b/server/services/cosTaskGenerator.test.js@@ -81,7 +81,7 @@ import {PERPETUAL_TRANSIENT_ESCALATION_THRESHOLD,buildImprovementDedupSets,queueDueInstallWideImprovementTasks,- generateManagedAppImprovementTaskForType,+ prepareManagedAppImprovementTask,recordDeferredPerpetualDispatch,normalizeWorkItemRef,buildTargetWorkItemBlock,@@ -123,12 +123,12 @@ const task = (id, metadata = {}) => ({ id, metadata });const noCooldown = () => Promise.resolve(false);it('declines an old app-scoped research request before generating a task', async () => {- const result = await generateManagedAppImprovementTaskForType(+ const { task } = await prepareManagedAppImprovementTask('model-comparison-refresh',{ id: 'example-app', name: 'Example App', repoPath: '/tmp/example-app' },{ config: {} });- expect(result).toBeNull();+ expect(task).toBeNull();});// The prompt pre-step layer moved to cosTaskPreStepBlocks.js, but these five@@ -1751,9 +1751,8 @@ describe('the drain cap has exactly one implementation, at the choke point', ()// prepareManagedAppImprovementTask computes the deferred-dispatch RECORD —// it never spends the budget itself. recordDeferredPerpetualDispatch is the- // one choke point that does, shared by the immediate-record wrapper- // (generateManagedAppImprovementTaskForType) and the deferred queue/- // on-demand/idle callers alike (#6871).+ // one choke point that does, shared by the production queue, on-demand,+ // and idle callers alike (#6871).const genStart = GEN_SRC.indexOf('export async function prepareManagedAppImprovementTask');const body = GEN_SRC.slice(genStart, GEN_SRC.indexOf('return { task, pendingPerpetualDispatch, skip: null };', genStart));expect(body, 'prepare must not charge the budget itself').not.toContain('recordPerpetualDispatch(');diff --git a/server/services/cosTaskPreStepBlocks.compose.test.js b/server/services/cosTaskPreStepBlocks.compose.test.jsindex 08dbea9e99..bf79b4611b 100644--- a/server/services/cosTaskPreStepBlocks.compose.test.js+++ b/server/services/cosTaskPreStepBlocks.compose.test.js@@ -1,5 +1,5 @@/**- * Cross-module wiring guard: `generateManagedAppImprovementTaskForType`+ * Cross-module wiring guard: `prepareManagedAppImprovementTask`* (cosTaskGenerator.js) still COMPOSES the pre-step resolvers that now live in* cosTaskPreStepBlocks.js.*@@ -105,7 +105,7 @@ vi.mock('./cosState.js', () => ({readAgentsStateForSafetyCheck: vi.fn(async () => ({ trusted: true, agents: {} })),}));-import { generateManagedAppImprovementTaskForType } from './cosTaskGenerator.js';+import { prepareManagedAppImprovementTask, recordDeferredPerpetualDispatch } from './cosTaskGenerator.js';import { getTaskInterval, getBranchReconcileOutcome, recordBranchReconcileOutcome } from './taskSchedule.js';import { applyPerpetualDrainCap } from './cosTaskPreStepBlocks.js';import { readAgentsStateForSafetyCheck } from './cosState.js';@@ -123,10 +123,15 @@ const scan = (over = {}) => ({...over,});-const generate = () =>- generateManagedAppImprovementTaskForType('branch-reconcile', APP, STATE, { skipPreconditions: true });+const generate = async (options = {}) => {+ const prepared = await prepareManagedAppImprovementTask('branch-reconcile', APP, STATE, { skipPreconditions: true, ...options });+ // This suite's direct prepare call simulates a caller that has admitted the+ // task; production records only after its own admission gate succeeds.+ await recordDeferredPerpetualDispatch(prepared.pendingPerpetualDispatch, await import('./taskSchedule.js'));+ return prepared.task;+};-describe('generateManagedAppImprovementTaskForType composes the extracted pre-step layer', () => {+describe('prepareManagedAppImprovementTask composes the extracted pre-step layer', () => {beforeEach(() => {vi.clearAllMocks();getBranchReconcileOutcome.mockResolvedValue(null);@@ -147,7 +152,7 @@ describe('generateManagedAppImprovementTaskForType composes the extracted pre-st})) }));mergedPrRead.mockImplementation(async (_app, name) => `https://github.com/example/repo/pull/${name.split('-').at(-1)}`);prepareRetirement.mockResolvedValue({ ok: true, review: { digest: 'd'.repeat(64), policy: { policies: [{ id: 'completed-owner' }] } } });- const task = await generateManagedAppImprovementTaskForType('branch-reconcile', APP, STATE, { skipPreconditions: true, onDemand: true });+ const task = await generate({ onDemand: true });expect(task).not.toBeNull();expect(task.metadata.reconcileRetirements).toHaveLength(3);expect(task.description).toContain('[REVIEW_RETIREMENT]');