Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix(models): show a failed fallback list read as an error with Retry

[._.]/ Adam Eivyd5a405ae484b
diff --git a/client/src/components/models/ProviderFallbacks.jsx b/client/src/components/models/ProviderFallbacks.jsx
index 2f004ebdc9..89bfc42eb1 100644
--- a/client/src/components/models/ProviderFallbacks.jsx
+++ b/client/src/components/models/ProviderFallbacks.jsx
@@ -2,6 +2,7 @@ import { useCallback, useEffect, useMemo, useState } from 'react';
import { ArrowDown, ArrowUp, ListOrdered, Plus, Save, Trash2 } from 'lucide-react';
import toast from '../ui/Toast';
import * as api from '../../services/api';
+import ListLoadError from '../ui/ListLoadError';
import PageSkeleton from '../ui/PageSkeleton';
import ProviderModelSelector from '../ProviderModelSelector';
@@ -19,15 +20,23 @@ export default function ProviderFallbacks() {
const [entries, setEntries] = useState(null);
const [dirty, setDirty] = useState(false);
const [saving, setSaving] = useState(false);
+ const [loadError, setLoadError] = useState(null);
+ const [loadAttempt, setLoadAttempt] = useState(0);
+ // A failed read stays an error with Retry: rendering it as an empty list
+ // would read as "no fallback list" over a configured chain.
useEffect(() => {
- Promise.all([api.getProviders(), api.getProviderFallbacks()])
+ let active = true;
+ setLoadError(null);
+ Promise.all([api.getProviders({ silent: true }), api.getProviderFallbacks({ silent: true })])
.then(([provs, chain]) => {
+ if (!active) return;
setProviders((provs.providers || []).filter((p) => p.enabled !== false));
setEntries(chain.entries || []);
})
- .catch(() => setEntries([]));
- }, []);
+ .catch((err) => { if (active) setLoadError(err); });
+ return () => { active = false; };
+ }, [loadAttempt]);
const byId = useMemo(() => Object.fromEntries(providers.map((p) => [p.id, p])), [providers]);
@@ -54,6 +63,13 @@ export default function ProviderFallbacks() {
toast.success('Fallback list saved');
};
+ if (loadError) {
+ return (
+ <div className="mx-auto w-full max-w-4xl">
+ <ListLoadError what="the fallback list" error={loadError} onRetry={() => setLoadAttempt((n) => n + 1)} />
+ </div>
+ );
+ }
if (!entries) return <PageSkeleton header="none" label="Loading fallbacks" cards={2} sidebar={false} />;
return (
diff --git a/client/src/components/models/ProviderFallbacks.test.jsx b/client/src/components/models/ProviderFallbacks.test.jsx
new file mode 100644
index 0000000000..f68b014d1f
--- /dev/null
+++ b/client/src/components/models/ProviderFallbacks.test.jsx
@@ -0,0 +1,33 @@
+import { describe, it, expect, vi, afterEach } from 'vitest';
+import { render, screen, fireEvent, cleanup } from '@testing-library/react';
+
+vi.mock('../../services/api', () => ({
+ getProviders: vi.fn(),
+ getProviderFallbacks: vi.fn(),
+ saveProviderFallbacks: vi.fn(),
+}));
+
+import * as api from '../../services/api';
+import ProviderFallbacks from './ProviderFallbacks';
+
+afterEach(() => {
+ cleanup();
+ vi.clearAllMocks();
+});
+
+describe('ProviderFallbacks', () => {
+ it('shows a failed read as a retryable error, never as "No fallback list yet"', async () => {
+ api.getProviders.mockResolvedValue({ providers: [] });
+ api.getProviderFallbacks.mockRejectedValueOnce(new Error('boom'));
+ api.getProviderFallbacks.mockResolvedValue({ entries: [] });
+ render(<ProviderFallbacks />);
+
+ expect(await screen.findByText(/Could not load the fallback list/)).toBeInTheDocument();
+ expect(screen.queryByText('No fallback list yet.')).not.toBeInTheDocument();
+ expect(api.getProviderFallbacks).toHaveBeenCalledWith({ silent: true });
+
+ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));
+ expect(await screen.findByText('No fallback list yet.')).toBeInTheDocument();
+ expect(screen.queryByText(/Could not load the fallback list/)).not.toBeInTheDocument();
+ });
+});
diff --git a/client/src/listFetchConventions.test.js b/client/src/listFetchConventions.test.js
index c732edad0d..61ee1bcd2f 100644
--- a/client/src/listFetchConventions.test.js
+++ b/client/src/listFetchConventions.test.js
@@ -94,7 +94,6 @@ const KNOWN = Object.freeze({
'src/components/media/UniverseMoodBoardPicker.jsx': 3,
'src/components/messages/DraftsTab.jsx': 1,
'src/components/messages/IMessageTab.jsx': 1,
- 'src/components/models/ProviderFallbacks.jsx': 1,
'src/components/music/AlbumsManager.jsx': 2,
'src/components/music/ChiptunePanel.jsx': 1,
'src/components/music/TracksManager.jsx': 2,