Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: preserve CRLF review evidence compatibility (#12555)

[._.]/ Adam Eivyd818d907fff6
diff --git a/server/services/cosMergeHandoff.js b/server/services/cosMergeHandoff.js
index 6706bddcca..a2493848ff 100644
--- a/server/services/cosMergeHandoff.js
+++ b/server/services/cosMergeHandoff.js
@@ -64,8 +64,8 @@ async function readReviewEvidence(workspace) {
const content = await readFile(resolve(workspace, relative), 'utf-8').catch((err) => (err.code === 'ENOENT' ? null : undefined));
if (content === null) return { status: null, head: null };
const values = (pattern) => [...String(content ?? '').matchAll(pattern)].map((m) => m[1].trim());
- const statuses = values(/^REVIEW_STATUS=([^\r\n]*)$/gm);
- const heads = values(/^REVIEW_HEAD=([^\r\n]*)$/gm);
+ const statuses = values(/^REVIEW_STATUS=(.*)$/gm);
+ const heads = values(/^REVIEW_HEAD=(.*)$/gm);
return {
status: statuses.length === 1 ? statuses[0] : 'unreadable',
head: heads.length === 1 ? heads[0].toLowerCase() : null,
diff --git a/server/services/cosMergeHandoff.test.js b/server/services/cosMergeHandoff.test.js
index 89ebc98a78..e0fa47542a 100644
--- a/server/services/cosMergeHandoff.test.js
+++ b/server/services/cosMergeHandoff.test.js
@@ -334,9 +334,9 @@ describe('pending-merge handoff', () => {
expect(await handoff()).toMatchObject({ queued: false, reason: 'review-evidence-incomplete' });
});
- it('queues current-head optional quota/no-verdict evidence without inventing a clean verdict', async () => {
+ it.each(['\n', '\r\n'])('queues current-head optional quota/no-verdict evidence without inventing a clean verdict (line ending %j)', async (newline) => {
f.optionalReviewers = ['codex'];
- await writeFile(join(workspace, 'portos-review-status'), `REVIEW_STATUS=optional-inconclusive\nREVIEW_HEAD=${HEAD}\n`);
+ await writeFile(join(workspace, 'portos-review-status'), `REVIEW_STATUS=optional-inconclusive${newline}REVIEW_HEAD=${HEAD}${newline}`);
expect(await handedOff()).toMatchObject({ queued: true });
expect(pending()[0].handoff).toMatchObject({ reviewStatus: 'optional-inconclusive', headSha: HEAD });
greenChecks();