Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: reject repeated inbox pagination fields as validation errors (#13150)

Adam Eivyde4a00341d88
diff --git a/server/lib/validation.js b/server/lib/validation.js
index 0248a67eec..7512b04abc 100644
--- a/server/lib/validation.js
+++ b/server/lib/validation.js
@@ -2062,8 +2062,8 @@ export function parsePagination(query, { defaultLimit = 50, maxLimit = 200 } = {
return { limit, offset };
}
-// Express turns a repeated `?k=a&k=b` into an array; each field must be scalar
-// before any cache read (#13150). Pagination stays lenient via parsePagination.
+// Express turns a repeated `?k=a&k=b` into an array; every field must be scalar
+// before any cache read (#13150). Value leniency (bad/absent limit) stays in parsePagination.
export const messageInboxQuerySchema = z.object({
accountId: z.string().optional(),
search: z.string().optional(),
diff --git a/server/routes/messageInboxRead.test.js b/server/routes/messageInboxRead.test.js
index 701a643a73..3f583d70af 100644
--- a/server/routes/messageInboxRead.test.js
+++ b/server/routes/messageInboxRead.test.js
@@ -135,7 +135,9 @@ describe('inbox summary reads through the production HTTP/service boundary', ()
const repeated = [
'search=first&search=second',
`accountId=${ACCOUNT_IDS[0]}&accountId=${ACCOUNT_IDS[1]}`,
- 'summary=true&summary=false'
+ 'summary=true&summary=false',
+ 'limit=1&limit=2',
+ 'offset=1&offset=2'
];
for (const query of repeated) {
const response = await request(app).get('/inbox?' + query);