Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: discard appended vendor advice from reviewer refusals (#10666)

Adam Eivydf7ffef5ca46
diff --git a/server/lib/reviewerHealth.js b/server/lib/reviewerHealth.js
index 55fe4ba530..814b8c071d 100644
--- a/server/lib/reviewerHealth.js
+++ b/server/lib/reviewerHealth.js
@@ -27,7 +27,7 @@ export function reviewerAccessFailureCode(reviewer, failure) {
/** Match the vendor's explicit headless refusal, never generic permission prose. */
export function reviewerCommandPermissionFailureCode(message) {
if (typeof message !== 'string') return null;
- return /^(?:jetski:\s*)?no output produced [—–-] a tool required the ["']command["'] permission that headless mode cannot prompt for, so it was auto-denied\.?$/im.test(message)
+ return /^(?:jetski:\s*)?no output produced [—–-] a tool required the ["']command["'] permission that headless mode cannot prompt for, so it was auto-denied(?:\.|$)/im.test(message)
? 'REVIEWER_COMMAND_PERMISSION_DENIED' : null;
}
diff --git a/server/scripts/run-local-code-review.test.js b/server/scripts/run-local-code-review.test.js
index 25172059c0..56d46f359c 100644
--- a/server/scripts/run-local-code-review.test.js
+++ b/server/scripts/run-local-code-review.test.js
@@ -34,7 +34,7 @@ it('runs a saved provider reviewer from the standalone claim bridge without boot
// No reviewer mode means ordinary argv, so it must run outside the caller's checkout.
if (existsSync('context.txt') || args.includes('baked-model') || args[args.indexOf('--model') + 1] !== 'review-model') process.exit(1);
if (args.includes('--refuse')) {
- process.stderr.write('jetski: no output produced — a tool required the "command" permission that headless mode cannot prompt for, so it was auto-denied.\\nsynthetic-private-path-or-credential');
+ process.stderr.write('jetski: no output produced — a tool required the "command" permission that headless mode cannot prompt for, so it was auto-denied. synthetic-private-path-or-credential');
process.exit(1);
}
process.stdout.write('NO FINDINGS');
diff --git a/server/services/codeReview.providers.test.js b/server/services/codeReview.providers.test.js
index e97673fecb..84abc10a0e 100644
--- a/server/services/codeReview.providers.test.js
+++ b/server/services/codeReview.providers.test.js
@@ -153,7 +153,7 @@ describe('configured provider reviewers', () => {
it('returns a bounded configuration fault for an explicit headless command refusal without a verdict', async () => {
getProviderById.mockResolvedValue({ ...provider, type: 'cli', command: 'agy' });
const diagnostic = 'jetski: no output produced — a tool required the "command" permission that headless mode cannot prompt for, so it was auto-denied.';
- for (const failure of [{ error: diagnostic }, { stderr: diagnostic, text: '', partial: false }, { stderr: diagnostic, text: 'incomplete', partial: true }]) {
+ for (const failure of [{ error: `${diagnostic} Synthetic vendor advice follows.` }, { stderr: diagnostic, text: '', partial: false }, { stderr: diagnostic, text: 'incomplete', partial: true }]) {
runCliProviderPrompt.mockResolvedValue({ ...failure, stderr: `${diagnostic}\nsynthetic-private-path-or-credential` });
const result = await runLocalCodeReview({ backend, diff: 'example diff' });
expect(result).toEqual({ ok: false, code: 'REVIEWER_COMMAND_PERMISSION_DENIED', error: expect.stringContaining('supported tool-free vendor configuration') });