Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: preserve renewed failure episodes during task reaping

[._.]/ Adam Eivye5820424dd2e
diff --git a/server/services/cosTaskStore.js b/server/services/cosTaskStore.js
index 346de67bb7..b4e6e69d02 100644
--- a/server/services/cosTaskStore.js
+++ b/server/services/cosTaskStore.js
@@ -1238,7 +1238,18 @@ export async function sweepResolvedFailureTasks({
const updated = await updateTask(task.id, {
status: 'completed',
metadata: { resolution: 'auto-expired', autoExpiredReason: reason, autoExpiredAt: new Date(now).toISOString() }
- }, type, { now, expectedStatus: task.status });
+ }, type, {
+ now,
+ expectedStatus: task.status,
+ // A revived task can fail again before this write and return to blocked.
+ // Preserve the category and every age fallback that justified this sweep.
+ expectedMetadata: reason === 'stale-failure-block' ? {
+ blockedCategory: task.metadata?.blockedCategory,
+ blockedAt: task.metadata?.blockedAt,
+ lastFailureAt: task.metadata?.lastFailureAt,
+ updatedAt: task.metadata?.updatedAt,
+ } : null,
+ });
if (updated?.error || updated?.statusChanged) continue;
if (reason === 'stale-failure-block') staleBlocks++; else investigations++;
}
diff --git a/server/services/cosTaskStore.test.js b/server/services/cosTaskStore.test.js
index 29078ac208..3a341800bf 100644
--- a/server/services/cosTaskStore.test.js
+++ b/server/services/cosTaskStore.test.js
@@ -151,7 +151,7 @@ import {
__resetTaskCache
} from './cosTaskStore.js';
import { aggregateAutoFixDiagnostics, getAutoFixMetrics } from './autoFixMetrics.js';
-import { PRIORITY_VALUES, generateTasksMarkdown } from '../lib/taskParser.js';
+import { PRIORITY_VALUES, generateTasksMarkdown, parseTasksMarkdown } from '../lib/taskParser.js';
import { getTaskPrompt, getTaskContextNote } from '../lib/cosTaskPrompt.js';
import { AGENT_PAUSED_CATEGORY, PAUSE_METADATA_KEYS, registerPauseReleaseAdapter, __resetPauseReleaseAdapter } from '../lib/taskPauseHold.js';
import { MAX_TOTAL_SPAWNS } from '../lib/cosValidation.js';
@@ -2468,6 +2468,33 @@ describe('cosTaskStore — stale failure-artifact reaper (#2619)', () => {
expect(statuses).toEqual(['completed', 'in_progress']);
});
+ it.each([
+ ['blockedAt', new Date(NOW).toISOString()],
+ ['blockedCategory', 'provider-config'],
+ ])('preserves a new blocked episode when %s changes after the reaper snapshot', async (key, value) => {
+ for (const id of ['task-episode1', 'task-episode2']) {
+ await addTask({ description: `failure episode ${id}`, id, priority: 'HIGH' }, 'user', { now: NOW });
+ await updateTask(id, {
+ status: 'blocked', metadata: { blockedCategory: 'max-retries', blockedAt: daysAgo(20) },
+ }, 'user', { now: NOW });
+ }
+ mock.afterWrite = (path) => {
+ if (path !== USER_FILE) return false;
+ // Model a fresh failure or user-decision hold after the snapshot, with
+ // the same status as before. The completed first row stays untouched.
+ const tasks = parseTasksMarkdown(mock.files.get(path));
+ tasks.find(task => task.status === 'blocked').metadata[key] = value;
+ mock.files.set(path, generateTasksMarkdown(tasks));
+ mock.mtimes.set(path, (mock.mtimes.get(path) || 0) + 1000);
+ return true;
+ };
+ expect(await sweepResolvedFailureTasks({ now: NOW })).toMatchObject({ reaped: 1, staleBlocks: 1 });
+ const tasks = (await getUserTasks()).tasks;
+ const held = tasks.find(task => task.status === 'blocked');
+ expect(held.metadata[key]).toBe(value);
+ expect(held.metadata.resolution).toBeUndefined();
+ });
+
it('bounds the number of flips per sweep to the limit', async () => {
for (let i = 0; i < 4; i++) {
await addTask({ description: `old ${i}`, id: `task-b${i}`, priority: 'LOW' }, 'user', { now: NOW });