Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: exclude generated coverage assets from server lint (#10808)

Adam Eivye891a78b2404
diff --git a/scripts/run-ci-lint.test.js b/scripts/run-ci-lint.test.js
index e711dea3fb..b7a3079a53 100644
--- a/scripts/run-ci-lint.test.js
+++ b/scripts/run-ci-lint.test.js
@@ -1,3 +1,8 @@
+import { spawnSync } from 'node:child_process';
+import { cpSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
import { describe, expect, it } from 'vitest';
import { BIOME_BIN, LINT_MODES, SERVER_LINT_ARGS, buildLintArgs, selectClientFiles, touchesServer } from './run-ci-lint.js';
@@ -62,4 +67,22 @@ describe('CI client lint runner', () => {
expect(touchesServer(['server/biome.jsonc'])).toBe(true);
expect(touchesServer(['server/node_modules/x/index.js', 'client/src/a.js', 'server/README.md'])).toBe(false);
});
+
+ // Vitest's HTML reporter writes JS assets under server/coverage/; lint must
+ // ignore them while still failing on an undeclared identifier in real source.
+ it('ignores generated coverage assets but still flags undeclared variables in source', () => {
+ const serverDir = join(dirname(fileURLToPath(import.meta.url)), '..', 'server');
+ const dir = mkdtempSync(join(tmpdir(), 'biome-cov-'));
+ try {
+ cpSync(join(serverDir, 'biome.jsonc'), join(dir, 'biome.jsonc'));
+ mkdirSync(join(dir, 'coverage'));
+ writeFileSync(join(dir, 'coverage', 'prettify.js'), 'PR.prettyPrint();\n');
+ const lint = () => spawnSync(process.execPath, [BIOME_BIN, 'lint', '.'], { cwd: dir, encoding: 'utf8' });
+ expect(lint().status).toBe(0);
+ writeFileSync(join(dir, 'app.js'), 'undeclaredThing();\n');
+ expect(lint().status).not.toBe(0);
+ } finally {
+ rmSync(dir, { recursive: true, force: true });
+ }
+ });
});
diff --git a/server/biome.jsonc b/server/biome.jsonc
index 4f14efe9e5..5b9c1503f0 100644
--- a/server/biome.jsonc
+++ b/server/biome.jsonc
@@ -1,7 +1,7 @@
{
"$schema": "../client/node_modules/@biomejs/biome/configuration_schema.json",
"root": true,
- "files": { "includes": ["**/*.js", "**/*.mjs", "!node_modules", "!native"] },
+ "files": { "includes": ["**/*.js", "**/*.mjs", "!node_modules", "!native", "!coverage"] },
"formatter": { "enabled": false },
"assist": { "enabled": false },
"linter": {