Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix(security): require operator authority for voice and palette brain capture and image generation

Adam Eivyf0ceed06c509
diff --git a/docs/COMPANION_APP_API.md b/docs/COMPANION_APP_API.md
index 8b3cfd6bce..5fa9fa8e17 100644
--- a/docs/COMPANION_APP_API.md
+++ b/docs/COMPANION_APP_API.md
@@ -238,7 +238,7 @@ list and each action's parameter schema):
| id | Purpose |
|----|---------|
-| `brain_capture` | Capture a note to the Brain. |
+| `brain_capture` | Capture a note to the Brain. Host control, like `POST /api/brain/capture`: it can clone a repo URL or run the classifier, so it needs an operator session (`403 HOST_CONTROL_FORBIDDEN` otherwise). Use `daily_log_append` for a quick note without one. |
| `brain_search` / `brain_list_recent` | Search / list recent Brain entries. |
| `daily_log_append` | Append a line to today's daily log. |
| `daily_log_read` | Read today's daily log. |
diff --git a/server/lib/hostControlRoutes.js b/server/lib/hostControlRoutes.js
index e0cc8d0564..0b46cab431 100644
--- a/server/lib/hostControlRoutes.js
+++ b/server/lib/hostControlRoutes.js
@@ -8,6 +8,9 @@
* remote LAN/tailnet caller on a password-free install is refused (#8226).
* The socket twin is HOST_CONTROL_SOCKET_EVENTS in services/socket.js;
* `/api/commands/*` mounts `requireHostControl` per route in routes/commands.js.
+ * Voice and palette tools (services/voice/tools.js) reach some of these
+ * operations without the route, so a tool whose route twin is listed here
+ * carries `hostControl: true`, checked at dispatch.
*
* A route belongs here when it runs a process, git, npm, gh or a CoS agent on
* the host, or when it sets what one will run (a repo path, a start command, a
diff --git a/server/routes/hostControlRunsVoice.test.js b/server/routes/hostControlRunsVoice.test.js
index 271b7007db..b5ae806915 100644
--- a/server/routes/hostControlRunsVoice.test.js
+++ b/server/routes/hostControlRunsVoice.test.js
@@ -35,6 +35,14 @@ vi.mock('../services/providers.js', () => ({
getActiveProvider: vi.fn(async () => ({ id: 'example-cli', type: 'cli', enabled: true })),
getProviderById: vi.fn(), getAllProviders: vi.fn(),
}));
+vi.mock('../services/brain.js', () => ({
+ captureThought: vi.fn(async () => ({ inboxLog: { id: 'example-inbox' } })),
+ getInboxLog: vi.fn(async () => []),
+}));
+vi.mock('../services/imageGen/index.js', async () => ({
+ ...await vi.importActual('../lib/generationModes.js'),
+ generateImage: vi.fn(async () => ({ mode: 'external', path: '/data/images/example.png', filename: 'example.png' })),
+}));
vi.mock('../services/voice/stt.js', () => ({
transcribe: vi.fn(async () => ({ text: 'restart the example service', latencyMs: 1 })),
}));
@@ -69,6 +77,8 @@ import { dispatchTool } from '../services/voice/tools.js';
import { streamChat } from '../services/voice/llm.js';
import { restartApp } from '../services/pm2.js';
import { addTask } from '../services/cos.js';
+import { captureThought } from '../services/brain.js';
+import { generateImage } from '../services/imageGen/index.js';
const runner = {
createRun: vi.fn(), executeCliRun: vi.fn(), executeTuiRun: vi.fn(), executeApiRun: vi.fn(),
@@ -86,10 +96,18 @@ const appFor = (address) => {
return app;
};
const runBody = { providerId: 'example-provider', prompt: 'Fix the example test', workspacePath: '/example/repo' };
+// [tool, args, the host effect it must not reach without authority]
const hostTools = [
- ['pm2_restart', { name: 'example-api' }],
- ['dispatch_code_agent', { task: 'Fix the example test' }],
+ ['pm2_restart', { name: 'example-api' }, restartApp],
+ ['dispatch_code_agent', { task: 'Fix the example test' }, addTask],
+ // HTTP twins are gated whole-operation: POST /api/brain/capture (#11036)
+ // and POST /api/image-gen/generate (#9667).
+ ['brain_capture', { text: 'https://github.com/example/example-repo' }, captureThought],
+ ['image_generate', { prompt: 'An example lighthouse at dusk' }, generateImage],
];
+const expectNoHostEffects = () => {
+ for (const [, , effect] of hostTools) expect(effect).not.toHaveBeenCalled();
+};
const responseFor = (name, args) => ({ text: '', model: 'test-model', toolCalls: [
{ id: 'call-1', type: 'function', function: { name, arguments: JSON.stringify(args) } },
] });
@@ -148,7 +166,7 @@ describe('Runs and palette host authority (#8834)', () => {
? { model: 'fallback-model' } : { provider: { defaultModel: 'fallback-model' } });
});
- it.each(hostTools)('protects palette %s from remote anonymous and Basic callers, allowing local/session', async (name, args) => {
+ it.each(hostTools)('protects palette %s from remote anonymous and Basic callers, allowing local/session', async (name, args, effect) => {
for (const enabled of [false, true]) {
auth.enabled = enabled;
const response = await request(appFor('192.0.2.10')).post(`/api/palette/action/${name}`)
@@ -157,14 +175,13 @@ describe('Runs and palette host authority (#8834)', () => {
expect(response.status).toBe(403);
expect(response.body.code).toBe('HOST_CONTROL_FORBIDDEN');
}
- expect(restartApp).not.toHaveBeenCalled();
- expect(addTask).not.toHaveBeenCalled();
+ expectNoHostEffects();
for (const address of ['127.0.0.1', '192.0.2.10']) {
auth.enabled = address !== '127.0.0.1';
auth.session = auth.enabled;
expect((await request(appFor(address)).post(`/api/palette/action/${name}`).send({ args })).status).toBe(200);
}
- expect(name === 'pm2_restart' ? restartApp : addTask).toHaveBeenCalledTimes(2);
+ expect(effect).toHaveBeenCalledTimes(2);
});
it('does not grant host tools authority from missing or JSON-shaped contexts, while read tools stay usable', async () => {
@@ -174,8 +191,7 @@ describe('Runs and palette host authority (#8834)', () => {
}
}
expect((await request(appFor('192.0.2.10')).post('/api/palette/action/pm2_status').send({})).status).toBe(200);
- expect(restartApp).not.toHaveBeenCalled();
- expect(addTask).not.toHaveBeenCalled();
+ expectNoHostEffects();
});
});
@@ -186,8 +202,7 @@ describe.each(['voice:text', 'voice:turn', 'voice:call:audio'])('%s tool authori
await fireTurn(socket, event);
expect(streamChat).toHaveBeenCalled();
expect(socket.emit).toHaveBeenCalledWith('voice:error', expect.objectContaining({ code: 'HOST_CONTROL_FORBIDDEN', message: expect.stringContaining('operator session') }));
- expect(restartApp).not.toHaveBeenCalled();
- expect(addTask).not.toHaveBeenCalled();
+ expectNoHostEffects();
});
it('allows local/operator tools but rechecks a revoked session after the model responds', async () => {
diff --git a/server/routes/palette.test.js b/server/routes/palette.test.js
index a331f31bfe..637fc2526e 100644
--- a/server/routes/palette.test.js
+++ b/server/routes/palette.test.js
@@ -166,14 +166,15 @@ describe('GET /api/palette/manifest', () => {
});
describe('POST /api/palette/action/:id', () => {
+ // Host-control actions (brain_capture, image_generate, …) need an operator;
+ // their authority matrix lives in hostControlRunsVoice.test.js.
it('dispatches a whitelisted action and returns its result', async () => {
const res = await request(makeApp())
- .post('/api/palette/action/brain_capture')
- .send({ args: { text: 'remember to drink water' } });
+ .post('/api/palette/action/meatspace_log_drink')
+ .send({ args: { name: 'beer' } });
expect(res.status).toBe(200);
expect(res.body.ok).toBe(true);
- expect(res.body.result.id).toBe('inbox-1');
- expect(res.body.result.summary).toMatch(/Captured/);
+ expect(res.body.result.summary).toMatch(/Logged 1 beer/);
});
it('rejects unknown action ids', async () => {
diff --git a/server/services/voice/tools.test.js b/server/services/voice/tools.test.js
index 3fe10e1d12..a522142635 100644
--- a/server/services/voice/tools.test.js
+++ b/server/services/voice/tools.test.js
@@ -490,14 +490,15 @@ describe('code intent classification', () => {
});
describe('brain_capture validation', () => {
+ const operator = { hasHostControl: () => true };
it('rejects missing text', async () => {
- await expect(dispatchTool('brain_capture', {})).rejects.toThrow(/text is required/);
+ await expect(dispatchTool('brain_capture', {}, operator)).rejects.toThrow(/text is required/);
});
it('rejects whitespace-only text', async () => {
- await expect(dispatchTool('brain_capture', { text: ' ' })).rejects.toThrow(/text must not be empty/);
+ await expect(dispatchTool('brain_capture', { text: ' ' }, operator)).rejects.toThrow(/text must not be empty/);
});
it('returns inboxLog id on success', async () => {
- const r = await dispatchTool('brain_capture', { text: 'remember milk' });
+ const r = await dispatchTool('brain_capture', { text: 'remember milk' }, operator);
expect(r.ok).toBe(true);
expect(r.id).toBe('inbox-1');
});
@@ -1116,15 +1117,16 @@ describe('data-voice-guard annotation gates ui_click / ui_check / ui_fill (#5907
// image_generate uses imageGen.generateImage under the hood; mocked
// above. The codexEnabledRef toggle drives the disabled-gate test.
describe("image_generate", () => {
+ const operator = { hasHostControl: () => true };
it("rejects empty prompt", async () => {
- const r = await dispatchTool("image_generate", { prompt: " " });
+ const r = await dispatchTool("image_generate", { prompt: " " }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/prompt is required/);
});
it("forwards prompt to dispatcher with no mode by default (auto)", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox" }, operator);
expect(r.ok).toBe(true);
expect(generateImageMock).toHaveBeenCalledTimes(1);
const args = generateImageMock.mock.calls[0][0];
@@ -1134,20 +1136,20 @@ describe("image_generate", () => {
it("treats provider=auto the same as no provider", async () => {
generateImageMock.mockClear();
- await dispatchTool("image_generate", { prompt: "a fox", provider: "auto" });
+ await dispatchTool("image_generate", { prompt: "a fox", provider: "auto" }, operator);
expect(generateImageMock.mock.calls[0][0].mode).toBeUndefined();
});
it("forwards provider=local as mode=local", async () => {
generateImageMock.mockClear();
- await dispatchTool("image_generate", { prompt: "a fox", provider: "local" });
+ await dispatchTool("image_generate", { prompt: "a fox", provider: "local" }, operator);
expect(generateImageMock.mock.calls[0][0].mode).toBe("local");
});
it("rejects provider=codex when codex is disabled in settings", async () => {
codexEnabledRef.value = false;
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "codex" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "codex" }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/Codex Imagegen is disabled/);
expect(generateImageMock).not.toHaveBeenCalled();
@@ -1156,21 +1158,21 @@ describe("image_generate", () => {
it("forwards provider=codex when codex is enabled", async () => {
codexEnabledRef.value = true;
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "codex" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "codex" }, operator);
expect(r.ok).toBe(true);
expect(generateImageMock.mock.calls[0][0].mode).toBe("codex");
codexEnabledRef.value = false;
});
it("includes the saved file path in summary", async () => {
- const r = await dispatchTool("image_generate", { prompt: "a fox" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox" }, operator);
expect(r.path).toBe("/data/images/mock.png");
expect(r.filename).toBe("mock.png");
});
it("coerces stringified width/height to numbers before forwarding", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox", width: "512", height: "768" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", width: "512", height: "768" }, operator);
expect(r.ok).toBe(true);
const args = generateImageMock.mock.calls[0][0];
expect(args.width).toBe(512);
@@ -1179,7 +1181,7 @@ describe("image_generate", () => {
it("rejects prompt longer than 2000 characters (matches route schema)", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "x".repeat(2001) });
+ const r = await dispatchTool("image_generate", { prompt: "x".repeat(2001) }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/prompt must be 2000 characters or fewer/);
expect(generateImageMock).not.toHaveBeenCalled();
@@ -1187,13 +1189,13 @@ describe("image_generate", () => {
it("accepts prompt at exactly 2000 characters", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "x".repeat(2000) });
+ const r = await dispatchTool("image_generate", { prompt: "x".repeat(2000) }, operator);
expect(r.ok).toBe(true);
});
it("rejects out-of-bounds width", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox", width: 50000 });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", width: 50000 }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/width must be an integer between 64 and 2048/);
expect(generateImageMock).not.toHaveBeenCalled();
@@ -1201,7 +1203,7 @@ describe("image_generate", () => {
it("rejects non-integer height (e.g. floats)", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox", height: "768.5" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", height: "768.5" }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/height must be an integer between 64 and 2048/);
});
@@ -1212,7 +1214,7 @@ describe("image_generate", () => {
// actually exists.
it("waits for imageGenEvents 'completed' on async modes (local) before resolving", async () => {
generateImageMock.mockClear();
- const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" }, operator);
expect(r.ok).toBe(true);
expect(r.mode).toBe("local");
expect(r.summary).toMatch(/^Generated image \(local\)/);
@@ -1230,7 +1232,7 @@ describe("image_generate", () => {
});
return { generationId, filename: 'mock.png', path: '/data/images/mock.png', mode: params.mode };
});
- const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "codex" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "codex" }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/mock provider failure/);
codexEnabledRef.value = false;
@@ -1247,7 +1249,7 @@ describe("image_generate", () => {
events.emit('completed', { generationId: params.jobId, filename: 'early.png', path: '/data/images/early.png' });
return { generationId: params.jobId, filename: 'early.png', path: '/data/images/early.png', mode: 'local' };
});
- const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" }, operator);
expect(r.ok).toBe(true);
expect(r.filename).toBe("early.png");
});
@@ -1259,7 +1261,7 @@ describe("image_generate", () => {
events.emit('failed', { generationId: params.jobId, error: 'provider exited early' });
return { generationId: params.jobId, filename: 'x.png', path: '/data/images/x.png', mode: 'local' };
});
- const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" });
+ const r = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" }, operator);
expect(r.ok).toBe(false);
expect(r.summary).toMatch(/provider exited early/);
});
@@ -1268,9 +1270,9 @@ describe("image_generate", () => {
const events = await getEvents();
const before = events.listenerCount('completed') + events.listenerCount('failed');
generateImageMock.mockImplementationOnce(async () => { throw new Error('busy'); });
- const rejected = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" });
+ const rejected = await dispatchTool("image_generate", { prompt: "a fox", provider: "local" }, operator);
expect(rejected.ok).toBe(false);
- const sync = await dispatchTool("image_generate", { prompt: "a fox", provider: "external" });
+ const sync = await dispatchTool("image_generate", { prompt: "a fox", provider: "external" }, operator);
expect(sync.ok).toBe(true);
expect(events.listenerCount('completed') + events.listenerCount('failed')).toBe(before);
});
diff --git a/server/services/voice/tools/brain.js b/server/services/voice/tools/brain.js
index c6dfb9e789..5f2ab2e474 100644
--- a/server/services/voice/tools/brain.js
+++ b/server/services/voice/tools/brain.js
@@ -13,6 +13,9 @@ export const BRAIN_INTENT_RE = /\b(search|find|look ?up|recall|what did I (?:say
export const BRAIN_TOOLS = [
{
name: 'brain_capture',
+ // Same authority as POST /api/brain/capture (#11036): a bare repo URL is
+ // cloned, and other text reaches a classifier runner that is not tool-free.
+ hostControl: true,
description:
'Capture a thought, note, idea, todo, reminder, or any free-form information to the user\'s brain inbox for later classification. Use whenever the user asks you to remember, add, save, note, or jot something down. The text should be in the user\'s own words with enough detail that it\'s useful later.',
parameters: {
diff --git a/server/services/voice/tools/media.js b/server/services/voice/tools/media.js
index e3756599f3..4cd962d717 100644
--- a/server/services/voice/tools/media.js
+++ b/server/services/voice/tools/media.js
@@ -16,6 +16,9 @@ export const MEDIA_INTENT_RE = /\b(?:generate|render|create|draw|sketch|paint|il
export const MEDIA_TOOLS = [
{
name: 'image_generate',
+ // Same authority as POST /api/image-gen/generate (#9667): Codex, Grok and
+ // Agy keep host tools, and "auto" can resolve to one of them.
+ hostControl: true,
description:
'Generate an image from a text prompt and save it to the user\'s gallery. Defaults to the user\'s saved Image Gen backend. Pass `provider` to override per-call: "local", "external", "codex", "grok", "agy", or the metered (paid per image) "fal". Cloud providers must be enabled in Settings. Returns the saved file path.',
parameters: {