Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: treat dismissing an already-deleted memory as success and clear its stale review rows

[._.]/ Adam Eivyf10a2f55a23d
diff --git a/server/routes/memory.js b/server/routes/memory.js
index 9746760ced..c4dc5f7523 100644
--- a/server/routes/memory.js
+++ b/server/routes/memory.js
@@ -238,6 +238,8 @@ router.post('/:id/approve', asyncHandler(async (req, res) => {
router.post('/:id/reject', asyncHandler(async (req, res) => {
const options = validateRequest(memoryRetireSchema, req.body ?? {});
const result = await memory.rejectMemory(req.params.id, options);
+ // Rejecting a memory that is already gone is the desired end state.
+ if (!result.success && result.error === 'Memory not found') return res.json({ success: true, alreadyResolved: true });
if (!result.success) {
throw new ServerError(result.error, { status: result.error === 'Memory not found' ? 404 : 400 });
}
diff --git a/server/services/reviewQueue.js b/server/services/reviewQueue.js
index e2d26e87cd..8ee558a46f 100644
--- a/server/services/reviewQueue.js
+++ b/server/services/reviewQueue.js
@@ -1107,9 +1107,18 @@ async function resolveMemoryAction(id, operation) {
const result = await memory[operation === 'approve' ? 'approveMemory' : 'rejectMemory'](id);
if (result?.success === false || result?.error) {
const notFound = /not found/i.test(String(result.error || ''));
+ if (notFound) {
+ // The memory is already gone (deleted elsewhere); the user's intent is
+ // satisfied, so retire the stale queue projection instead of erroring.
+ await reviewService.dismissByReferenceId(id).catch((err) => {
+ console.error(`⚠️ Review queue: stale memory projection cleanup failed: ${err.message}`);
+ });
+ await notifications.removeByMetadata('memoryId', id).catch(() => {});
+ return { success: true, alreadyResolved: true };
+ }
throw new ServerError(result.error || `Memory ${operation} failed`, {
- status: notFound ? 404 : 409,
- code: notFound ? 'NOT_FOUND' : 'CONFLICT',
+ status: 409,
+ code: 'CONFLICT',
});
}
return result;
diff --git a/server/services/reviewQueue.test.js b/server/services/reviewQueue.test.js
index e626cf695d..8c48a5ca58 100644
--- a/server/services/reviewQueue.test.js
+++ b/server/services/reviewQueue.test.js
@@ -15,7 +15,9 @@ const productMetrics = { getProductEngagement: vi.fn() };
const backup = { getState: vi.fn(), saveState: vi.fn() };
const settingsMock = { getSettings: vi.fn() };
const reviewService = { reviewEvents: { emit: vi.fn() }, getItems: vi.fn(), dismissByReferenceId: vi.fn(), dismissItem: vi.fn(), completeItem: vi.fn(), reopenItem: vi.fn() };
-const notifications = { getNotifications: vi.fn(), removeNotification: vi.fn() };
+const notifications = { getNotifications: vi.fn(), removeNotification: vi.fn(), removeByMetadata: vi.fn() };
+const memoryService = { approveMemory: vi.fn(), rejectMemory: vi.fn() };
+vi.mock('./memory.js', () => memoryService);
// Mocked so the meta-field / buildQueue cases don't pull the brain/cos/identity
// stack in transitively (askPromote imports all three). The promoteAskQueueItem
// suite drives this mock directly.
@@ -1339,6 +1341,16 @@ describe('reviewQueue.resolveQueueItem', () => {
}));
});
+ it('treats rejecting an already-deleted memory as resolved and clears its stale projections', async () => {
+ memoryService.rejectMemory.mockResolvedValue({ success: false, error: 'Memory not found' });
+ reviewService.dismissByReferenceId.mockResolvedValue(undefined);
+ notifications.removeByMetadata.mockResolvedValue(undefined);
+ const result = await resolveQueueItem('memory:gone-1', 'reject');
+ expect(result).toMatchObject({ source: 'memory', operation: 'reject', resolved: true });
+ expect(reviewService.dismissByReferenceId).toHaveBeenCalledWith('gone-1');
+ expect(notifications.removeByMetadata).toHaveBeenCalledWith('memoryId', 'gone-1');
+ });
+
it('dispatches draft rows to approveDraft', async () => {
messageDrafts.approveDraft.mockResolvedValue({ id: 'd1', status: 'approved' });
await resolveQueueItem('drafts:d1');