Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: hold the failed-scene video Retry behind the speaker save gate (#11040)

Adam Eivyf1b359805f29
diff --git a/client/src/components/musicVideo/SceneCard.jsx b/client/src/components/musicVideo/SceneCard.jsx
index 7da2ed6742..0cac355f8f 100644
--- a/client/src/components/musicVideo/SceneCard.jsx
+++ b/client/src/components/musicVideo/SceneCard.jsx
@@ -74,6 +74,20 @@ const SCENE_TIME_FIELDS = [['Start', 'startSec'], ['End', 'endSec']];
*/
const MOVE_DOCUMENT_TITLE = "This video's shot order comes from its composition document";
+// #11040: the one owner of whether a video render may start. The server reloads
+// the persisted scene (and its speaker), so an unsaved or failed speaker edit
+// must hold back every video entry point — Generate video and the failure Retry.
+// Returns the refusal reason, or null when the render may go ahead.
+function videoGenerationRefusal({ settingsSaving, speakerUnsaved, referenceImageId, generatingVideo, videoBlockedReason, performanceBlocked }) {
+ if (videoBlockedReason) return videoBlockedReason;
+ if (performanceBlocked) return performanceBlocked;
+ if (speakerUnsaved) return 'Save the speaker / singer edit first';
+ if (settingsSaving) return 'Saving settings…';
+ if (!referenceImageId) return 'Generate a reference frame first';
+ if (generatingVideo) return 'A video is already generating';
+ return null;
+}
+
export default function SceneCard({
scene, index, isLast, generatingFrame, generatingVideo, frameProgress = null, videoProgress = null,
settingsSaving, videoBlockedReason, canContinueShot,
@@ -156,6 +170,11 @@ export default function SceneCard({
// retry is in flight (or lands a take, which clears it server-side).
const failure = scene.lastFailure && !(scene.lastFailure.lane === 'video' ? generatingVideo : generatingFrame)
? scene.lastFailure : null;
+ const videoRefusal = videoGenerationRefusal({
+ settingsSaving, speakerUnsaved: performance && (speakerDirty || speakerSaving),
+ referenceImageId: scene.referenceImageId, generatingVideo, videoBlockedReason, performanceBlocked,
+ });
+ const generateVideo = () => { if (!videoRefusal) onGenerateVideo?.(scene); };
return (
<div className="min-w-0">
<details
@@ -512,13 +531,12 @@ export default function SceneCard({
</button>
</div>
)}
- <button onClick={() => onGenerateVideo(scene)}
- disabled={settingsSaving || (performance && (speakerDirty || speakerSaving)) || !scene.referenceImageId || !!generatingVideo || !!videoBlockedReason || !!performanceBlocked}
+ <button onClick={generateVideo}
+ disabled={!!videoRefusal}
className="flex items-center gap-1 bg-port-border hover:bg-port-border/70 disabled:opacity-50 rounded px-2 py-1.5 text-xs min-h-[44px] sm:min-h-0 whitespace-nowrap"
- title={videoBlockedReason || performanceBlocked
- || (!scene.referenceImageId ? 'Generate a reference frame first'
- : performance ? `Lip-sync this scene's frame to the song via ${capability.label} — ${performanceCost}`
- : "Generate this scene's video from its reference frame (i2v)")}>
+ title={videoRefusal
+ || (performance ? `Lip-sync this scene's frame to the song via ${capability.label} — ${performanceCost}`
+ : "Generate this scene's video from its reference frame (i2v)")}>
{generatingVideo ? <Activity size={14} className="animate-spin" /> : <Video size={14} />}
{generatingVideo ? 'Generating video…' : (scene.videoHistoryId ? 'New video take' : 'Generate video')}
</button>
@@ -554,8 +572,10 @@ export default function SceneCard({
{failure.lane === 'video' ? 'Video' : 'Frame'} failed: {failure.error}
</span>
<button type="button"
- onClick={() => (failure.lane === 'video' ? onGenerateVideo?.(scene) : onGenerateFrame?.(scene))}
- className="inline-flex min-h-[44px] shrink-0 items-center px-1 font-medium underline sm:min-h-0">
+ onClick={() => (failure.lane === 'video' ? generateVideo() : onGenerateFrame?.(scene))}
+ disabled={failure.lane === 'video' && !!videoRefusal}
+ title={failure.lane === 'video' ? videoRefusal || undefined : undefined}
+ className="inline-flex min-h-[44px] shrink-0 items-center px-1 font-medium underline disabled:opacity-50 sm:min-h-0">
Retry
</button>
</div>
diff --git a/client/src/components/musicVideo/SceneCard.test.jsx b/client/src/components/musicVideo/SceneCard.test.jsx
index 9bd7e7de52..76b053f594 100644
--- a/client/src/components/musicVideo/SceneCard.test.jsx
+++ b/client/src/components/musicVideo/SceneCard.test.jsx
@@ -48,6 +48,55 @@ describe('performance speaker save boundary', () => {
});
});
+describe('failed video retry behind the speaker save gate (#11040)', () => {
+ function Harness({ onSave, onGenerateVideo, onGenerateFrame = vi.fn(), lastFailure }) {
+ const [scene, setScene] = useState({ sceneId: 's1', shotMode: 'performance', startSec: 0, endSec: 5, referenceImageId: 'frame.png', takes: [], lastFailure });
+ return <SceneCard scene={scene} index={0} lipSyncBackend="fal" songDurationSec={30}
+ onEditLocal={(_id, patch) => setScene((current) => ({ ...current, ...patch }))} onSave={onSave}
+ onGenerateVideo={onGenerateVideo} onGenerateFrame={onGenerateFrame} />;
+ }
+ const videoFailure = { lane: 'video', error: 'Example failure', at: '2026-10-05T00:00:00.000Z' };
+
+ it('refuses the video Retry while the speaker edit is dirty, saving, or failed to save, then recovers', async () => {
+ let settle;
+ const onSave = vi.fn(() => new Promise((resolve) => { settle = resolve; }));
+ const onGenerateVideo = vi.fn();
+ render(<Harness onSave={onSave} onGenerateVideo={onGenerateVideo} lastFailure={videoFailure} />);
+ const input = screen.getByLabelText('Speaker / singer');
+ const retry = screen.getByRole('button', { name: 'Retry' });
+ const generate = screen.getByRole('button', { name: 'Generate video' });
+ expect(retry.disabled).toBe(false);
+ fireEvent.change(input, { target: { value: 'Example Singer' } });
+ expect([generate.disabled, retry.disabled]).toEqual([true, true]);
+ fireEvent.click(retry);
+ fireEvent.blur(input);
+ expect([generate.disabled, retry.disabled]).toEqual([true, true]);
+ fireEvent.click(retry);
+ settle(false);
+ await waitFor(() => expect(onSave).toHaveBeenCalledTimes(1));
+ expect([generate.disabled, retry.disabled]).toEqual([true, true]);
+ fireEvent.click(retry);
+ expect(retry.title).toBe(generate.title);
+ expect(onGenerateVideo).not.toHaveBeenCalled();
+ fireEvent.blur(input);
+ settle(true);
+ await waitFor(() => expect(retry.disabled).toBe(false));
+ fireEvent.click(retry);
+ expect(onGenerateVideo).toHaveBeenCalledTimes(1);
+ });
+
+ it('leaves the frame Retry available while the speaker edit is unsaved', () => {
+ const onGenerateFrame = vi.fn();
+ const onGenerateVideo = vi.fn();
+ render(<Harness onSave={vi.fn()} onGenerateVideo={onGenerateVideo} onGenerateFrame={onGenerateFrame}
+ lastFailure={{ ...videoFailure, lane: 'image' }} />);
+ fireEvent.change(screen.getByLabelText('Speaker / singer'), { target: { value: 'Example Singer' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));
+ expect(onGenerateFrame).toHaveBeenCalledTimes(1);
+ expect(onGenerateVideo).not.toHaveBeenCalled();
+ });
+});
+
describe('persisted render failure chip (#10154)', () => {
const failedScene = (lane) => ({ sceneId: 's1', startSec: 0, endSec: 5, referenceImageId: 'frame.png', takes: [],
lastFailure: { lane, error: 'CUDA out of memory', at: '2026-10-05T00:00:00.000Z' } });