Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: contain preview browser startup pipe errors and preserve CDP failures
[._.]/ Adam Eivyf38fff43d3af
diff --git a/server/services/htmlComposition/cdpPipe.js b/server/services/htmlComposition/cdpPipe.jsindex 92949336ca..7d6c116b42 100644--- a/server/services/htmlComposition/cdpPipe.js+++ b/server/services/htmlComposition/cdpPipe.js@@ -12,9 +12,11 @@ export function createCdpPipeTransport(proc) {const emitter = new EventEmitter();let buffer = Buffer.alloc(0);let open = true;+ let failure;const fail = (error) => {if (!open) return;- emitter.emit('error', error);+ failure ??= error;+ emitter.emit('error', failure);};const onData = (chunk) => {buffer = Buffer.concat([buffer, chunk]);@@ -37,6 +39,10 @@ export function createCdpPipeTransport(proc) {const transport = {readyState: 1,send(text, callback) {+ if (failure) {+ callback?.(failure);+ return;+ }if (!open || !input?.writable) {callback?.(new Error('CDP pipe is closed'));return;diff --git a/server/services/htmlComposition/ownedBrowser.js b/server/services/htmlComposition/ownedBrowser.jsindex 14573ca9bc..0409f7cb13 100644--- a/server/services/htmlComposition/ownedBrowser.js+++ b/server/services/htmlComposition/ownedBrowser.js@@ -85,6 +85,11 @@ export async function launchCompositionBrowser({const profile = await mkdtemp(join(tmpdir(), 'portos-composition-browser-'));let proc;let transport;+ let startupPipeError;+ let rejectStartupPipe;+ // Own pipe errors across the startup-to-CDP handoff. The CDP client also+ // subscribes, so this listener must not consume or replace its error path.+ const onPipeError = error => { startupPipeError ??= error; rejectStartupPipe?.(error); };let exited = false;let closed = false;let spawned = false;@@ -132,6 +137,7 @@ export async function launchCompositionBrowser({let deadline;try {transport?.terminate();+ transport?.removeListener('error', onPipeError);if (proc && !closed) {terminationStarted = performance.now();const tracked = {@@ -196,11 +202,15 @@ export async function launchCompositionBrowser({proc.once('exit', onExit);proc.once('close', onClose);proc.on('error', onError);- if (piped) transport = createCdpPipeTransport(proc);+ if (piped) {+ transport = createCdpPipeTransport(proc);+ transport.on('error', onPipeError);+ }const ready = await new Promise((resolve, reject) => {let tail = '';const timer = setTimeout(() => finish(new Error('Composition browser startup exceeded its deadline')), startupMs);const finish = (error, value) => {+ rejectStartupPipe = null;clearTimeout(timer);proc.stderr?.removeListener('data', onData);transport?.removeListener('message', onHandshake);@@ -232,15 +242,16 @@ export async function launchCompositionBrowser({else finish(null, message.result || {});};proc.stderr?.on('data', onData);+ proc.once('error', fail);+ proc.once('exit', stopped);+ signal?.addEventListener('abort', canceled, { once: true });if (piped) {+ rejectStartupPipe = () => finish(new Error('Composition browser failed to start (pipe)'));transport.on('message', onHandshake);transport.send(JSON.stringify({ id: 0, method: 'Browser.getVersion' }), (error) => {if (error) finish(new Error('Composition browser failed to start (pipe)'));});}- proc.once('error', fail);- proc.once('exit', stopped);- signal?.addEventListener('abort', canceled, { once: true });if (signal?.aborted) canceled();else if (exited) stopped();});@@ -249,6 +260,7 @@ export async function launchCompositionBrowser({proc.stderr?.resume();signal?.addEventListener('abort', abort, { once: true });signal?.throwIfAborted();+ if (startupPipeError) throw new Error('Composition browser failed to start (pipe)');if (piped) return { transport, close, mechanism: plan.mechanism };return { webSocketDebuggerUrl: ready, close };} catch (error) {diff --git a/server/services/htmlComposition/ownedBrowser.test.js b/server/services/htmlComposition/ownedBrowser.test.jsindex 5b55a5eb73..cc816ce043 100644--- a/server/services/htmlComposition/ownedBrowser.test.js+++ b/server/services/htmlComposition/ownedBrowser.test.js@@ -219,6 +219,36 @@ describe('owned composition capture browser lifecycle', () => {await owner.close();});+ it.each([3, 4])('rejects a startup error on pipe fd %s and disposes its owned browser', async fd => {+ const pipeIn = new PassThrough();+ const pipeOut = new PassThrough();+ child.stdio = [null, null, child.stderr, pipeIn, pipeOut];+ vi.spyOn(process, 'kill').mockImplementation(() => true);+ pipeIn.on('data', () => {+ child.stdio[fd].emit('error', Object.assign(new Error('/private/startup-path'), { code: 'EPIPE' }));+ });+ await expect(launchCompositionBrowser({ isolation: 'off' })).rejects.toThrow('Composition browser failed to start (pipe)');+ expect(child.kill).toHaveBeenCalledExactlyOnceWith('SIGTERM');+ await expect(access(profile)).rejects.toThrow();+ });++ it('retains handoff pipe failures for the CDP client and still forwards subsequent errors', async () => {+ answerHandshake();+ const owner = await launchCompositionBrowser({ isolation: 'off' });+ const error = Object.assign(new Error('Synthetic broken pipe'), { code: 'EPIPE' });+ // The launcher has returned, but the client has not subscribed yet.+ child.stdio[4].emit('error', error);+ const callback = vi.fn();+ owner.transport.send('{}', callback);+ expect(callback).toHaveBeenCalledExactlyOnceWith(error);+ const clientError = vi.fn();+ owner.transport.on('error', clientError);+ child.stdio[3].emit('error', error);+ expect(clientError).toHaveBeenCalledExactlyOnceWith(error);+ await owner.close();+ await expect(access(profile)).rejects.toThrow();+ });+it('retries a transient profile removal failure so a resolved close means the profile is gone', async () => {const owner = await launchCompositionBrowser();vi.mocked(rm).mockRejectedValueOnce(Object.assign(new Error('busy'), { code: 'ENOTEMPTY' }));