Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
Roll back new Digital Twin document file when metadata save fails (#11698)
[._.]/f3c036bf0929
diff --git a/server/services/digital-twin-documents.js b/server/services/digital-twin-documents.jsindex 53d64c46d6..b17048b068 100644--- a/server/services/digital-twin-documents.js+++ b/server/services/digital-twin-documents.js@@ -68,14 +68,15 @@ async function createDocumentLeased(data) {const filePath = documentWritePath(data.filename);await ensureSoulDir();- const meta = await loadMeta();+ // loadMeta shares its cached object; publish these changes only after saveMeta succeeds.+ const meta = structuredClone(await loadMeta());- // Check if file already exists- if (existsSync(filePath)) {+ // A file with no meta entry is an orphan from a failed earlier create; adopt it.+ const fileExisted = existsSync(filePath);+ if (fileExisted && documentRecords(meta).some(d => d?.filename === data.filename)) {throw new Error(`Document ${data.filename} already exists`);}- // Write the fileawait atomicWrite(filePath, data.content);// Re-creating a filename that was previously deleted must clear its tombstone@@ -100,7 +101,11 @@ async function createDocumentLeased(data) {meta.documents.push(docMeta);meta.documents.sort((a, b) => a.priority - b.priority);meta.deletedDocuments = clearTombstone(meta.deletedDocuments, data.filename, 'filename');- await saveMeta(meta);+ // Remove only the file this attempt created; preserve a pre-existing orphan.+ await saveMeta(meta).catch(async (err) => {+ if (!fileExisted) await unlink(filePath).catch(() => {});+ throw err;+ });console.log(`🧬 Created soul document: ${data.filename}`);return { ...docMeta, content: data.content };diff --git a/server/services/digital-twin-documents.tombstone.test.js b/server/services/digital-twin-documents.tombstone.test.jsindex 36af623853..af22c61355 100644--- a/server/services/digital-twin-documents.tombstone.test.js+++ b/server/services/digital-twin-documents.tombstone.test.js@@ -9,7 +9,7 @@*/import { describe, it, expect, vi, beforeEach, afterAll } from 'vitest';-import { existsSync, rmSync } from 'fs';+import { existsSync, rmSync, mkdirSync, writeFileSync, readFileSync } from 'fs';import { join } from 'path';import { createTempDataRoot, makePathsProxy } from '../lib/mockPathsDataRoot.js';@@ -171,3 +171,52 @@ it('invalidates only after synchronized document files are available', async ()digitalTwinEvents.off('sync:completed', listener);}});++describe('digital twin document create failure paths (#11681)', () => {+ const metaPath = join(twinDir, 'meta.json');++ it.each([+ { name: 'new file', orphan: false },+ { name: 'pre-existing orphan', orphan: true },+ ])('retries a $name after a failed metadata write without leaking cached changes', async ({ orphan }) => {+ // Keep cache expiry from hiding an immediate retry's stale-state regression.+ const clock = vi.spyOn(Date, 'now').mockReturnValue(Date.now());+ try {+ await saveMeta({ ...(await loadMeta()), deletedDocuments: [+ { filename: FILENAME, deletedAt: new Date(Date.now() - 60_000).toISOString() },+ ] });+ const before = structuredClone(await loadMeta());+ const persisted = readFileSync(metaPath, 'utf-8');+ if (orphan) writeFileSync(docPath, 'orphan');+ // A directory at the meta path makes the real metadata write fail.+ rmSync(metaPath, { force: true });+ mkdirSync(metaPath);+ await expect(newDoc()).rejects.toThrow();+ expect(existsSync(docPath)).toBe(orphan);+ expect(await loadMeta()).toEqual(before);++ // Repair I/O without resetting the cache, as an immediate user retry would.+ rmSync(metaPath, { recursive: true, force: true });+ writeFileSync(metaPath, persisted);+ const created = await newDoc();+ const saved = JSON.parse(readFileSync(metaPath, 'utf-8'));+ expect(saved.documents).toEqual([expect.objectContaining({ id: created.id, filename: FILENAME })]);+ expect(saved.deletedDocuments).toEqual([]);+ expect(readFileSync(docPath, 'utf-8')).toBe(CONTENT);+ } finally {+ clock.mockRestore();+ }+ });++ it('adopts an orphan file that has no meta entry', async () => {+ writeFileSync(docPath, 'orphan');+ const created = await newDoc();+ expect(readFileSync(docPath, 'utf-8')).toBe(CONTENT);+ expect((await loadMeta()).documents.map(d => d.id)).toContain(created.id);+ });++ it('still rejects a filename that is already in meta', async () => {+ await newDoc();+ await expect(newDoc()).rejects.toThrow(/already exists/);+ });+});diff --git a/server/services/digital-twin.test.js b/server/services/digital-twin.test.jsindex cbe3d0924c..81fe007af3 100644--- a/server/services/digital-twin.test.js+++ b/server/services/digital-twin.test.js@@ -437,7 +437,7 @@ describe('digital-twin.js', () => {});it('should throw if document already exists', async () => {- const meta = makeMeta();+ const meta = makeMeta({ documents: [makeDocMeta({ filename: 'EXISTING.md' })] });await setupMetaFile(meta);existsSync.mockReturnValue(true);