Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: remove dangling .claude/lib symlinks and guard tracked .claude symlinks (#11855)

Adam Eivyf431805b692a
diff --git a/.claude/lib/code-review-checklist.md b/.claude/lib/code-review-checklist.md
deleted file mode 120000
index 0c920f66b9..0000000000
--- a/.claude/lib/code-review-checklist.md
+++ /dev/null
@@ -1 +0,0 @@
-../../lib/slashdo/lib/code-review-checklist.md
\ No newline at end of file
diff --git a/.claude/lib/graphql-escaping.md b/.claude/lib/graphql-escaping.md
deleted file mode 120000
index 7c79279a70..0000000000
--- a/.claude/lib/graphql-escaping.md
+++ /dev/null
@@ -1 +0,0 @@
-../../lib/slashdo/lib/graphql-escaping.md
\ No newline at end of file
diff --git a/scripts/agent-instructions-files.test.js b/scripts/agent-instructions-files.test.js
index 2a8202aee6..5a8c199b29 100644
--- a/scripts/agent-instructions-files.test.js
+++ b/scripts/agent-instructions-files.test.js
@@ -1,7 +1,7 @@
import { describe, it, expect } from 'vitest';
import { execFileSync } from 'child_process';
-import { readFileSync, lstatSync } from 'fs';
-import { dirname, join } from 'path';
+import { readFileSync, lstatSync, existsSync, readlinkSync } from 'fs';
+import { dirname, join, resolve } from 'path';
import { fileURLToPath } from 'url';
// Regression guard for #4852. `AGENTS.md` is the cross-vendor agent-instructions
@@ -108,6 +108,28 @@ describe('agent-instructions files (#4852)', () => {
expect(hits.map((h) => h.line)).toEqual([]);
});
+ it('every tracked .claude/ symlink resolves to an existing file (#11855)', () => {
+ // Git symlinks (mode 120000) under .claude/ point into lib/slashdo, which
+ // upstream renames or removes. A dangling one fails any tool that enumerates
+ // tracked markdown with ENOENT. Targets inside lib/slashdo are skipped when
+ // the submodule is not checked out, because CI only initializes it on demand.
+ const submoduleReady = existsSync(join(REPO_ROOT, 'lib/slashdo/package.json'));
+ const links = git('ls-files', '-s', '--', '.claude')
+ .split('\n')
+ .filter((line) => line.startsWith('120000'))
+ .map((line) => line.split('\t')[1]);
+
+ expect(links.length, 'detector self-check: .claude/ must track symlinks').toBeGreaterThan(0);
+
+ const dangling = links.filter((link) => {
+ const target = readlinkSync(join(REPO_ROOT, link));
+ if (!submoduleReady && target.includes('lib/slashdo/')) return false;
+ return !existsSync(resolve(dirname(join(REPO_ROOT, link)), target));
+ });
+
+ expect(dangling).toEqual([]);
+ });
+
it('the scan actually reads tracked files (detector self-check)', () => {
// Non-vacuous guard: if the pathspec or the exclusions ever widened to
// everything, the assertion above would pass by scanning nothing.