Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
Keep provider reviewers on the shared provider selector
Claudefb718f459b69
diff --git a/client/src/components/apps/SlashDoRunDrawer.test.jsx b/client/src/components/apps/SlashDoRunDrawer.test.jsxindex efb4122b85..b5c174ca8f 100644--- a/client/src/components/apps/SlashDoRunDrawer.test.jsx+++ b/client/src/components/apps/SlashDoRunDrawer.test.jsx@@ -139,7 +139,7 @@ describe('SlashDoRunDrawer', () => {it('does not blame a claim-work override when the reviewers came from the install defaults', async () => {renderDrawer();- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());expect(screen.queryByText(/claim-work/)).not.toBeInTheDocument();});@@ -147,7 +147,7 @@ describe('SlashDoRunDrawer', () => {const onQueued = vi.fn();renderDrawer({ onQueued });- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());await userEvent.click(screen.getByRole('button', { name: /Remove Copilot/ }));await userEvent.click(screen.getByRole('button', { name: /Queue \/do:next/ }));@@ -159,9 +159,9 @@ describe('SlashDoRunDrawer', () => {it('hides the stop-mode and reviewer-applies controls the claim flow cannot honor', async () => {renderDrawer();- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());// Add a second, non-Copilot reviewer — the two flags render at 2+ / non-copilot.- await userEvent.selectOptions(screen.getByLabelText('AI reviewers'), 'claude');+ await userEvent.selectOptions(screen.getByLabelText('Add local / CLI'), 'claude');expect(screen.queryByText('Stop mode:')).not.toBeInTheDocument();expect(screen.queryByText(/Reviewer applies fixes/)).not.toBeInTheDocument();@@ -175,7 +175,7 @@ describe('SlashDoRunDrawer', () => {renderDrawer({ command: 'better', label: '/do:better' });await waitFor(() => expect(screen.getByText('Task settings')).toBeInTheDocument());- expect(screen.queryByText('AI reviewers')).not.toBeInTheDocument();+ expect(screen.queryByText('Add local / CLI')).not.toBeInTheDocument();expect(screen.queryByText('People & bots (GitHub/GitLab)')).not.toBeInTheDocument();});@@ -271,10 +271,10 @@ describe('SlashDoRunDrawer', () => {const onQueued = vi.fn();renderDrawer({ onQueued });- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());await userEvent.selectOptions(screen.getByLabelText('After opening PR'), 'merge-on-green');- expect(screen.queryByText('AI reviewers')).not.toBeInTheDocument();+ expect(screen.queryByText('Add local / CLI')).not.toBeInTheDocument();await userEvent.click(screen.getByRole('button', { name: /Queue \/do:next/ }));await waitFor(() => expect(onQueued).toHaveBeenCalled());@@ -300,6 +300,6 @@ describe('SlashDoRunDrawer', () => {renderDrawer();await waitFor(() => expect(screen.getByLabelText('After opening PR')).toHaveValue('merge-on-green'));- expect(screen.queryByText('AI reviewers')).not.toBeInTheDocument();+ expect(screen.queryByText('Add local / CLI')).not.toBeInTheDocument();});});diff --git a/client/src/components/apps/tabs/PullRequestsTab.test.jsx b/client/src/components/apps/tabs/PullRequestsTab.test.jsxindex e69a1951fc..a70f4d4aef 100644--- a/client/src/components/apps/tabs/PullRequestsTab.test.jsx+++ b/client/src/components/apps/tabs/PullRequestsTab.test.jsx@@ -647,7 +647,7 @@ describe('PullRequestsTab', () => {fireEvent.click(await screen.findByRole('button', { name: /^Remove codex$/i }));expect(screen.getByRole('button', { name: /Reviewer override \(active\)/ })).toBeInTheDocument();- fireEvent.change(screen.getByLabelText('AI reviewers'), { target: { value: 'codex' } });+ fireEvent.change(screen.getByLabelText('Add local / CLI'), { target: { value: 'codex' } });expect(screen.getByRole('button', { name: /^Reviewer override$/ })).toBeInTheDocument();fireEvent.click(screen.getByRole('button', { name: 'Resolve & merge' }));diff --git a/client/src/components/cos/ReviewerPicker.jsx b/client/src/components/cos/ReviewerPicker.jsxindex d7bf0c9609..2331b477d1 100644--- a/client/src/components/cos/ReviewerPicker.jsx+++ b/client/src/components/cos/ReviewerPicker.jsx@@ -1,6 +1,7 @@import { useId, useState } from 'react';import { Plus, X, ChevronUp, ChevronDown } from 'lucide-react';import Pill from '../ui/Pill';+import ProviderModelSelector from '../ProviderModelSelector';import {REVIEWER_OPTIONS,REVIEW_STOP_MODES,@@ -60,8 +61,8 @@ const HEADER_CLASS = `hidden @4xl:grid ${WIDE_TRACKS} items-center gap-x-2 px-1./*** Ordered multi-reviewer picker, rendered as one row per reviewer with the five* per-reviewer controls as columns: **Provider | Model | Effort | Optional | Max- * Iterations** (#3133). Add configured providers or standalone backends from one- * menu, reorder with the arrows within each service/standalone boundary, remove with ✕. Maps to slashdo's+ * Iterations** (#3133). Add configured providers or standalone backends from+ * their pickers (one pick adds), reorder with the arrows within each service/standalone boundary, remove with ✕. Maps to slashdo's* `--review-with a,b,c` plus the stop-mode / `--reviewer-applies` flags.** A second "GitHub reviewers" table collects arbitrary usernames (e.g.@@ -145,8 +146,8 @@ const HEADER_CLASS = `hidden @4xl:grid ${WIDE_TRACKS} items-center gap-x-2 px-1.* never clears.** Together with `modelOptions.providerDisabled`, that describes which reviewers- * can run on this machine. Configured providers and standalone backends share one- * Add menu, each option labeled with its unavailability. Missing/disabled saved+ * can run on this machine. Configured providers use the shared provider selector;+ * standalone backends use a compact local/CLI picker labeled with unavailability. Missing/disabled saved* rows remain editable with actionable warnings. `showReviewers`, `showUsernames`* and `renderReviewer` let the tier editor compose these same rows and controls* without introducing fallback-group fields to task-local overrides.@@ -741,29 +742,36 @@ export default function ReviewerPicker({return (<div className="@container flex flex-col gap-2 w-full">{showReviewers && (- <div className="flex flex-col gap-1 min-w-0">- <label htmlFor={`${id}-add`} className="text-xs text-gray-500">AI reviewers</label>- <select- id={`${id}-add`}- value=""- disabled={disabled || (addableProviders.length === 0 && addable.length === 0)}- onChange={event => add(event.target.value)}- className="w-full sm:w-80 max-w-full min-h-9 px-2 bg-port-bg border border-port-border rounded text-xs text-gray-300 focus:border-port-accent focus:outline-none disabled:opacity-50"- >- <option value="">{modelOptions?.loaded === false ? 'Loading reviewers…' : '+ Add AI reviewer'}</option>- {addableProviders.length > 0 && (- <optgroup label="Providers">- {addableProviders.map(provider => (- <option key={provider.id} value={`provider:${provider.id}`}>{provider.name || provider.id}{unavailability(`provider:${provider.id}`) ? ` (${unavailability(`provider:${provider.id}`).label})` : ''}</option>- ))}- </optgroup>- )}- {addable.length > 0 && (- <optgroup label="Local & CLI">+ <div className="flex flex-col sm:flex-row sm:items-end gap-2 min-w-0">+ <div className="w-full sm:w-64 max-w-full">+ <ProviderModelSelector+ dense+ label="Add AI provider"+ providers={addableProviders}+ selectedProviderId=""+ onProviderChange={providerId => add(providerId && `provider:${providerId}`)}+ emptyProviderOption={modelOptions?.loaded === false ? 'Loading…' : '+ Provider'}+ compose={false}+ highlightVision={false}+ loading={modelOptions?.loaded === false}+ disabled={disabled}+ />+ </div>+ {addable.length > 0 && (+ <div className="w-full sm:w-48 max-w-full">+ <label htmlFor={`${id}-legacy`} className="block mb-1 text-xs text-gray-500">Add local / CLI</label>+ <select+ id={`${id}-legacy`}+ value=""+ disabled={disabled}+ onChange={event => add(event.target.value)}+ className="w-full min-h-9 px-2 bg-port-bg border border-port-border rounded text-xs text-gray-300 focus:border-port-accent focus:outline-none disabled:opacity-50"+ >+ <option value="">+ Local / CLI</option>{addable.map(option => <option key={option.value} value={option.value}>{option.label}{unavailability(option.value) ? ` (${unavailability(option.value).label})` : ''}</option>)}- </optgroup>- )}- </select>+ </select>+ </div>+ )}{modelOptions?.providersLoaded === false && modelOptions?.loaded && <p role="alert" className="text-xs text-port-warning">Provider list unavailable. Reload to retry.</p>}</div>)}diff --git a/client/src/components/cos/ReviewerPicker.test.jsx b/client/src/components/cos/ReviewerPicker.test.jsxindex 2539ee657f..4165135970 100644--- a/client/src/components/cos/ReviewerPicker.test.jsx+++ b/client/src/components/cos/ReviewerPicker.test.jsx@@ -52,7 +52,7 @@ describe('ReviewerPicker', () => {return <ReviewerPicker {...config} modelOptions={{ providers }} onChange={value => { onChange(value); setConfig(value); }} />;}render(<Form />);- fireEvent.change(screen.getByLabelText('AI reviewers'), { target: { value: 'provider:codex-tui' } });+ fireEvent.change(screen.getByLabelText('Add AI provider'), { target: { value: 'codex-tui' } });fireEvent.change(screen.getByLabelText('Reasoning effort for Codex TUI'), { target: { value: 'ultra' } });const effort = screen.getByLabelText('Reasoning effort for Codex TUI');expect(effort).toHaveValue('ultra');@@ -219,7 +219,7 @@ describe('ReviewerPicker', () => {);expect(screen.getByRole('option', { name: /Kimi/ })).toHaveTextContent('disabled');expect(screen.getByRole('option', { name: /Antigravity/ })).toHaveTextContent('not installed');- await user.selectOptions(screen.getByLabelText('AI reviewers'), 'kimi');+ await user.selectOptions(screen.getByLabelText('Add local / CLI'), 'kimi');expect(onChange).toHaveBeenCalledWith(expect.objectContaining({ reviewers: ['copilot', 'kimi'] }));});@@ -262,7 +262,7 @@ describe('ReviewerPicker', () => {const onChange = vi.fn();const user = userEvent.setup();render(<ReviewerPicker reviewers={['copilot']} onChange={onChange} />);- await user.selectOptions(screen.getByLabelText('AI reviewers'), 'codex');+ await user.selectOptions(screen.getByLabelText('Add local / CLI'), 'codex');expect(onChange).toHaveBeenCalledWith(expect.objectContaining({ reviewers: ['copilot', 'codex'] }));});diff --git a/client/src/components/cos/TaskAddForm.test.jsx b/client/src/components/cos/TaskAddForm.test.jsxindex 01504f0192..12d6731279 100644--- a/client/src/components/cos/TaskAddForm.test.jsx+++ b/client/src/components/cos/TaskAddForm.test.jsx@@ -249,7 +249,7 @@ describe('TaskAddForm responsive layout', () => {/>);- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());const options = screen.getByRole('form', { name: 'Add new task' }).querySelector('div.grid');expect(options).toHaveClass('grid-cols-1');@@ -373,7 +373,7 @@ describe('TaskAddForm responsive layout', () => {api.addCosTask.mockResolvedValue({ success: true });render(<TaskAddForm providers={[]} apps={[app]} defaultApp="example-app" onTaskAdded={vi.fn()} />);- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());await user.type(screen.getByPlaceholderText('Task description *'), 'Fix the bug');await user.click(screen.getByRole('button', { name: /^Add$/ }));@@ -391,7 +391,7 @@ describe('TaskAddForm responsive layout', () => {api.addCosTask.mockResolvedValue({ success: true });render(<TaskAddForm providers={[]} apps={[app]} defaultApp="example-app" onTaskAdded={vi.fn()} />);- await waitFor(() => expect(screen.getByText('AI reviewers')).toBeInTheDocument());+ await waitFor(() => expect(screen.getByText('Add local / CLI')).toBeInTheDocument());const stopModeSelect = await screen.findByLabelText('Stop mode:');await user.selectOptions(stopModeSelect, 'on-clean');diff --git a/client/src/components/settings/CodeReviewersTab.test.jsx b/client/src/components/settings/CodeReviewersTab.test.jsxindex fef67d7c54..78e6f7ee37 100644--- a/client/src/components/settings/CodeReviewersTab.test.jsx+++ b/client/src/components/settings/CodeReviewersTab.test.jsx@@ -51,9 +51,9 @@ describe('CodeReviewersTab', () => {api.getCodeReviewDefaults.mockResolvedValue({ reviewers: ['copilot'], codexModel: 'legacy-model', claudeEffort: 'medium' });api.updateSettings.mockResolvedValue({});const view = renderTab(<CodeReviewersTab />);- const provider = await screen.findByLabelText('AI reviewers');+ const provider = await screen.findByLabelText('Add AI provider');expect(screen.queryByRole('option', { name: 'Disabled API' })).not.toBeInTheDocument();- fireEvent.change(provider, { target: { value: 'provider:example-gpu' } });+ fireEvent.change(provider, { target: { value: 'example-gpu' } });fireEvent.change(screen.getByLabelText('Model for Example GPU'), { target: { value: 'coder-b' } });fireEvent.change(screen.getByLabelText('Reasoning effort for Example GPU'), { target: { value: 'high' } });fireEvent.click(screen.getByRole('button', { name: 'Save defaults' }));@@ -104,9 +104,9 @@ describe('CodeReviewersTab', () => {expect(api.updateSettings).not.toHaveBeenCalled();expect(screen.queryByLabelText('Fallback reviewer groups')).not.toBeInTheDocument();const fallback = screen.getByRole('region', { name: 'Fallback 1' });- fireEvent.change(within(fallback).getByLabelText('AI reviewers'), { target: { value: 'provider:example-gpu' } });+ fireEvent.change(within(fallback).getByLabelText('Add AI provider'), { target: { value: 'example-gpu' } });expect(screen.getAllByLabelText('Model for Example GPU')).toHaveLength(2);- expect(within(within(fallback).getByLabelText('AI reviewers')).queryByRole('option', { name: 'Example GPU' })).not.toBeInTheDocument();+ expect(within(within(fallback).getByLabelText('Add AI provider')).queryByRole('option', { name: 'Example GPU' })).not.toBeInTheDocument();fireEvent.change(within(fallback).getByLabelText('Reasoning effort for Example GPU'), { target: { value: 'low' } });expect(within(primary).getByLabelText('Reasoning effort for Example GPU')).toHaveValue('low');fireEvent.click(within(primary).getByLabelText('Remove Example GPU'));