Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: isolate media registry publication and test imports (#11550)

[._.]/fbc1ca1bc5bf
diff --git a/server/lib/db/schema/index.test.js b/server/lib/db/schema/index.test.js
index e4b16e0446..d8775928af 100644
--- a/server/lib/db/schema/index.test.js
+++ b/server/lib/db/schema/index.test.js
@@ -98,4 +98,3 @@ describe('db/schema composer covers every module in the directory (#5682)', () =
}
});
});
-// @vitest-environment node
diff --git a/server/lib/mediaModels.atomic.test.js b/server/lib/mediaModels.atomic.test.js
new file mode 100644
index 0000000000..681bbe327f
--- /dev/null
+++ b/server/lib/mediaModels.atomic.test.js
@@ -0,0 +1,80 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import * as fs from 'node:fs';
+import { join } from 'node:path';
+import { tmpdir } from 'node:os';
+
+const hooks = vi.hoisted(() => ({ write: null, rename: null }));
+vi.mock('fs', async (importOriginal) => {
+ const actual = await importOriginal();
+ return {
+ ...actual,
+ writeFileSync: (...args) => hooks.write ? hooks.write(actual, ...args) : actual.writeFileSync(...args),
+ renameSync: (...args) => hooks.rename ? hooks.rename(actual, ...args) : actual.renameSync(...args),
+ };
+});
+
+let root;
+let file;
+const priorRegistryFile = process.env.PORTOS_MEDIA_MODELS_FILE;
+beforeEach(() => {
+ root = fs.mkdtempSync(join(tmpdir(), 'media-atomic-'));
+ file = join(root, 'media-models.json');
+ process.env.PORTOS_MEDIA_MODELS_FILE = file;
+ vi.resetModules();
+});
+afterEach(() => {
+ hooks.write = null;
+ hooks.rename = null;
+ if (priorRegistryFile === undefined) delete process.env.PORTOS_MEDIA_MODELS_FILE;
+ else process.env.PORTOS_MEDIA_MODELS_FILE = priorRegistryFile;
+ fs.rmSync(root, { recursive: true, force: true });
+});
+
+const boot = () => import('../test/fixtures/mediaRegistryImport.js');
+
+describe('registry publication at the boot import boundary', () => {
+ it('finishes two interleaved initializations without consuming the other writer’s file', async () => {
+ fs.writeFileSync(file, JSON.stringify({ marker: 'original' }));
+ const second = await import('./mediaModels.js');
+ vi.resetModules();
+ let interleaved = false;
+ hooks.rename = (actual, source, destination) => {
+ hooks.rename = null;
+ // The first writer is fully prepared but has not published. A second
+ // module instance loads and publishes before the first resumes.
+ expect(JSON.parse(actual.readFileSync(file, 'utf8')).marker).toBe('original');
+ const loaded = second.loadMediaModels();
+ expect(JSON.parse(actual.readFileSync(file, 'utf8'))).toEqual(loaded);
+ expect(actual.existsSync(source)).toBe(true);
+ interleaved = true;
+ actual.renameSync(source, destination);
+ };
+ const { registry } = await boot();
+ expect(interleaved).toBe(true);
+ expect(JSON.parse(fs.readFileSync(file, 'utf8'))).toEqual(registry);
+ expect(registry._shippedDefaults.image.list.length).toBeGreaterThan(0);
+ expect(fs.readdirSync(root)).toEqual(['media-models.json']);
+ });
+
+ it.each(['write', 'rename'])('preserves the original and other temporary files after %s failure', async (phase) => {
+ const original = JSON.stringify({ marker: 'preserved' });
+ fs.writeFileSync(file, original);
+ const other = join(root, 'media-models.json.other.tmp');
+ fs.writeFileSync(other, 'another operation');
+ const failure = new Error(`injected ${phase} failure`);
+ hooks[phase] = (actual, ...args) => {
+ if (phase === 'write') actual.writeFileSync(args[0], 'partial preparation');
+ throw failure;
+ };
+ await expect(boot()).rejects.toBe(failure);
+ expect(fs.readFileSync(file, 'utf8')).toBe(original);
+ expect(fs.readFileSync(other, 'utf8')).toBe('another operation');
+ expect(fs.readdirSync(root).sort()).toEqual(['media-models.json', 'media-models.json.other.tmp']);
+ });
+
+ it('publishes a complete registry on first boot', async () => {
+ const { registry } = await boot();
+ expect(JSON.parse(fs.readFileSync(file, 'utf8'))).toEqual(registry);
+ expect(fs.readdirSync(root)).toEqual(['media-models.json']);
+ });
+});
diff --git a/server/lib/mediaModels.js b/server/lib/mediaModels.js
index a2ee6691b6..d53bd58df4 100644
--- a/server/lib/mediaModels.js
+++ b/server/lib/mediaModels.js
@@ -59,8 +59,9 @@
* - selectedTextEncoder: id of the active text encoder
*/
-import { existsSync, mkdirSync, readFileSync, writeFileSync, renameSync } from 'fs';
+import { existsSync, mkdirSync, readFileSync, writeFileSync, renameSync, openSync, closeSync, rmSync } from 'fs';
import { join, dirname } from 'path';
+import { randomUUID } from 'node:crypto';
import { PATHS, expandHome } from './fileUtils.js';
import { isPlainObject } from './objects.js';
import {
@@ -1188,15 +1189,25 @@ export const getShippedMediaRegistry = () => structuredClone(DEFAULT_REGISTRY);
// Write-then-rename so a crash mid-write can't truncate the registry — it holds
// every user-added model and the shipped-defaults ledger the upgrade merge reads.
const writeRegistryAtomic = (reg) => {
- const temporary = `${REGISTRY_FILE}.tmp`;
- writeFileSync(temporary, JSON.stringify(reg, null, 2) + '\n');
- renameSync(temporary, REGISTRY_FILE);
+ const temporary = `${REGISTRY_FILE}.${randomUUID()}.tmp`;
+ // Exclusive creation establishes ownership before cleanup is allowed.
+ const fd = openSync(temporary, 'wx');
+ try {
+ try {
+ writeFileSync(fd, JSON.stringify(reg, null, 2) + '\n');
+ } finally {
+ closeSync(fd);
+ }
+ renameSync(temporary, REGISTRY_FILE);
+ } finally {
+ rmSync(temporary, { force: true });
+ }
};
const seedIfMissing = () => {
if (existsSync(REGISTRY_FILE)) return;
ensureDir(REGISTRY_FILE);
- writeFileSync(REGISTRY_FILE, JSON.stringify(DEFAULT_REGISTRY, null, 2) + '\n');
+ writeRegistryAtomic(DEFAULT_REGISTRY);
console.log(`📝 Seeded media model registry: ${REGISTRY_FILE}`);
};
diff --git a/server/lib/mediaModels.test.js b/server/lib/mediaModels.test.js
index 7c76e17664..50ed856c36 100644
--- a/server/lib/mediaModels.test.js
+++ b/server/lib/mediaModels.test.js
@@ -10,6 +10,7 @@ const __dirname_self = dirname(fileURLToPath(import.meta.url));
let tmpDir;
let registryFile;
+const priorRegistryFile = process.env.PORTOS_MEDIA_MODELS_FILE;
beforeEach(() => {
tmpDir = mkdtempSync(join(tmpdir(), 'portos-media-models-'));
@@ -19,7 +20,8 @@ beforeEach(() => {
});
afterEach(() => {
- delete process.env.PORTOS_MEDIA_MODELS_FILE;
+ if (priorRegistryFile === undefined) delete process.env.PORTOS_MEDIA_MODELS_FILE;
+ else process.env.PORTOS_MEDIA_MODELS_FILE = priorRegistryFile;
rmSync(tmpDir, { recursive: true, force: true });
});
diff --git a/server/lib/recurrenceValidation.test.js b/server/lib/recurrenceValidation.test.js
index 0a493b8c95..c379ef1721 100644
--- a/server/lib/recurrenceValidation.test.js
+++ b/server/lib/recurrenceValidation.test.js
@@ -1,4 +1,3 @@
-// @vitest-environment node
import { describe, expect, it } from 'vitest';
import { recurrenceRuleSchema } from './recurrenceValidation.js';
diff --git a/server/test/fixtures/mediaRegistryImport.js b/server/test/fixtures/mediaRegistryImport.js
new file mode 100644
index 0000000000..6a5e71f6f5
--- /dev/null
+++ b/server/test/fixtures/mediaRegistryImport.js
@@ -0,0 +1,3 @@
+// A boot-time consumer: failure to persist the ledger must reject the import.
+import { loadMediaModels } from '../../lib/mediaModels.js';
+export const registry = loadMediaModels();
diff --git a/server/test/mediaRegistryEnvironment.js b/server/test/mediaRegistryEnvironment.js
new file mode 100644
index 0000000000..d4f795e88d
--- /dev/null
+++ b/server/test/mediaRegistryEnvironment.js
@@ -0,0 +1,32 @@
+import { builtinEnvironments } from 'vitest/runtime';
+import { mkdtempSync, rmSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+
+// Registry consumers persist during collection, before any test hook runs.
+// Vitest skips afterAll for wholly skipped files; environment teardown still
+// runs, including after collection failures. Own the fixture at that boundary.
+export default {
+ ...builtinEnvironments.node,
+ name: 'portos-media-registry',
+ viteEnvironment: 'ssr',
+ async setup(global, options) {
+ const node = await builtinEnvironments.node.setup(global, options);
+ const prior = process.env.PORTOS_MEDIA_MODELS_FILE;
+ const root = prior ? null : mkdtempSync(join(tmpdir(), 'portos-suite-media-'));
+ if (root) process.env.PORTOS_MEDIA_MODELS_FILE = join(root, 'media-models.json');
+ return {
+ async teardown() {
+ try {
+ if (root) {
+ if (prior === undefined) delete process.env.PORTOS_MEDIA_MODELS_FILE;
+ else process.env.PORTOS_MEDIA_MODELS_FILE = prior;
+ rmSync(root, { recursive: true, force: true });
+ }
+ } finally {
+ await node.teardown(global);
+ }
+ },
+ };
+ },
+};
diff --git a/server/vitest.config.db.js b/server/vitest.config.db.js
index 464174f43a..d4a4b1ecdd 100644
--- a/server/vitest.config.db.js
+++ b/server/vitest.config.db.js
@@ -39,6 +39,8 @@ export { DB_TEST_INCLUDE } from '../scripts/lib/dbTestFiles.js';
*/
export default defineConfig({
test: {
+ // Environment teardown also owns collection-only/skipped suite fixtures.
+ environment: fileURLToPath(new URL('./test/mediaRegistryEnvironment.js', import.meta.url)),
testTimeout: process.platform === 'win32' ? 30000 : 15000,
// Explicit 'vitest' imports only, matching vitest.config.js (#9049).
globals: false,
diff --git a/server/vitest.config.js b/server/vitest.config.js
index 4fac5c47c9..4176236346 100644
--- a/server/vitest.config.js
+++ b/server/vitest.config.js
@@ -41,6 +41,8 @@ process.env.NODE_DISABLE_COMPILE_CACHE = '1';
const config = defineConfig({
test: {
+ // Environment teardown also owns collection-only/skipped suite fixtures.
+ environment: fileURLToPath(new URL('./test/mediaRegistryEnvironment.js', import.meta.url)),
...vitestCiPool(),
// Workers get their own process.env — set it there as well as above.
env: {
diff --git a/server/vitest.mediaRegistry.test.js b/server/vitest.mediaRegistry.test.js
new file mode 100644
index 0000000000..954000397e
--- /dev/null
+++ b/server/vitest.mediaRegistry.test.js
@@ -0,0 +1,56 @@
+import { expect, it } from 'vitest';
+import { spawnSync } from 'node:child_process';
+import { mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+it.each(['run', 'skip', 'collection-failure'])('isolates boot imports and explicit fixtures when suites %s', (mode) => {
+ const root = mkdtempSync(join(tmpdir(), 'media-setup-contract-'));
+ const setup = fileURLToPath(new URL('./vitest.setup.js', import.meta.url));
+ const environment = fileURLToPath(new URL('./test/mediaRegistryEnvironment.js', import.meta.url));
+ const consumer = fileURLToPath(new URL('./test/fixtures/mediaRegistryImport.js', import.meta.url));
+ const vitest = fileURLToPath(new URL('./node_modules/vitest/vitest.mjs', import.meta.url));
+ const vitestApi = fileURLToPath(new URL('./node_modules/vitest/dist/index.js', import.meta.url));
+ const config = join(root, 'vitest.config.mjs');
+ writeFileSync(config, `export default { test: { environment: ${JSON.stringify(environment)}, setupFiles: [${JSON.stringify(setup)}], maxWorkers: 1, fileParallelism: false } };`);
+ for (const name of ['first', 'second']) {
+ writeFileSync(join(root, `${name}.test.mjs`), `
+ import { it, expect } from ${JSON.stringify(vitestApi)};
+ import { readFileSync, writeFileSync } from 'node:fs';
+ import { registry } from ${JSON.stringify(consumer)};
+ writeFileSync(${JSON.stringify(join(root, `${name}.json`))}, JSON.stringify({ path: process.env.PORTOS_MEDIA_MODELS_FILE, registry }));
+ ${mode === 'collection-failure' ? 'throw new Error("synthetic collection failure");' : ''}
+ ${mode === 'skip' ? 'it.skip' : 'it'}('loads during collection', () => {
+ const path = process.env.PORTOS_MEDIA_MODELS_FILE;
+ expect(JSON.parse(readFileSync(path, 'utf8'))).toEqual(registry);
+ });
+ `);
+ }
+ const env = { ...process.env, NODE_ENV: 'test', NODE_DISABLE_COMPILE_CACHE: '1' };
+ delete env.PORTOS_MEDIA_MODELS_FILE;
+ delete env.VITEST_POOL_ID;
+ delete env.VITEST_WORKER_ID;
+ const run = () => spawnSync(process.execPath, [vitest, 'run', '--configLoader', 'native', '--config', config, '--root', root], {
+ env, encoding: 'utf8', timeout: 20000,
+ });
+ try {
+ const result = run();
+ expect(result.status, result.stdout + result.stderr).toBe(mode === 'collection-failure' ? 1 : 0);
+ if (mode === 'collection-failure') expect(result.stderr).toContain('synthetic collection failure');
+ const first = JSON.parse(readFileSync(join(root, 'first.json'), 'utf8'));
+ const second = JSON.parse(readFileSync(join(root, 'second.json'), 'utf8'));
+ expect(first.path).not.toBe(second.path);
+ // Both registries were test-owned and removed by their suite teardown.
+ expect(() => readFileSync(first.path)).toThrow();
+ expect(() => readFileSync(second.path)).toThrow();
+ env.PORTOS_MEDIA_MODELS_FILE = join(root, 'explicit.json');
+ writeFileSync(env.PORTOS_MEDIA_MODELS_FILE, JSON.stringify({ ...first.registry, fixtureMarker: 'explicit' }));
+ const explicit = run();
+ expect(explicit.status, explicit.stdout + explicit.stderr).toBe(mode === 'collection-failure' ? 1 : 0);
+ expect(JSON.parse(readFileSync(join(root, 'first.json'), 'utf8')).path).toBe(env.PORTOS_MEDIA_MODELS_FILE);
+ expect(JSON.parse(readFileSync(env.PORTOS_MEDIA_MODELS_FILE, 'utf8')).fixtureMarker).toBe('explicit');
+ } finally {
+ rmSync(root, { recursive: true, force: true });
+ }
+});
diff --git a/server/vitest.setup.js b/server/vitest.setup.js
index 86c465554c..4d524918d0 100644
--- a/server/vitest.setup.js
+++ b/server/vitest.setup.js
@@ -55,6 +55,12 @@ import { rmSync } from 'fs';
import { mockNoPeers } from './lib/mockPathsDataRoot.js';
import './test/admissionSetup.js';
+// A per-file environment override must not silently bypass registry isolation.
+// The configured node environment owns cleanup even for skipped/failed imports.
+if (!process.env.PORTOS_MEDIA_MODELS_FILE) {
+ throw new Error('Server tests require the configured media registry environment or an explicit registry fixture');
+}
+
// The server intentionally logs expected error paths, lifecycle transitions,
// and fallback decisions. With console interception disabled (see the config),
// `--silent=passed-only` cannot suppress those lines: PR #5296 emitted 15,355