Skip to content

Force Proxy to any Windows/MacOS/Linux Application TCP and UDP traffic

FIxed SAST Sonarqube Buffer Overflow and DOS

AnoF-Cyber368a546c2700
diff --git a/Windows/gui/ViewModels/ProxyRulesViewModel.cs b/Windows/gui/ViewModels/ProxyRulesViewModel.cs
index 59dff75..3ea29e5 100644
--- a/Windows/gui/ViewModels/ProxyRulesViewModel.cs
+++ b/Windows/gui/ViewModels/ProxyRulesViewModel.cs
@@ -12,7 +12,8 @@ public class ProxyRulesViewModel : ViewModelBase
{
private static readonly System.Text.RegularExpressions.Regex _processNameRegex =
new(@"^[\w\s._\-*;""\\:()\u4E00-\u9FFF\u3400-\u4DBF\uF900-\uFAFF]+$",
- System.Text.RegularExpressions.RegexOptions.Compiled);
+ System.Text.RegularExpressions.RegexOptions.Compiled,
+ TimeSpan.FromSeconds(1));
private readonly Loc _loc = Loc.Instance;
public Loc Loc => _loc;
diff --git a/Windows/gui/ViewModels/ProxySettingsViewModel.cs b/Windows/gui/ViewModels/ProxySettingsViewModel.cs
index 845a93e..bc973e5 100644
--- a/Windows/gui/ViewModels/ProxySettingsViewModel.cs
+++ b/Windows/gui/ViewModels/ProxySettingsViewModel.cs
@@ -13,7 +13,8 @@ public class ProxySettingsViewModel : ViewModelBase
{
private static readonly Regex _domainRegex =
new(@"^(?:[a-zA-Z0-9](?:[a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])?\.)*[a-zA-Z0-9](?:[a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])?$",
- RegexOptions.Compiled);
+ RegexOptions.Compiled,
+ TimeSpan.FromSeconds(1));
private readonly Loc _loc = Loc.Instance;
public Loc Loc => _loc;
diff --git a/Windows/src/ProxyBridge.c b/Windows/src/ProxyBridge.c
index 0309b18..93d6390 100644
--- a/Windows/src/ProxyBridge.c
+++ b/Windows/src/ProxyBridge.c
@@ -1995,8 +1995,8 @@ static int socks5_connect(SOCKET s, UINT32 dest_ip, UINT16 dest_port, const PROX
}
// Send username/password (RFC 1929)
- size_t user_len = strlen(cfg->username);
- size_t pass_len = strlen(cfg->password);
+ size_t user_len = strnlen_s(cfg->username, sizeof(cfg->username));
+ size_t pass_len = strnlen_s(cfg->password, sizeof(cfg->password));
if (user_len > 255 || pass_len > 255)
{
log_message("SOCKS5: Username or password too long");
@@ -2072,7 +2072,8 @@ static int socks5_connect_v6(SOCKET s, const UINT8 dest_ip6[16], UINT16 dest_por
if (buf[1] == 0x02)
{
if (!use_auth) return -1;
- size_t ul = strlen(cfg->username), pl = strlen(cfg->password);
+ size_t ul = strnlen_s(cfg->username, sizeof(cfg->username));
+ size_t pl = strnlen_s(cfg->password, sizeof(cfg->password));
if (ul > 255 || pl > 255) return -1;
buf[0] = 0x01; buf[1] = (unsigned char)ul;
memcpy(&buf[2], cfg->username, ul);
@@ -2271,8 +2272,8 @@ static int socks5_udp_associate_with_config(SOCKET s, struct sockaddr_in *relay_
if (!use_auth)
return -1;
- size_t user_len = strlen(cfg->username);
- size_t pass_len = strlen(cfg->password);
+ size_t user_len = strnlen_s(cfg->username, sizeof(cfg->username));
+ size_t pass_len = strnlen_s(cfg->password, sizeof(cfg->password));
if (user_len > 255 || pass_len > 255)
return -1;