Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Restore native installer compilation and frontend style gates

pulse-triage[bot]00680c9c5a6a
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 02b4695e2a..8d69373b9d 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -1525,6 +1525,14 @@ shapes with a real child process that emits an unset-variable warning;
and diagnostic retention. These offline controls do not establish hosted Compose
readiness, mounted-secret identity, persisted restart or clean owned teardown.
+The Linux-only startup fixture and its command controls must be excluded at
+compile time on other platforms. A runtime platform skip cannot prevent the
+control-plane's Unix-only dependencies from breaking Windows installer checks.
+`TestProviderMSPStartupFixturesStayLinuxOnly` exercises Go's file-selection
+rules for Linux, Windows and macOS; cross-compilation of the complete installer
+test package must also succeed. This does not substitute for execution of the
+Windows lifecycle controls or macOS installer and logging checks on native CI.
+
## Canonical Files
1. `internal/updates/`
diff --git a/frontend-modern/src/features/docs/__tests__/agentTokenFileGuide.test.ts b/frontend-modern/src/features/docs/__tests__/agentTokenFileGuide.test.ts
index 73d72364e2..eeff5e1ae2 100644
--- a/frontend-modern/src/features/docs/__tests__/agentTokenFileGuide.test.ts
+++ b/frontend-modern/src/features/docs/__tests__/agentTokenFileGuide.test.ts
@@ -25,7 +25,9 @@ describe('agent token-file help in the shipped Markdown renderer', () => {
expect(link?.getAttribute('href')).toBe(`#${id}`);
expect(link?.hasAttribute('data-doc-link')).toBe(false);
expect(link?.hasAttribute('target')).toBe(false);
- expect(article.querySelector(`#${id}`)?.textContent).toBe('Token-file format is not shell syntax');
+ expect(article.querySelector(`#${id}`)?.textContent).toBe(
+ 'Token-file format is not shell syntax',
+ );
expect(guide).toBe(
readFileSync(path.join(repoRoot, 'frontend-modern/public/docs/UNIFIED_AGENT.md'), 'utf8'),
);
@@ -55,10 +57,15 @@ describe('agent token-file help in the shipped Markdown renderer', () => {
].entries()) {
expect(rows[index].textContent).toContain(phrase);
}
- const text = parts.map((element) => element.textContent).join(' ').replace(/\s+/g, ' ');
+ const text = parts
+ .map((element) => element.textContent)
+ .join(' ')
+ .replace(/\s+/g, ' ');
expect(text).toContain('not the value, length, hint, screenshot or file');
expect(text).toContain('Do not print, source, upload or edit the installed token file');
expect(text).toContain('not proof of accepted reporting');
- expect(parts.some((element) => element.matches('pre') || element.querySelector('pre'))).toBe(false);
+ expect(parts.some((element) => element.matches('pre') || element.querySelector('pre'))).toBe(
+ false,
+ );
});
});
diff --git a/frontend-modern/src/features/docs/__tests__/alertOffFAQ.test.ts b/frontend-modern/src/features/docs/__tests__/alertOffFAQ.test.ts
index 75c24c7492..e481b4523e 100644
--- a/frontend-modern/src/features/docs/__tests__/alertOffFAQ.test.ts
+++ b/frontend-modern/src/features/docs/__tests__/alertOffFAQ.test.ts
@@ -5,7 +5,8 @@ import { describe, expect, it } from 'vitest';
import { renderDocMarkdown } from '../docMarkdown';
const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../../../../..');
-const guide = (name: string): string => readFileSync(path.join(root, 'frontend-modern/public/docs', `${name}.md`), 'utf8');
+const guide = (name: string): string =>
+ readFileSync(path.join(root, 'frontend-modern/public/docs', `${name}.md`), 'utf8');
const article = (name: string): HTMLElement => {
const element = document.createElement('article');
element.innerHTML = renderDocMarkdown(guide(name), name);
@@ -15,7 +16,11 @@ const section = (): HTMLElement => {
const heading = article('FAQ').querySelector('#can-i-disable-alerts-for-specific-metrics');
expect(heading).not.toBeNull();
const element = document.createElement('section');
- for (let next = heading!.nextElementSibling; next && !/^H[1-6]$/.test(next.tagName); next = next.nextElementSibling) {
+ for (
+ let next = heading!.nextElementSibling;
+ next && !/^H[1-6]$/.test(next.tagName);
+ next = next.nextElementSibling
+ ) {
element.appendChild(next.cloneNode(true));
}
return element;
@@ -28,11 +33,14 @@ describe('shipped alert Off FAQ', () => {
expect(text).toContain('not every default has a per-resource control');
expect(text).toContain('save, then reopen the editor');
expect(element.querySelectorAll('li')).toHaveLength(4);
- for (const phrase of ['does not hide its readings, stop collection',
- 'explicit threshold can remain active', 'Already queued notifications',
+ for (const phrase of [
+ 'does not hide its readings, stop collection',
+ 'explicit threshold can remain active',
+ 'Already queued notifications',
'Patrol findings are separate from threshold alerts',
'when the corresponding alert default is Off',
- 'Do not induce an alert, send another Test or retry the queue']) {
+ 'Do not induce an alert, send another Test or retry the queue',
+ ]) {
expect(text).toContain(phrase);
}
expect(element.querySelector('pre')).toBeNull();
@@ -42,7 +50,10 @@ describe('shipped alert Off FAQ', () => {
it('routes the two independent warning paths to real shipped headings', () => {
const links = [...section().querySelectorAll('a')];
expect(links).toHaveLength(2);
- expect(links.map((link) => link.textContent)).toEqual(['how Patrol works', 'ordinary notification checks']);
+ expect(links.map((link) => link.textContent)).toEqual([
+ 'how Patrol works',
+ 'ordinary notification checks',
+ ]);
for (const link of links) {
const [name, fragment] = link.getAttribute('href')!.replace('/docs/', '').split('#');
expect(article(name).querySelector(`#${fragment}`)).not.toBeNull();
diff --git a/frontend-modern/src/utils/__tests__/docsLinks.test.ts b/frontend-modern/src/utils/__tests__/docsLinks.test.ts
index 729b1c65b8..411703e438 100644
--- a/frontend-modern/src/utils/__tests__/docsLinks.test.ts
+++ b/frontend-modern/src/utils/__tests__/docsLinks.test.ts
@@ -657,9 +657,7 @@ describe('docsLinks', () => {
/if !reportCallerMayUseAI\(ctx\) \{\s*return nil, nil, h\.resolveExistingFindings\(ctx\)\s*\}\s*return h\.narratorResolver\(ctx\)/,
);
expect(resolver.match(/h\.narratorResolver\(/g)).toHaveLength(1);
- expect(fleet).toMatch(
- /_, fleetNarrator, findings := h\.resolveNarrator\(ctx\)/,
- );
+ expect(fleet).toMatch(/_, fleetNarrator, findings := h\.resolveNarrator\(ctx\)/);
expect(fleet.match(/h\.resolveNarrator\(/g)).toHaveLength(1);
});
diff --git a/scripts/installtests/provider_msp_startup_command_test.go b/scripts/installtests/provider_msp_startup_command_test.go
index f17834258b..5d99adde72 100644
--- a/scripts/installtests/provider_msp_startup_command_test.go
+++ b/scripts/installtests/provider_msp_startup_command_test.go
@@ -1,13 +1,34 @@
+//go:build linux
+
package installtests
import (
"fmt"
+ "go/build"
"os"
"os/exec"
"strings"
"testing"
)
+func TestProviderMSPStartupFixturesStayLinuxOnly(t *testing.T) {
+ for _, platform := range []string{"linux", "windows", "darwin"} {
+ for _, name := range []string{"provider_msp_startup_test.go", "provider_msp_startup_command_test.go"} {
+ t.Run(platform+"/"+name, func(t *testing.T) {
+ ctx := build.Default
+ ctx.GOOS, ctx.GOARCH = platform, "amd64"
+ included, err := ctx.MatchFile(repoFile("scripts", "installtests"), name)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if included != (platform == "linux") {
+ t.Fatalf("%s fixture inclusion on %s is %v, want %v", name, platform, included, platform == "linux")
+ }
+ })
+ }
+ }
+}
+
// Exercise the real command helper with separate child-process output streams.
// Compose emits unset-variable warnings on stderr even when a read succeeds.
func TestProviderMSPStartupCommandReadbackSeparatesStderr(t *testing.T) {
diff --git a/scripts/installtests/provider_msp_startup_test.go b/scripts/installtests/provider_msp_startup_test.go
index 1c968faf29..212e6113cd 100644
--- a/scripts/installtests/provider_msp_startup_test.go
+++ b/scripts/installtests/provider_msp_startup_test.go
@@ -1,3 +1,5 @@
+//go:build linux
+
package installtests
import (