Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Let backup health counts filter Coverage to their workloads

rcourtman00d48b2e3049
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index eaf7f1fa6c..9df1eea1fd 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -8453,6 +8453,15 @@ ZFS dataset table rows inside `StoragePoolDetail` inherit their separator from
the shared `STORAGE_DETAIL_ROW_CLASS` presentation constant. The component
must not reintroduce a raw border-token class for dataset rows.
+### Coverage strip segments can be filter toggles
+
+`ProxmoxBackupsCoverageStrip` segments may carry `onSelect` and `pressed`.
+Such a segment renders as a bordered toggle button with `aria-pressed`, 28px
+tall below `sm` and 24px from `sm`, with the segment's count and label as
+its accessible name (the colour dot is decorative); segments without
+`onSelect` stay plain legend text. The strip owns no filter state; its
+caller decides which segments map to a filter.
+
### The settings nav gates Infrastructure, and the blocked-route fallback is capability-aware
`infrastructure-systems` now declares `requiredCapability: 'infrastructureRead'`
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 0a2cd1ebf4..21a3c10256 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -3277,6 +3277,26 @@ presentation and sort change only; it adds no backup, restore, or retention
authority. Pinned by `proxmoxBackupRecoveryModel.test.ts` and
`ProxmoxCoverageTable.test.tsx`.
+### Backup health counts filter Coverage to their workloads
+
+The Backups health strip's protected, attention, unprotected and unknown
+counts are toggles for the Coverage posture filter (`?posture=`), the same
+URL state the inline posture pills and the phone Filters sheet set. In
+Coverage a count toggles that filter; from By date it opens Coverage already
+filtered, through the same view path the tabs use, so date-only facets drop
+and scope facets stay. On the bare Backups route, where Coverage was chosen
+only because something needs attention, a count also navigates to the
+Coverage route so the view cannot fall back to By date when the counts
+change. The legend keeps each item's node across updates, so a focused count
+that stays a button keeps focus when it toggles. A zero count stays text
+unless it is the active filter, and checking and not-evaluated have no
+filter, so they stay text. On a 375px phone the coverage list starts below
+the fold and the posture filter sits behind Filters, so "which 11 are
+unprotected?" took three taps through a sheet; it is now one tap on the
+count. The rule footnote, the posture sort (attention before unprotected)
+and the servers table are unchanged, and no posture, freshness or protection
+evaluation changes.
+
### Backup table values truncate inside their own column
The coverage Node cell, the restore-evidence Location and Details cells, and
diff --git a/frontend-modern/browser-verification/bd4f5b6bd86ad00f.json b/frontend-modern/browser-verification/bd4f5b6bd86ad00f.json
new file mode 100644
index 0000000000..87fb8b731a
--- /dev/null
+++ b/frontend-modern/browser-verification/bd4f5b6bd86ad00f.json
@@ -0,0 +1,41 @@
+{
+ "version": 1,
+ "base_sha": "f9f27d67212a47a6769959862a7259606e86f56b",
+ "verified_at": "2026-10-12T00:45:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx",
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx": "7e4a2e662764a7dddcad23db1f9c44d3fc71bffdae78f48f84c907783d7516e1",
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx": "53c800bcbbd1c4e623089ba60c18d58e33be37d0ea030527639715fa7c0c08cd"
+ },
+ "routes": [
+ "/proxmox/backups/coverage",
+ "/proxmox/backups/date"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 900
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "embedded production build of origin/main plus this change, private mock stack (PULSE_MOCK_MODE, 8 nodes, 69 backup targets), compared with an unchanged origin/main build",
+ "375px phone before: coverage list header at y=759 of 812, Backup health counts are plain text, posture filter only behind the Filters sheet",
+ "375px phone after: protected, attention, unprotected and unknown counts render as bordered toggle buttons 28px tall; 0 checking and 3 not evaluated stay text",
+ "1440px desktop: the same counts render as 24px bordered pills beside the bar; inline posture pills unchanged below",
+ "light and dark colour schemes; pressed count shows a blue border and fill",
+ "deep link /proxmox/backups/coverage?posture=attention renders the 17 attention count pressed",
+ "no console errors"
+ ],
+ "interactions": [
+ "375px, By date view: real tap on 11 unprotected navigates to /proxmox/backups/coverage?posture=unprotected and the list shows exactly the 11 unprotected workloads; the pill reads pressed and the Filters badge shows 1",
+ "375px, Coverage: tapping the pressed count clears ?posture and the full list returns"
+ ]
+}
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx
index 03fa2675f4..472dd9496a 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx
@@ -1,4 +1,4 @@
-import { For, Show, type Component, type JSX } from 'solid-js';
+import { For, Index, Show, type Component, type JSX } from 'solid-js';
// A single horizontal bar broken into proportional segments, followed by
// a one-line legend of labels + counts. Visually integrated with the page
@@ -17,6 +17,10 @@ export interface CoverageStripSegment {
display?: string;
// When true the segment is rendered with a neutral tone for "absent".
muted?: boolean;
+ // A segment that names a list filter is a toggle: selecting "11
+ // unprotected" shows those workloads instead of leaving the count as text.
+ onSelect?: () => void;
+ pressed?: boolean;
}
export interface CoverageStripProps {
@@ -68,20 +72,48 @@ export const ProxmoxBackupsCoverageStrip: Component<CoverageStripProps> = (props
</For>
</div>
</Show>
- <ul class="mt-1.5 flex flex-wrap gap-x-3 gap-y-0.5 text-[11px]">
- <For each={props.segments}>
- {(segment) => (
- <li
- class={`inline-flex items-center gap-1.5 ${segment.muted ? '' : 'text-base-content'}`}
- >
- <span class={`h-2 w-2 shrink-0 rounded-xs ${segment.toneClass}`} aria-hidden="true" />
- <span class="tabular-nums">
- {segment.display ?? String(Math.max(0, Math.round(segment.value)))}
- </span>
- <span class="text-muted">{segment.label}</span>
- </li>
- )}
- </For>
+ <ul class="mt-1.5 flex flex-wrap items-center gap-x-2 gap-y-1 text-[11px]">
+ {/* Index keeps each legend item's node while the caller rebuilds the
+ segment objects, so a focused count keeps focus after it toggles. */}
+ <Index each={props.segments}>
+ {(segment) => {
+ const content = () => (
+ <>
+ <span
+ class={`h-2 w-2 shrink-0 rounded-xs ${segment().toneClass}`}
+ aria-hidden="true"
+ />
+ <span class="tabular-nums">
+ {segment().display ?? String(Math.max(0, Math.round(segment().value)))}
+ </span>
+ <span class="text-muted">{segment().label}</span>
+ </>
+ );
+ return (
+ <li class={`inline-flex items-center ${segment().muted ? '' : 'text-base-content'}`}>
+ <Show
+ when={segment().onSelect}
+ fallback={<span class="inline-flex items-center gap-1.5">{content()}</span>}
+ >
+ {(onSelect) => (
+ <button
+ type="button"
+ class={`inline-flex min-h-7 items-center gap-1.5 rounded-md border px-1.5 hover:bg-surface-hover focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-blue-500 sm:min-h-6 ${
+ segment().pressed
+ ? 'border-blue-400 bg-blue-50 dark:border-blue-500 dark:bg-blue-900/30'
+ : 'border-border'
+ }`}
+ aria-pressed={segment().pressed ?? false}
+ onClick={() => onSelect()()}
+ >
+ {content()}
+ </button>
+ )}
+ </Show>
+ </li>
+ );
+ }}
+ </Index>
</ul>
<Show when={props.footnote}>
<p class="mt-1.5 text-[11px] leading-4 text-muted" data-coverage-strip-footnote>
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
index 46fe97c5a1..aeb2085371 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
@@ -1,6 +1,6 @@
import { For, Show, createMemo, createSignal, type Component, type JSX } from 'solid-js';
import ChevronRightIcon from 'lucide-solid/icons/chevron-right';
-import { useLocation, useSearchParams } from '@solidjs/router';
+import { useLocation, useNavigate, useSearchParams } from '@solidjs/router';
import { FilterBar, type FilterDef, type FilterSelectOption } from '@/components/shared/FilterBar';
import { useBreakpoint } from '@/hooks/useBreakpoint';
import { useProtectionPostures } from '@/hooks/useProtectionPostures';
@@ -467,6 +467,30 @@ export const ProxmoxBackupsTable: Component<{
const query = params.toString();
return `${buildProxmoxBackupsPath(next)}${query ? `?${query}` : ''}`;
};
+ // The health strip's counts that name a posture filter toggle it. From the
+ // date view a count opens Coverage already filtered to those workloads.
+ const navigate = useNavigate();
+ const postureSegmentFilter = (posture: Exclude<CoverageFilterValue, 'all'>) => {
+ const pressed = view() === 'coverage' && coverageFilter() === posture;
+ // A zero count would only open an empty list.
+ if (!pressed && liveHealthSummary()[posture] === 0) return {};
+ return {
+ pressed,
+ onSelect: () => {
+ const next = coverageFilter() === posture && view() === 'coverage' ? 'all' : posture;
+ if (routeView() === 'coverage') {
+ setCoverageFilter(next);
+ return;
+ }
+ // By date, or Coverage chosen only by the health fallback: land on the
+ // Coverage route so the view cannot flip back when the counts change.
+ const target = new URL(backupViewPath('coverage'), 'https://pulse.invalid');
+ if (next === 'all') target.searchParams.delete(PROXMOX_BACKUPS_QUERY_PARAMS.posture);
+ else target.searchParams.set(PROXMOX_BACKUPS_QUERY_PARAMS.posture, next);
+ navigate(`${target.pathname}${target.search}`);
+ },
+ };
+ };
const backupViewTabs = createMemo(() =>
BACKUP_VIEW_TABS.map((tab) => ({ ...tab, path: backupViewPath(tab.id) })),
);
@@ -738,12 +762,14 @@ export const ProxmoxBackupsTable: Component<{
{
key: 'protected',
value: liveHealthSummary().protected,
+ ...postureSegmentFilter('protected'),
label: 'protected',
toneClass: 'bg-emerald-500',
},
{
key: 'attention',
value: liveHealthSummary().attention,
+ ...postureSegmentFilter('attention'),
label: 'attention',
toneClass: 'bg-amber-500',
muted: liveHealthSummary().attention === 0,
@@ -751,6 +777,7 @@ export const ProxmoxBackupsTable: Component<{
{
key: 'unprotected',
value: liveHealthSummary().unprotected,
+ ...postureSegmentFilter('unprotected'),
label: 'unprotected',
toneClass: 'bg-red-500',
muted: liveHealthSummary().unprotected === 0,
@@ -758,6 +785,7 @@ export const ProxmoxBackupsTable: Component<{
{
key: 'unknown',
value: liveHealthSummary().unknown,
+ ...postureSegmentFilter('unknown'),
label: 'unknown',
toneClass: 'bg-slate-400',
muted: liveHealthSummary().unknown === 0,
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 4627cdf772..2841bd95cc 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -572,6 +572,62 @@ describe('ProxmoxBackupsTable', () => {
});
});
+ it('lets a backup health count filter Coverage to those workloads', async () => {
+ // "17 attention" was text: finding which workloads it counted took the
+ // Filters sheet on a phone.
+ mockBackupAPIs('attention');
+ window.history.replaceState({}, '', '/proxmox/backups/date');
+
+ renderInRouter(() => (
+ <ProxmoxBackupsTable emptyIcon={<span />} workloads={[workloadResource]} />
+ ));
+
+ const attention = await screen.findByRole('button', { name: '1 attention' });
+ expect(attention).toHaveAttribute('aria-pressed', 'false');
+ // A zero count would open an empty list, so it stays text.
+ expect(screen.queryByRole('button', { name: '0 unprotected' })).toBeNull();
+ expect(screen.getByText('unprotected')).toBeInTheDocument();
+
+ await fireEvent.click(attention);
+ await waitFor(() => {
+ expect(window.location.pathname).toBe('/proxmox/backups/coverage');
+ expect(new URLSearchParams(window.location.search).get('posture')).toBe('attention');
+ });
+ expect(screen.getByRole('button', { name: '1 attention' })).toHaveAttribute(
+ 'aria-pressed',
+ 'true',
+ );
+ expect(screen.getAllByText('pbs-docker').length).toBeGreaterThan(0);
+
+ // Toggling off keeps the same focused control rather than rebuilding it.
+ const pressed = screen.getByRole('button', { name: '1 attention' });
+ pressed.focus();
+ await fireEvent.click(pressed);
+ await waitFor(() =>
+ expect(new URLSearchParams(window.location.search).get('posture')).toBeNull(),
+ );
+ expect(window.location.pathname).toBe('/proxmox/backups/coverage');
+ expect(pressed).toHaveAttribute('aria-pressed', 'false');
+ expect(pressed).toHaveFocus();
+ });
+
+ it('pins Coverage when a health count is used on the bare Backups route', async () => {
+ // Coverage was chosen only because something needs attention; without the
+ // route segment the view would flip to By date once the counts reached zero.
+ mockBackupAPIs('attention');
+ window.history.replaceState({}, '', '/proxmox/backups');
+
+ renderInRouter(() => (
+ <ProxmoxBackupsTable emptyIcon={<span />} workloads={[workloadResource]} />
+ ));
+
+ await fireEvent.click(await screen.findByRole('button', { name: '1 attention' }));
+ await waitFor(() => {
+ expect(window.location.pathname).toBe('/proxmox/backups/coverage');
+ expect(new URLSearchParams(window.location.search).get('posture')).toBe('attention');
+ });
+ });
+
it('switches to Coverage showing posture, and keeps per-source evidence in the row expansion', async () => {
mockBackupAPIs();