Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep invalid disk capacity out of current byte facts

pulse-triage[bot]09754113c0a4
diff --git a/frontend-modern/src/components/Workloads/GuestDrawerOverview.tsx b/frontend-modern/src/components/Workloads/GuestDrawerOverview.tsx
index 8fea970dea..7439655c96 100644
--- a/frontend-modern/src/components/Workloads/GuestDrawerOverview.tsx
+++ b/frontend-modern/src/components/Workloads/GuestDrawerOverview.tsx
@@ -411,7 +411,9 @@ export function GuestDrawerOverview(props: GuestDrawerOverviewProps) {
const disk = props.guest.disk;
if (
!disk ||
- !((disk.total ?? 0) > 0) ||
+ typeof disk.total !== 'number' ||
+ !Number.isFinite(disk.total) ||
+ disk.total <= 0 ||
typeof disk.used !== 'number' ||
!Number.isFinite(disk.used) ||
disk.used < 0 ||
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.filesystem-provenance.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.filesystem-provenance.test.tsx
index 335136abca..66c9b05a8a 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.filesystem-provenance.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.filesystem-provenance.test.tsx
@@ -225,3 +225,18 @@ describe('filesystem details do not promote retained usage to current health', (
expect(within(filesystemRow()).getByRole('progressbar')).toHaveAttribute('aria-valuenow', '90');
});
});
+
+describe('independent aggregate percentages do not invent byte facts', () => {
+ it.each([Infinity, NaN, -1, 0])(
+ 'withholds invalid capacity %s even with a valid current percentage',
+ (total) => {
+ render(() => (
+ <GuestDrawerOverview
+ {...props(guest({ disk: { total, used: 50, usage: 50 }, disks: [] }))}
+ currentMetrics={{ disk: 50 }}
+ />
+ ));
+ expect(screen.queryByText(/of .*disk$/)).not.toBeInTheDocument();
+ },
+ );
+});