Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Preserve explicit filesystem disablement during deferred reads
pulse-triage[bot]0fd7768e9d13
diff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.mdindex 5f7c630e4f..7d9fc4f39e 100644--- a/docs/release-control/v6/internal/subsystems/alerts.md+++ b/docs/release-control/v6/internal/subsystems/alerts.md@@ -30,7 +30,8 @@ Existing incidents retain their last trusted value, occurrence, acknowledgement,observation time and lifecycle/delivery evidence until a current observationresumes evaluation. Successful current inventory still resolves removedfilesystems. Explicit disablement, suppression and stopped-guest behavior remain-effective independently of telemetry. Legacy unannotated memory and independent+effective independently of telemetry, including per-filesystem disable overrides+on retained identities. Legacy unannotated memory and independentcurrent PVE/Pulse-agent memory/disks keep their existing policy, even while QGAis deferred; current CPU and I/O continue to evaluate. Producers own freshness;no new age threshold, QGA request, payload, alert family or UI surface is added.diff --git a/internal/alerts/guest.go b/internal/alerts/guest.goindex 6bc19205af..25963829ef 100644--- a/internal/alerts/guest.go+++ b/internal/alerts/guest.go@@ -300,11 +300,9 @@ func (m *Manager) CheckGuest(guest any, instanceName string) {// Retained/failed filesystem evidence is useful to display, but neither// its values nor an empty result can establish a breach, recovery or disk- // removal. CPU/I/O and independent current memory were evaluated above;- // explicit suppression/disablement and stopped-guest handling stay earlier.- if snapshot.DiskUnavailable {- return- }+ // removal. CPU/I/O and independent current memory were evaluated above.+ // Still apply explicit per-filesystem disablement to retained identities;+ // this is operator policy, not recovery inferred from an old value.if len(disks) > 0 {seenDiskKeys := make(map[string]struct{})@@ -342,6 +340,12 @@ func (m *Manager) CheckGuest(guest any, instanceName string) {effectiveDiskThreshold = ensureHysteresisThreshold(diskOverride.Disk)}}+ if snapshot.DiskUnavailable {+ if effectiveDiskThreshold == nil || effectiveDiskThreshold.Trigger <= 0 {+ m.clearAlert(canonicalMetricStateID(perDiskResourceID, "disk"))+ }+ continue+ }log.Debug().Str("guest", name).@@ -387,11 +391,15 @@ func (m *Manager) CheckGuest(guest any, instanceName string) {MonitorOnly: monitorOnly,})}- if cleared := m.cleanupGuestDiskAlerts(guestID, seenDiskResources); cleared > 0 {- m.saveActiveAlertsAsync("guest-disk-set-changed")+ if !snapshot.DiskUnavailable {+ if cleared := m.cleanupGuestDiskAlerts(guestID, seenDiskResources); cleared > 0 {+ m.saveActiveAlertsAsync("guest-disk-set-changed")+ }+ }+ } else if !snapshot.DiskUnavailable {+ if cleared := m.cleanupGuestDiskAlerts(guestID, nil); cleared > 0 {+ m.saveActiveAlertsAsync("guest-disk-alerts-cleared")}- } else if cleared := m.cleanupGuestDiskAlerts(guestID, nil); cleared > 0 {- m.saveActiveAlertsAsync("guest-disk-alerts-cleared")}}diff --git a/internal/alerts/guest_snapshot_test.go b/internal/alerts/guest_snapshot_test.goindex 863dcec16a..2f89b24eda 100644--- a/internal/alerts/guest_snapshot_test.go+++ b/internal/alerts/guest_snapshot_test.go@@ -63,6 +63,28 @@ func TestGuestSnapshotObservationAvailability(t *testing.T) {}}+func TestGuestAlertRetainedDiskStillHonoursExplicitOverride(t *testing.T) {+ for _, override := range []ThresholdConfig{{Disabled: true}, {Disk: &HysteresisThreshold{Trigger: -1}}} {+ m := guestObservationManager(t)+ vm := guestObservationVM()+ vm.Memory.Usage = 10+ m.CheckGuest(vm, "site")+ if len(m.GetActiveAlerts()) != 2 {+ t.Fatal("expected two current filesystem incidents")+ }+ _, keySource, key := guestDiskIdentity(vm.Disks[0], 0)+ cfg := m.GetConfig()+ cfg.Overrides[guestDiskOverrideKey(vm, vm.ID, keySource)] = override+ m.UpdateConfig(cfg)+ vm.DiskStatusReason = "prev-vm-locked"+ m.CheckGuest(vm, "site")+ active := m.GetActiveAlerts()+ if len(active) != 1 || active[0].ResourceID == vm.ID+"-disk-"+key {+ t.Fatalf("explicit filesystem disablement was lost or crossed disk identity: %+v", active)+ }+ }+}+func TestGuestSnapshotUsesCanonicalProxmoxCPUPercent(t *testing.T) {for _, tc := range []struct {name string