Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Preserve local guest deadline uncertainty in diagnostics

pulse-triage[bot]10e5c39165bf
diff --git a/docs/release-control/v6/internal/subsystems/monitoring.md b/docs/release-control/v6/internal/subsystems/monitoring.md
index 819e0ae7b5..414f4dff78 100644
--- a/docs/release-control/v6/internal/subsystems/monitoring.md
+++ b/docs/release-control/v6/internal/subsystems/monitoring.md
@@ -240,6 +240,8 @@ An actual HTTP 401/403 leads only to checking the existing credential's access
to that VM. A stopped-agent reason requires exact command-bound rejection
evidence, not an HTTP 500 or a status/diagnosis quoted in provider text.
Unsupported commands remain errors without claiming that QGA is stopped.
+Untyped local timeout/deadline errors keep their conservative timeout reason;
+this diagnostic correction does not turn local uncertainty into recovery.
Deferrals retain their fixed reasons and do not gain new diagnostic commands.
`TestGuestFilesystemFailureGuidanceUsesObservedEvidence` crosses the real
client/collector/log boundary and preserves unavailable disk sentinels and
diff --git a/internal/monitoring/guest_disk_stability.go b/internal/monitoring/guest_disk_stability.go
index 9335800814..988020d128 100644
--- a/internal/monitoring/guest_disk_stability.go
+++ b/internal/monitoring/guest_disk_stability.go
@@ -32,7 +32,7 @@ func classifyGuestAgentDiskStatusError(err error) string {
switch {
case err.Error() == "QEMU guest agent is not running":
return "agent-not-running"
- case errors.Is(err, context.DeadlineExceeded) || strings.Contains(strings.ToLower(err.Error()), "timeout"):
+ case errors.Is(err, context.DeadlineExceeded) || strings.Contains(strings.ToLower(err.Error()), "timeout") || strings.Contains(strings.ToLower(err.Error()), "deadline exceeded"):
return "agent-timeout"
default:
return "agent-error"
diff --git a/internal/monitoring/monitor_pve_guest_lxc_test.go b/internal/monitoring/monitor_pve_guest_lxc_test.go
index 1d8beacbbf..57599819fc 100644
--- a/internal/monitoring/monitor_pve_guest_lxc_test.go
+++ b/internal/monitoring/monitor_pve_guest_lxc_test.go
@@ -593,6 +593,7 @@ func TestGuestFilesystemStatusDoesNotDiagnoseFromErrorText(t *testing.T) {
{context.DeadlineExceeded, "agent-timeout"},
{fmt.Errorf("wrapped: %w", context.DeadlineExceeded), "agent-timeout"},
{errors.New("guest agent request timeout"), "agent-timeout"},
+ {errors.New("guest agent request: context deadline exceeded"), "agent-timeout"},
}
for _, tc := range cases {
if got := classifyGuestAgentDiskStatusError(tc.err); got != tc.want {