Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Preserve reviewed monitoring repairs with upstream Discovery removal

pulse-triage[bot]123652e29bf2
diff --cc docs/release-control/v6/internal/subsystems/frontend-primitives.md
index fd47c81606,196f0c7ef5..783fff56fd
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@@ -4573,47 -4485,29 +4522,70 @@@ resolves late` i
## Current State
+### Retained monitoring status remains reactive (11 October 2026)
+
+The existing Machines status dot subscribes to the shared relative-time clock
+for the unchanged five-minute agent-report fallback, agreeing with the
+standalone classification helper without a new report, row timer or API read.
+Machines health chip counts and selected results now use that same classifier
+at the same clock instant rather than the canonical last-reported status.
+Healthy excludes warning/stale rows, Degraded includes them and Offline retains
+the existing danger precedence. Muted/unclassified rows stay in All only.
+The status dot tooltip and accessible name expose that same current label
+(Online, Stale or Offline), not an online tooltip on an amber retained row.
+The canonical status, stale flag and timestamps remain observations, not derived
+health. Search, route-owned selection and removal behaviour are unchanged.
+The shared FilterButtonGroup keys buttons by logical value rather than transient
+option-object identity. Count, label, disabled, icon and order updates keep the
+same focused button while its option survives; withdrawn keys retire normally.
+Numeric and string values stay distinct, and selection uses the current entry.
+FilterButtonGroup.test.tsx covers those replacement/reorder/removal boundaries;
+FilterToolbar.test.tsx covers the live segmented-control label projection and
+forwarded selection at the shared wrapper boundary;
+the Machines clock/selection control exercises the production toolbar on desktop
+and touch-phone browsers.
+Attention sort classifies once per resource per call, preserving priority and
+numeric-name ordering without keeping a cross-call status cache. Debug source
+summaries read current status/error/last-seen by section ID, not a record captured
+when a retained payload section first mounted. Disclosure, focus and payload
+remain owned by that section.
+
+The Machines, standalone model and Debug relative-age regression controls,
+plus `browser-tests/pr2600-monitoring.cjs` on desktop and touch-phone engines,
+cover clock-only staleness and arriving status replacement. These are
+synthetic source/presentation checks, not collector, workload recovery,
+whole-fleet performance, installed or release acceptance.
+`browser-tests/machines-health-filters.cjs` additionally covers expanded phone
+filters, exact freshness boundary, Healthy/Degraded clicks, arriving/withdrawn
+reports and preserved URL/search. The Proxmox identity and TrueNAS error guide
+checks still render the complete shipped guides through the production renderer;
+their per-suite fixture reuses only identical source/path renders, returns
+isolated clones and invalidates changed input. No renderer, guide bytes,
+assertions or test deadlines are weakened.
+
+ ### AI Discovery removed (2026-10-11)
+
+ AI Discovery, the model-backed service-identification layer, is gone. The
+ `internal/servicediscovery` store and scanner, `internal/ai/infradiscovery`,
+ the `pulse_discovery` Assistant/Patrol tool, the `/api/discovery*` routes, the
+ mock Discovery fixtures, the resource/guest/node/Docker drawer Discovery tabs,
+ identified-service cards, readiness badges, provenance markers, suggested
+ web-interface URLs, the Workloads AI Context column, the chat "Discovery is
+ off" hint and the AI Service Context settings page were all removed. No
+ telemetry counter ever measured its use (the `discovery_enabled` telemetry
+ field folded it together with network subnet discovery), the maintainer judged it a flop, and
+ it carried a separate scheduler, store and model route for context that
+ `pulse_query`, `pulse_read` and the unified-resource context sections already
+ supply.
+ Network subnet discovery (`internal/discovery`, `/api/discover`, the
+ Infrastructure discovery settings) and the `discoveryTarget` agent coordinates
+ are separate features and stay. Stored `discovery_enabled`,
+ `discovery_interval_hours` and `discovery_model` AI settings are ignored on
+ load. The old `/settings/pulse-intelligence/discovery` route redirects to
+ Assistant settings.
+
+ `DiscoveryLoadingFallback`, `DiscoveryReadinessBadge`, `DiscoveryProvenanceMarker` and the now-orphaned `CopyableCodeRow` were deleted with their registry rules; the drawer spinner guard now names `LoadingSpinner` as its canonical owner.
+
### Manual update freshness
The update panel has a dedicated proof route to `updatesPresentation.test.ts`,
diff --cc docs/release-control/v6/internal/subsystems/unified-resources.md
index 60b36ea782,4253782069..5cf8b2b85c
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@@ -3144,37 -3096,29 +3096,60 @@@ application resource-provider or WebSoc
## Current State
+### Retained Machines and Debug status (11 October 2026)
+
+The Machines row status, health chip counts and selected filter membership
+read the same existing classifier and shared clock. A held online agent is
+Degraded in the toolbar once its row becomes Stale under the unchanged five-minute
+fallback; clock ticks neither renew its report nor set its canonical stale flag.
+The row retains identity and metric values, and an actual report or offline
+status still updates its presentation and membership. Explicit warning/Unknown
+rows are Degraded, red rows are Offline, and unclassified muted rows remain
+visible in All without being promoted to Healthy or Offline. Search and the
+route-owned selected filter survive reclassification; no new posture card is
+added. Attention sorting classifies each input
+resource once per call, retains the priority/name order and never caches status
+across calls or mutates the input inventory.
+
+Debug source status, error and last-seen are reactive by section ID even when
+source payload sections stay mounted. New status records withdraw obsolete
+errors; absent/invalid timestamps do not acquire an age. Source payload,
+disclosure and focus survive status-only updates and quiet age ticks.
+
+Verification: the Machines table, standalone page-model and Debug relative-age
+tests cover the retained-row boundary, per-resource classification count,
+arriving/withdrawn reports, unknown/offline membership and ordinary source-status
+replacement. `browser-tests/machines-health-filters.cjs` compares chip counts,
+Healthy/Degraded clicks and selected results on the composed parent and final
+desktop/phone sources; `browser-tests/pr2600-monitoring.cjs`
+compares exact-parent and repaired production surfaces on desktop Chromium and
+touch-phone WebKit using synthetic local data. It establishes presentation,
+not a probe, guest thaw/writes/liveness/restoration, native collector recovery,
+whole-fleet CPU relief, publication or release availability.
+
+ ### AI Discovery removed (2026-10-11)
+
+ AI Discovery, the model-backed service-identification layer, is gone. The
+ `internal/servicediscovery` store and scanner, `internal/ai/infradiscovery`,
+ the `pulse_discovery` Assistant/Patrol tool, the `/api/discovery*` routes, the
+ mock Discovery fixtures, the resource/guest/node/Docker drawer Discovery tabs,
+ identified-service cards, readiness badges, provenance markers, suggested
+ web-interface URLs, the Workloads AI Context column, the chat "Discovery is
+ off" hint and the AI Service Context settings page were all removed. No
+ telemetry counter ever measured its use (the `discovery_enabled` telemetry
+ field folded it together with network subnet discovery), the maintainer judged it a flop, and
+ it carried a separate scheduler, store and model route for context that
+ `pulse_query`, `pulse_read` and the unified-resource context sections already
+ supply.
+ Network subnet discovery (`internal/discovery`, `/api/discover`, the
+ Infrastructure discovery settings) and the `discoveryTarget` agent coordinates
+ are separate features and stay. Stored `discovery_enabled`,
+ `discovery_interval_hours` and `discovery_model` AI settings are ignored on
+ load. The old `/settings/pulse-intelligence/discovery` route redirects to
+ Assistant settings.
+
+ `Resource.discoveryReadiness` and the agent resource-context `DiscoveryReadiness` field are gone; the agent context `Runtime` section keeps the `Target type/agent/resource/hostname` facts sourced from `discoveryTarget`.
+
### Interface-associated display addresses
VM and LXC projections retain the collector's interface-associated IP order in
diff --cc frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.snapshot.test.tsx
index 664a9b0e4e,755ec9913d..25603f651d
--- a/frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.snapshot.test.tsx
+++ b/frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.snapshot.test.tsx
@@@ -86,95 -77,6 +78,51 @@@ afterEach(() =>
});
describe('ResourceDetailDrawer snapshot ownership', () => {
+ it('ages unchanged observed and occurred times in the mounted change history', async () => {
+ const start = Date.parse('2026-10-11T11:00:00Z');
+ vi.useFakeTimers({ now: start });
+ const change = {
+ id: 'held-change',
+ resourceId: 'held-resource',
+ kind: 'config_update' as const,
+ observedAt: new Date(start - 60_000).toISOString(),
+ occurredAt: new Date(start - 120_000).toISOString(),
+ reason: 'Retained config observation',
+ sourceType: 'platform_event' as const,
+ confidence: 'high' as const,
+ };
+ const initial = snapshot({ id: 'held-resource', recentChanges: [change] });
+ const [resource, setResource] = createSignal(initial);
+ render(() => <ResourceDetailDrawer resource={resource()} presentation="table-row" />);
+ await vi.advanceTimersByTimeAsync(0);
+ const section = screen.getByTestId('resource-change-history-section');
+ expect(section).toHaveTextContent('1 min ago');
+ expect(section).toHaveTextContent('Occurred 2 mins ago');
+ fireEvent.click(within(section).getByRole('button', { name: /Filter/ }));
+ const filter = within(section).getByRole('combobox', { name: 'Change kind' });
+ filter.focus();
+ await vi.advanceTimersByTimeAsync(2 * 3_600_000);
+ expect(section).toHaveTextContent('2 hours ago');
+ expect(section).toHaveTextContent('Occurred 2 hours ago');
+ expect(filter).toHaveFocus();
+ expect(screen.getByTestId('resource-change-history-section')).toBe(section);
+ expect(resource().recentChanges).toEqual([change]);
+ expect(requests.facets).not.toHaveBeenCalled();
+ setResource({
+ ...initial,
+ recentChanges: [
+ { ...change, observedAt: new Date(Date.now()).toISOString(), occurredAt: undefined },
+ ],
+ });
+ expect(section).toHaveTextContent('0s ago');
+ expect(section).not.toHaveTextContent('Occurred');
+ await vi.advanceTimersByTimeAsync(60_000);
+ expect(section).toHaveTextContent('1 min ago');
+ setResource({ ...initial, recentChanges: [] });
+ await vi.advanceTimersByTimeAsync(30_000);
+ expect(screen.queryByText('Retained config observation')).not.toBeInTheDocument();
+ });
+
- it('withdraws former Discovery identification while a replacement source key is pending', async () => {
- let finish!: (value: unknown) => void;
- requests.discovery
- .mockResolvedValueOnce({ service_name: 'Old service', confidence: 0.9 })
- .mockReturnValueOnce(new Promise((resolve) => (finish = resolve)));
- const initial = snapshot({
- discoveryTarget: {
- resourceType: 'agent',
- agentId: 'agent-a',
- resourceId: 'agent-a',
- hostname: 'pbs-a',
- },
- });
- const [resource, setResource] = createSignal(initial);
- const Probe = () => {
- const state = useResourceDetailDrawerDerivedState({
- get resource() {
- return resource();
- },
- debugEnabled: () => false,
- discoveryFeatureEnabled: () => true,
- resourceIntelligence: () => null,
- });
- return (
- <span data-testid="identified-service">
- {state.discoveryIdentifiedSummary()?.serviceName}
- </span>
- );
- };
- render(() => <Probe />);
- await screen.findByText('Old service');
- setResource({
- ...initial,
- discoveryTarget: { ...initial.discoveryTarget!, agentId: 'agent-b', resourceId: 'agent-b' },
- });
- expect(screen.getByTestId('identified-service')).toBeEmptyDOMElement();
- await waitFor(() =>
- expect(requests.discovery).toHaveBeenLastCalledWith('agent', 'agent-b', 'agent-b'),
- );
- finish({ service_name: 'Current service', confidence: 0.9 });
- await screen.findByText('Current service');
- expect(screen.queryByText('Old service')).not.toBeInTheDocument();
- });
-
it('updates derived identity, current metrics and the History target without remounting a same-ID drawer', () => {
const [resource, setResource] = createSignal(snapshot());
render(() => <ResourceDetailDrawer resource={resource()} presentation="table-row" />);