Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Show the GitHub star prompt on the first return day

rcourtman1295d7eaf5e0
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 1511069f29..63aa066066 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -2486,8 +2486,8 @@ not a replacement status card, CTA band, or page-local nested card.
`frontend-modern/src/components/GitHubStarBanner.tsx` may own its display
timing, product copy, and GitHub destination, but its primary and dismiss
controls must compose `Button` and `ActionIconButton` instead of carrying
- local floating-prompt button shells. The prompt must wait for fourteen
- distinct active days with connected infrastructure, consume at most one
+ local floating-prompt button shells. The prompt must wait for the first
+ return on a later day with connected infrastructure, consume at most one
lifetime appearance, treat close as permanent dismissal, and never restore
recurring snooze behavior. It must yield the browser session to an existing
release, disclosure, or other low-priority app-shell notice and suppress
@@ -8611,8 +8611,8 @@ reintroduce a literal bar height. The declared `:root` value is a
pre-measurement fallback only and deliberately under-estimates: reserving more
than the bar's real height leaves a band between an overlay's backdrop and the
bar that is neither dimmed nor click-blocked, while reserving slightly less is
-covered by the opaque bar. Surfaces with their own placement at wider
-viewports, such as the star banner's `md:bottom-4`, keep it.
+covered by the opaque bar. The star banner follows the published height at
+every viewport with a small gap above the bar, without a breakpoint override.
Proofs live in `frontend-modern/src/components/shared/__tests__/MobileNavBar.test.tsx`,
`frontend-modern/src/components/__tests__/GitHubStarBanner.test.tsx`, and
diff --git a/frontend-modern/browser-verification/d37a00483422dfbb.json b/frontend-modern/browser-verification/d37a00483422dfbb.json
new file mode 100644
index 0000000000..7ee5bdb0c9
--- /dev/null
+++ b/frontend-modern/browser-verification/d37a00483422dfbb.json
@@ -0,0 +1,48 @@
+{
+ "version": 1,
+ "base_sha": "acd1e4e31d666f663b1e25c7da051dee1b860af9",
+ "verified_at": "2026-10-12T18:19:33Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/GitHubStarBanner.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/GitHubStarBanner.tsx": "f76b21df105bc9db71a9e0102acd35549f03dfb359b5fae6bf527bcf505e2585"
+ },
+ "routes": [
+ "/proxmox/overview"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 900
+ },
+ {
+ "width": 800,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "First connected day and same-day reload without a prompt",
+ "First return on a later day with connected infrastructure",
+ "Existing engagement below the former fourteen-day threshold",
+ "Previously shown and permanently dismissed prompts",
+ "Competing release notice owns the session",
+ "Command palette open and closed after a visible prompt",
+ "Scripted empty, loading and unavailable infrastructure states"
+ ],
+ "interactions": [
+ "Inspect actual prompt pixels, wrapping, button focus and navigation clearance at all three widths",
+ "Hover and focus the star button and dismiss control",
+ "Outside click and Escape retain the non-modal prompt",
+ "Activate permanent dismissal with the keyboard and reload",
+ "Open the repository in a new tab and verify permanent dismissal after reload",
+ "Open the command palette, inspect its placement, close with Escape and verify focus returns to search while the prompt remains suppressed"
+ ],
+ "command": "Playwright Chromium against an isolated current-main Vite server on pulse-dev, proxying the shared development API.",
+ "notes": "The browser-local date/storage fixtures exercise engagement and prior dismissal. Empty/loading/error cases script the state transport. No backend configuration changes were needed. The final source hash matches the qualified worker snapshot."
+}
diff --git a/frontend-modern/src/components/GitHubStarBanner.tsx b/frontend-modern/src/components/GitHubStarBanner.tsx
index b189f194f2..c614910940 100644
--- a/frontend-modern/src/components/GitHubStarBanner.tsx
+++ b/frontend-modern/src/components/GitHubStarBanner.tsx
@@ -14,7 +14,7 @@ import StarIcon from 'lucide-solid/icons/star';
import XIcon from 'lucide-solid/icons/x';
const GITHUB_REPO_URL = 'https://github.com/rcourtman/Pulse';
-const ACTIVE_DAYS_BEFORE_PROMPT = 14;
+const ACTIVE_DAYS_BEFORE_PROMPT = 2;
function getTodayDateString(): string {
return new Date().toISOString().split('T')[0]; // YYYY-MM-DD
@@ -49,16 +49,14 @@ export function GitHubStarBanner() {
const [showPrompt, setShowPrompt] = createSignal(false);
let blockedByDialogThisSession = false;
- // Count distinct days with connected infrastructure, then offer one quiet
- // prompt only when the rest of the app shell has yielded the session.
+ // The first connected day establishes use. On the first return day, offer
+ // one quiet prompt only when the rest of the app shell has yielded the session.
createEffect(() => {
if (dismissed()) {
setShowPrompt(false);
return;
}
- if (promptShown()) return;
-
if (dialogStackHasBlockingDialog()) {
blockedByDialogThisSession = true;
setShowPrompt(false);
@@ -66,6 +64,7 @@ export function GitHubStarBanner() {
}
if (blockedByDialogThisSession) return;
+ if (promptShown()) return;
if (!initialDataReceived()) {
setShowPrompt(false);
@@ -108,7 +107,7 @@ export function GitHubStarBanner() {
return (
<Show when={showPrompt()}>
<section
- class="fixed left-4 right-20 bottom-(--pulse-mobile-nav-height) z-30 max-w-sm overflow-hidden rounded-lg border border-border bg-surface text-base-content shadow-lg md:right-auto md:bottom-4"
+ class="fixed left-4 right-20 bottom-(--pulse-mobile-nav-height) mb-4 z-30 max-w-sm overflow-hidden rounded-lg border border-border bg-surface text-base-content shadow-lg md:right-auto"
aria-labelledby="github-star-title"
aria-live="polite"
>
diff --git a/frontend-modern/src/components/__tests__/GitHubStarBanner.test.tsx b/frontend-modern/src/components/__tests__/GitHubStarBanner.test.tsx
index 1f18b93658..cca6f3f4ab 100644
--- a/frontend-modern/src/components/__tests__/GitHubStarBanner.test.tsx
+++ b/frontend-modern/src/components/__tests__/GitHubStarBanner.test.tsx
@@ -1,5 +1,6 @@
import { cleanup, fireEvent, render, screen, waitFor } from '@solidjs/testing-library';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { createSignal } from 'solid-js';
import gitHubStarBannerSource from '../GitHubStarBanner.tsx?raw';
type BannerResource = { id: string; name: string };
@@ -41,7 +42,7 @@ function setResourceCount(count: number) {
}
function seedEligibleEngagement() {
- localStorage.setItem(ACTIVE_DAYS_KEY, '13');
+ localStorage.setItem(ACTIVE_DAYS_KEY, '1');
localStorage.setItem(LAST_ACTIVE_DATE_KEY, '2026-03-13');
}
@@ -89,17 +90,17 @@ describe('GitHubStarBanner', () => {
});
it('does not count repeated sessions on the same day', async () => {
- localStorage.setItem(ACTIVE_DAYS_KEY, '7');
+ localStorage.setItem(ACTIVE_DAYS_KEY, '1');
localStorage.setItem(LAST_ACTIVE_DATE_KEY, '2026-03-14');
setResourceCount(3);
await renderBanner();
- expect(localStorage.getItem(ACTIVE_DAYS_KEY)).toBe('7');
+ expect(localStorage.getItem(ACTIVE_DAYS_KEY)).toBe('1');
expect(screen.queryByText('Finding Pulse useful?')).not.toBeInTheDocument();
});
- it('shows one compact prompt after fourteen distinct active days', async () => {
+ it('shows one compact prompt on the first return day with connected infrastructure', async () => {
seedEligibleEngagement();
setResourceCount(3);
@@ -113,13 +114,13 @@ describe('GitHubStarBanner', () => {
).toBeInTheDocument();
expect(screen.getByText('Star on GitHub')).toBeInTheDocument();
expect(screen.queryByText('Maybe later')).not.toBeInTheDocument();
- expect(localStorage.getItem(ACTIVE_DAYS_KEY)).toBe('14');
+ expect(localStorage.getItem(ACTIVE_DAYS_KEY)).toBe('2');
expect(localStorage.getItem(PROMPT_SHOWN_KEY)).toBe('true');
});
it('never reopens after its single lifetime appearance', async () => {
localStorage.setItem(PROMPT_SHOWN_KEY, 'true');
- localStorage.setItem(ACTIVE_DAYS_KEY, '14');
+ localStorage.setItem(ACTIVE_DAYS_KEY, '2');
localStorage.setItem(LAST_ACTIVE_DATE_KEY, '2026-03-13');
setResourceCount(3);
@@ -135,7 +136,7 @@ describe('GitHubStarBanner', () => {
await renderBanner();
- await waitFor(() => expect(localStorage.getItem(ACTIVE_DAYS_KEY)).toBe('14'));
+ await waitFor(() => expect(localStorage.getItem(ACTIVE_DAYS_KEY)).toBe('2'));
expect(screen.queryByText('Finding Pulse useful?')).not.toBeInTheDocument();
expect(localStorage.getItem(PROMPT_SHOWN_KEY)).not.toBe('true');
});
@@ -153,6 +154,43 @@ describe('GitHubStarBanner', () => {
expect(screen.queryByText('Finding Pulse useful?')).not.toBeInTheDocument();
});
expect(localStorage.getItem(DISMISSED_KEY)).toBe('true');
+
+ cleanup();
+ sessionStorage.clear();
+ vi.setSystemTime(new Date('2026-03-15T12:00:00Z'));
+ await renderBanner();
+
+ expect(screen.queryByText('Finding Pulse useful?')).not.toBeInTheDocument();
+ });
+
+ it('yields a visible prompt to a blocking dialog for the rest of the session', async () => {
+ seedEligibleEngagement();
+ setResourceCount(3);
+ const { GitHubStarBanner } = await import('../GitHubStarBanner');
+ const { Dialog } = await import('../shared/Dialog');
+ let openDialog = () => {};
+
+ render(() => {
+ const [isOpen, setIsOpen] = createSignal(false);
+ openDialog = () => setIsOpen(true);
+ return (
+ <>
+ <GitHubStarBanner />
+ <Dialog isOpen={isOpen()} onClose={() => setIsOpen(false)} ariaLabel="Test dialog">
+ <button>Dialog action</button>
+ </Dialog>
+ </>
+ );
+ });
+
+ await waitFor(() => expect(screen.getByText('Finding Pulse useful?')).toBeInTheDocument());
+ openDialog();
+ await waitFor(() => expect(screen.getByRole('dialog')).toBeInTheDocument());
+ expect(screen.queryByText('Finding Pulse useful?')).not.toBeInTheDocument();
+
+ fireEvent.keyDown(document, { key: 'Escape' });
+ await waitFor(() => expect(screen.queryByRole('dialog')).not.toBeInTheDocument());
+ expect(screen.queryByText('Finding Pulse useful?')).not.toBeInTheDocument();
});
it('opens GitHub and permanently dismisses on the star action', async () => {
@@ -201,8 +239,4 @@ describe('GitHubStarBanner mobile navigation clearance', () => {
it('does not keep its own copy of the bar height', () => {
expect(gitHubStarBannerSource).not.toMatch(/5rem\s*\+\s*env\(safe-area-inset-bottom/);
});
-
- it('keeps its own desktop placement once the bar is gone', () => {
- expect(gitHubStarBannerSource).toContain('md:bottom-4');
- });
});
diff --git a/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts b/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts
index 57228c6792..8c6211f907 100644
--- a/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts
+++ b/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts
@@ -5080,7 +5080,6 @@ describe('shared primitive guardrails', () => {
expect(gitHubStarBannerSource).toContain('@/components/shared/Button');
expect(gitHubStarBannerSource).toContain('<ActionIconButton');
expect(gitHubStarBannerSource).toContain('<Button');
- expect(gitHubStarBannerSource).toContain('const ACTIVE_DAYS_BEFORE_PROMPT = 14;');
expect(gitHubStarBannerSource).toContain("reserveLowPriorityNoticeSession('github-star')");
expect(gitHubStarBannerSource).toContain('GITHUB_STAR_PROMPT_SHOWN');
expect(gitHubStarBannerSource).not.toContain('Maybe later');