Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep missing workload backup evidence unknown

pulse-triage[bot]12e7150d4b4d
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 85ca0ccf66..fb4da70898 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -20,6 +20,27 @@
## Purpose
+### Missing Workloads completion times do not establish absence
+
+The workload badge, compact shield, hover/dialog and full drawer treat absent
+completion-time sentinels as missing current-inventory evidence, not proof that
+no backup exists or that a running backup is the first. The legacy `never` key
+stays internal; visible absence is cautionary Unknown and “No completed backup
+reported”, with no invented date or age-rule link. The disclosure states that
+missing data does not mean no backups exist. Known valid ages, invalid/future
+time reasons, blue running activity, platform/template gating and independent
+guest-read/thaw precautions are unchanged. No read, timer, policy, identity,
+guest, backup or restore operation is added.
+
+`backupTimestampFlow.test.tsx` drives missing/empty/Go-zero observations through
+the real REST and owning-snapshot mapper into badge, shield and full drawer for
+VM/LXC, including activity, recovery/recurrence and retained dialog/focus.
+Existing cell, drawer, shared-clock and guest-row tests pin the accessible
+wording, warning tone and separate safety evidence. Desktop/narrow browser
+proof must inspect real production rows and their consuming disclosures, not
+just helpers. This is truthful inspection, not original protection causality,
+native thaw, restore readiness, installed recovery or release availability.
+
### Backup read recovery retains keyboard position
PVE, PBS and protection-posture retries remain focusable while pending, report
@@ -3186,10 +3207,11 @@ not a replacement status card, CTA band, or page-local nested card.
`frontend-modern/src/utils/workloadGuestPresentation.ts` owns the canonical
tone and icon mapping consumed by workload rows and drawers. A recorded
backup may be green or amber according to the configured freshness
- thresholds, but age alone must not produce a red failure treatment. Red is
- reserved for the materially different `never` state where no backup has
- been recorded; unsupported workloads and templates remain neutral rather
- than being classified as unprotected.
+ thresholds, but age alone must not produce a red failure treatment. The legacy
+ `never` key means no completion time reported in current inventory: show
+ cautionary Unknown, not a red no-backup verdict or an all-time absence
+ claim. Unsupported workloads and templates remain neutral rather than
+ being classified as unprotected.
Inline detail content belongs to the shared detail-section primitive family.
Feature surfaces may own the platform-specific rows, section labels, and
source model, but section row shaping, empty-row compaction, value tone
diff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index 7c315b07a6..67605e1536 100644
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@ -15,6 +15,23 @@
## Purpose
+### Missing backup completion remains a presentation-only uncertainty
+
+Workloads keeps its existing scalar and legacy absence classification, but
+shows the badge/shield and drawer in cautionary Unknown rather than a red
+no-backup state. All-time absence and “first backup” cannot be inferred from
+the current inventory. Missing observations supply no exact time, age rule or
+completion when activity ends. Valid ages, malformed/future reasons and guest
+safety precautions retain their existing meaning. This adds no request, join,
+clock, parse loop or collection work to the hot path.
+
+The normal-suite REST/snapshot `backupTimestampFlow.test.tsx` regressions cover
+VM/LXC missing and Go-zero input, running/stopped activity, valid recovery and
+missing recurrence while preserving mounted details/focus. Shared presentation,
+cell, full-drawer and clock tests cover the remaining consumers. Desktop/narrow
+production-row browser proof is separate from source results and establishes
+no native guest, backup, restore or installed recovery.
+
### Workloads maps backup instants once per resource update
The REST and owning-snapshot adapters use the shared strict backup timestamp
@@ -1451,12 +1468,13 @@ change may globally weaken the Task 03 lifecycle-state idempotency invariant.
provider-specific backup fetches belong in the shared workload hot path.
Freshness classification must reuse the configured backup thresholds and
the shared `getBackupInfo` / `workloadGuestPresentation` vocabulary:
- existing stale or overdue backups stay amber, while red is reserved for a
- supported guest with no recorded backup. The compact row must not infer a
+ existing stale or overdue backups stay amber. Missing completion evidence
+ is also amber Unknown, not a red no-backup verdict: the current scalar
+ does not establish all-time absence. The compact row must not infer a
red failure state from a fixed backup age. When the dedicated Backup column
is hidden, supported non-template guests retain one fixed-size shield in
the identity cell for every state: green for fresh completed coverage,
- amber for stale or overdue coverage, red for no recorded backup, and blue
+ amber for stale, overdue or unreported completion evidence, and blue
for a backup currently running. Positive coverage must not disappear merely
because it is healthy. Backup support must be derived from the row's
canonical platform scopes before classifying an absent scalar: `proxmox-pve`
@@ -4419,7 +4437,8 @@ table and the wide width.
The evidence content is reactive to the same guest identity: running is not
completion, malformed/future times are unknown, and only the existing absence
-sentinels mean no backup recorded. A removed row unmounts its disclosure and
+sentinels mean no completion time reported in current inventory, not that no
+backup exists. A removed row unmounts its disclosure and
restores dialog isolation. Opening details adds no API/history read, collector,
permission, backup/guest operation or polling timer. Dialog machinery and
content are mounted only when opened; existing freshness thresholds and source
diff --git a/frontend-modern/browser-verification/575354f707b0adf7.json b/frontend-modern/browser-verification/575354f707b0adf7.json
new file mode 100644
index 0000000000..b3b976fafa
--- /dev/null
+++ b/frontend-modern/browser-verification/575354f707b0adf7.json
@@ -0,0 +1,46 @@
+{
+ "version": 1,
+ "base_sha": "2963e03a29fa84aa4e657f7e463a386338a31f08",
+ "verified_at": "2026-10-29T01:59:50Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/Workloads/GuestRowCells.tsx",
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts",
+ "frontend-modern/src/utils/format.ts",
+ "frontend-modern/src/utils/workloadGuestPresentation.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/Workloads/GuestRowCells.tsx": "10509ecda22d2ddd28b1cc7b1da1bdddaafe592617f09d90bc7fcf96f0677677",
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts": "3637356e422b8e6ee3671de646820efbf4c8fbc7e9a73607e4cff31e4304c234",
+ "frontend-modern/src/utils/format.ts": "ab982e50d5c14a61b9dacef4d99a3df710c4875b1cc5afcedc439cbbd8034eb6",
+ "frontend-modern/src/utils/workloadGuestPresentation.ts": "a98a3ebe2cd3950ad2d5ba9b8d14be3e41a9fe7812c07af9940242a9f7cf6524"
+ },
+ "routes": [
+ "/workloads?transport=api&type=vm",
+ "/workloads?transport=api&type=system-container",
+ "/workloads?transport=snapshot&type=vm",
+ "/workloads?transport=snapshot&type=system-container"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 1000
+ },
+ {
+ "width": 320,
+ "height": 780
+ }
+ ],
+ "states": [
+ "Missing, empty and Go-zero completion times stay cautionary Unknown, not red absence, never-backed-up or first-backup claims.",
+ "Running activity remains blue and is not completion. Valid completion restores exact UTC time and green freshness; malformed/future and missing recurrence withdraw the time without closing details.",
+ "Real REST/owning-snapshot useWorkloads mapper, production GuestRow, full GuestDrawer, dialogs and CSS; 1974 checks over 16 Chromium/WebKit desktop/narrow scenarios, Playwright 1.56.1.",
+ "Eight final captures opened with native view_image. New inventory-scoped explanation, cautionary drawer state, phone shield and independent guest-read/thaw warnings fit and remain readable.",
+ "Bounded synthetic consumer proof, not original backup/guest causality, native thaw, archive restorability, installed recovery, publication or release acceptance."
+ ],
+ "interactions": [
+ "Desktop keyboard and narrow touch open the real backup disclosure without toggling its row. Native drawer Details activation exposes valid evidence.",
+ "Live source replacement retains the same dialog/drawer and focus. Escape or Close returns focus to the exact originating shield/badge.",
+ "Existing guest-safety link stays separate; no threshold link appears without an age. All API traffic is loopback reads; no guest/backup/restore operation or external request."
+ ]
+}
diff --git a/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx b/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx
index d09bc8bb2f..90e0bdd4c2 100644
--- a/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx
+++ b/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx
@@ -370,7 +370,7 @@ describe('GuestDrawer', () => {
render(() => <GuestDrawer guest={guest()} onClose={vi.fn()} />);
const details = technicalDetails();
expect(details.getByText('Backup time unavailable: invalid timestamp.')).toBeVisible();
- expect(details.queryByText('No completed backup found')).not.toBeInTheDocument();
+ expect(details.queryByText('No completed backup reported')).not.toBeInTheDocument();
expect(details.queryByText('1 hour ago')).not.toBeInTheDocument();
setGuest({ ...guest(), lastBackup: Date.now() + 86_400_000, backupInProgress: true });
expect(details.getByText(/timestamp is in the future/)).toBeVisible();
@@ -379,7 +379,7 @@ describe('GuestDrawer', () => {
expect(details.getByText('1 hour ago')).toBeVisible();
expect(details.queryByText(/unavailable/)).not.toBeInTheDocument();
setGuest({ ...guest(), lastBackup: 0 });
- expect(details.getByText('No completed backup found')).toBeVisible();
+ expect(details.getByText('No completed backup reported')).toBeVisible();
});
it('keeps deferred filesystem fallback last-known through History and fresh resumption', async () => {
@@ -1176,9 +1176,9 @@ describe('GuestDrawer', () => {
/>
));
expect(technicalDetails().getByText('Last completed backup')).toBeInTheDocument();
- expect(technicalDetails().getByText('No completed backup found').closest('td')).toHaveClass(
- 'text-rose-700',
- );
+ expect(
+ technicalDetails().getByText('No completed backup reported').closest('td'),
+ ).toHaveClass('text-amber-700');
expect(technicalDetails().getByText('Backup activity')).toBeInTheDocument();
expect(
technicalDetails().getByText('Running · not completed yet').closest('td'),
@@ -1210,12 +1210,14 @@ describe('GuestDrawer', () => {
expect(technicalDetails().queryByText('Backup activity')).not.toBeInTheDocument();
setGuest({ ...guest(), backupInProgress: true });
expect(technicalDetails().getByText('Running · not completed yet')).toBeInTheDocument();
- expect(technicalDetails().getByText('No completed backup found')).toBeInTheDocument();
+ expect(technicalDetails().getByText('No completed backup reported')).toBeInTheDocument();
setGuest({ ...guest(), backupInProgress: false });
expect(technicalDetails().queryByText('Backup activity')).not.toBeInTheDocument();
- expect(technicalDetails().getByText('No completed backup found')).toBeInTheDocument();
+ expect(technicalDetails().getByText('No completed backup reported')).toBeInTheDocument();
setGuest({ ...guest(), lastBackup: new Date('2026-03-02T10:00:00Z').getTime() });
- expect(technicalDetails().queryByText('No completed backup found')).not.toBeInTheDocument();
+ expect(
+ technicalDetails().queryByText('No completed backup reported'),
+ ).not.toBeInTheDocument();
expect(technicalDetails().getByText('2 hours ago').closest('td')).toHaveClass(
'text-emerald-700',
);
@@ -1224,7 +1226,7 @@ describe('GuestDrawer', () => {
it('reports missing completed protection rather than hiding it when lastBackup is 0', () => {
solidRender(() => <GuestDrawer guest={makeGuest({ lastBackup: 0 })} onClose={vi.fn()} />);
- expect(technicalDetails().getByText('No completed backup found')).toBeInTheDocument();
+ expect(technicalDetails().getByText('No completed backup reported')).toBeInTheDocument();
expect(technicalDetails().queryByText('Backup activity')).not.toBeInTheDocument();
});
});
diff --git a/frontend-modern/src/components/Workloads/GuestRowCells.tsx b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
index 22e0c5a3ea..6ecdb4f27f 100644
--- a/frontend-modern/src/components/Workloads/GuestRowCells.tsx
+++ b/frontend-modern/src/components/Workloads/GuestRowCells.tsx
@@ -90,8 +90,7 @@ function getBackupAgeBadgeLabel(
info: BackupInfo,
now: number,
): string {
- if (info.status === 'never') return 'None';
- if (info.status === 'unknown') return 'Unknown';
+ if (info.status === 'never' || info.status === 'unknown') return 'Unknown';
const compact = formatRelativeTime(lastBackup ?? undefined, {
compact: true,
emptyText: 'Unknown',
@@ -105,9 +104,9 @@ function getBackupAgeBadgeClass(status: WorkloadsGuestBackupDisplayStatus): stri
const layout =
'inline-flex h-5 min-w-13 items-center justify-center gap-1 px-1.5 text-[10px] font-semibold leading-none tabular-nums cursor-help';
// A healthy backup only needs its shield. Existing backups that cross an age
- // threshold remain amber because age is a policy-relative caution, while red
- // is reserved for the materially different state where no backup exists.
- // The exact age stays visible for every non-fresh state.
+ // threshold remain amber because age is a policy-relative caution. Missing
+ // completion evidence is also cautionary: this row cannot establish that
+ // no backups exist. The exact age stays visible when it is available.
const pill = `${layout} rounded-full border`;
switch (status) {
@@ -117,9 +116,8 @@ function getBackupAgeBadgeClass(status: WorkloadsGuestBackupDisplayStatus): stri
return `${pill} border-yellow-200 bg-yellow-50 text-yellow-700 dark:border-yellow-900/70 dark:bg-yellow-950/40 dark:text-yellow-300`;
case 'overdue':
case 'unknown':
- return `${pill} border-yellow-200 bg-yellow-50 text-yellow-700 dark:border-yellow-900/70 dark:bg-yellow-950/40 dark:text-yellow-300`;
case 'never':
- return `${pill} border-red-200 bg-red-50 text-red-700 dark:border-red-900/70 dark:bg-red-950/40 dark:text-red-300`;
+ return `${pill} border-yellow-200 bg-yellow-50 text-yellow-700 dark:border-yellow-900/70 dark:bg-yellow-950/40 dark:text-yellow-300`;
// A running backup is work underway, not success (green would claim a
// completed backup) and not absence (hiding it would look like nothing
// is happening). Blue matches the Backups page's running-task tone.
@@ -381,9 +379,9 @@ function BackupStatusCell(props: {
if (props.backupRunning) {
return hasCompletedBackup()
? `Backup status: backup running now, last completed backup ${currentInfo.ageFormatted}`
- : 'Backup status: backup running now, no completed backup yet';
+ : 'Backup status: backup running now, no completed backup reported';
}
- if (currentInfo.status === 'never') return 'Backup status: no backup found';
+ if (currentInfo.status === 'never') return 'Backup status: no completed backup reported';
return `Backup status: ${currentInfo.status}, last backup ${currentInfo.ageFormatted}`;
});
@@ -439,10 +437,9 @@ function BackupStatusCell(props: {
<p class="text-amber-700 dark:text-amber-300">{info().ageFormatted}</p>
</Show>
<Show when={info().status === 'never'}>
- <p class="text-red-600 dark:text-red-400">
- {props.backupRunning
- ? 'No completed backup yet - the first backup is running now.'
- : 'No backup has ever been recorded for this guest.'}
+ <p class="text-amber-700 dark:text-amber-300">
+ No completed backup is reported in the current inventory. Missing data does not mean no
+ backups exist.
</p>
</Show>
<Show when={guestReadPresentation()}>
diff --git a/frontend-modern/src/components/Workloads/__tests__/BackupCompletionTime.test.tsx b/frontend-modern/src/components/Workloads/__tests__/BackupCompletionTime.test.tsx
index 9e3b966905..b1e6f77502 100644
--- a/frontend-modern/src/components/Workloads/__tests__/BackupCompletionTime.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/BackupCompletionTime.test.tsx
@@ -104,7 +104,7 @@ describe('one explicit completion time across backup evidence surfaces', () => {
}
setValue(0);
expect(dialog.querySelector('time')).toBeNull();
- expect(dialog).toHaveTextContent('No completed backup yet');
+ expect(dialog).toHaveTextContent('No completed backup is reported in the current inventory');
setValue(now + RELATIVE_TIME_TICK_MS);
expect(dialog.querySelector('time')).toBeNull();
expect(dialog).toHaveTextContent('timestamp is in the future');
diff --git a/frontend-modern/src/components/Workloads/__tests__/BackupStatusAccess.test.tsx b/frontend-modern/src/components/Workloads/__tests__/BackupStatusAccess.test.tsx
index 7c5d5843da..2ee5530529 100644
--- a/frontend-modern/src/components/Workloads/__tests__/BackupStatusAccess.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/BackupStatusAccess.test.tsx
@@ -72,9 +72,9 @@ describe('backup evidence access', () => {
expect(dialog).toHaveTextContent('timestamp is in the future');
expect(dialog).not.toHaveTextContent('Invalid Date');
setValue(0);
- expect(dialog).toHaveTextContent('No completed backup yet');
+ expect(dialog).toHaveTextContent('No completed backup is reported in the current inventory');
setRunning(false);
- expect(dialog).toHaveTextContent('No backup has ever been recorded');
+ expect(dialog).toHaveTextContent('Missing data does not mean no backups exist');
expect(dialog).not.toHaveTextContent('Backup running now');
setValue(completed);
expect(dialog).toHaveTextContent('2 hours ago');
@@ -97,7 +97,9 @@ describe('backup evidence access', () => {
fireEvent.click(screen.getByRole('button', { name: 'Close backup details' }));
fireEvent.click(triggers[1]);
expect(screen.getAllByRole('dialog')).toHaveLength(1);
- expect(screen.getByRole('dialog')).toHaveTextContent('No backup has ever been recorded');
+ expect(screen.getByRole('dialog')).toHaveTextContent(
+ 'Missing data does not mean no backups exist',
+ );
expect(screen.getByRole('dialog')).not.toHaveTextContent('2 hours ago');
expect(screen.queryByRole('button', { name: /^Last backup:/ })).toBeNull();
});
diff --git a/frontend-modern/src/components/Workloads/__tests__/BackupStatusCell.test.tsx b/frontend-modern/src/components/Workloads/__tests__/BackupStatusCell.test.tsx
index e72170d90d..af89e60b42 100644
--- a/frontend-modern/src/components/Workloads/__tests__/BackupStatusCell.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/BackupStatusCell.test.tsx
@@ -54,13 +54,14 @@ describe('BackupStatusCell', () => {
expect(badge.className).not.toContain('border-red-200');
});
- it('labels a guest that has never been backed up in red', () => {
+ it('keeps a missing completion time cautionary rather than claiming no backups exist', () => {
const badge = renderCell(null);
- expect(badge.textContent?.trim()).toBe('None');
+ expect(badge.textContent?.trim()).toBe('Unknown');
expect(badge.className).toContain('rounded-full');
- expect(badge.className).toContain('border-red-200');
- expect(badge.getAttribute('aria-label')).toBe('Backup status: no backup found');
+ expect(badge.className).toContain('border-yellow-200');
+ expect(badge.className).not.toContain('red');
+ expect(badge.getAttribute('aria-label')).toBe('Backup status: no completed backup reported');
});
// A backup that merely STARTED must never wear the green shield - the
@@ -78,14 +79,14 @@ describe('BackupStatusCell', () => {
);
});
- it('shows Running rather than red None while a first backup runs', () => {
+ it('shows Running without claiming this is the first backup', () => {
const badge = renderCell(null, true);
expect(badge.textContent?.trim()).toBe('Running');
expect(badge.className).toContain('border-blue-200');
expect(badge.className).not.toContain('border-red-200');
expect(badge.getAttribute('aria-label')).toBe(
- 'Backup status: backup running now, no completed backup yet',
+ 'Backup status: backup running now, no completed backup reported',
);
});
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestDrawer.backup-clock.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestDrawer.backup-clock.test.tsx
index 10694b86a6..ba348fcbba 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestDrawer.backup-clock.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestDrawer.backup-clock.test.tsx
@@ -200,7 +200,7 @@ describe('mounted completed-backup evidence', () => {
.closest('td'),
).toHaveClass('text-amber-700');
expect(completion()).toBeNull();
- expect(details().queryByText('No completed backup found')).not.toBeInTheDocument();
+ expect(details().queryByText('No completed backup reported')).not.toBeInTheDocument();
expectOnlyTrendReads();
});
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
index d44eb8d552..0cafdf2165 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
@@ -3669,11 +3669,39 @@ describe('backup disclosures keep completion separate from guest safety', () =>
function openBackup(backupColumn: boolean) {
fireEvent.click(
- screen.getByRole('button', { name: backupColumn ? /^Backup status:/ : /^Last backup:/ }),
+ screen.getByRole('button', {
+ name: backupColumn ? /^Backup status:/ : /^(Last backup:|No completed backup reported$)/,
+ }),
);
return screen.getByRole('dialog');
}
+ it.each([true, false])(
+ 'keeps missing backup evidence separate from uncertain guest reads, column=%s',
+ (backupColumn) => {
+ render(() => (
+ <table>
+ <tbody>
+ <GuestRow
+ guest={makeGuest({ lastBackup: 0, diskStatusReason: 'prev-agent-timeout' })}
+ visibleColumnIds={backupColumn ? ['name', 'backup'] : ['name']}
+ />
+ </tbody>
+ </table>
+ ));
+ const dialog = openBackup(backupColumn);
+ expect(dialog).toHaveTextContent('Missing data does not mean no backups exist');
+ expect(dialog).not.toHaveTextContent(/No backup has ever|the first backup/i);
+ expect(dialog.querySelector('time')).toBeNull();
+ expect(dialog).toHaveTextContent('Guest-agent reads: Deferred');
+ expect(dialog).toHaveTextContent(GUEST_DRAWER_BACKUP_PRECAUTION);
+ expect(within(dialog).getByRole('link', { name: 'Backup safety guidance' })).toHaveAttribute(
+ 'href',
+ '/docs/VM_DISK_MONITORING',
+ );
+ },
+ );
+
it.each([true, false])(
'keeps the same open evidence truthful through lock, uncertain completion and recovery, column=%s',
(backupColumn) => {
diff --git a/frontend-modern/src/components/Workloads/__tests__/backupTimeEvidence.contract.test.tsx b/frontend-modern/src/components/Workloads/__tests__/backupTimeEvidence.contract.test.tsx
index 3979f230de..9ae739dbc9 100644
--- a/frontend-modern/src/components/Workloads/__tests__/backupTimeEvidence.contract.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/backupTimeEvidence.contract.test.tsx
@@ -57,7 +57,7 @@ describe('backup time evidence', () => {
expect(getBackupInfo(value, undefined, now)).toEqual({
status: 'never',
ageMs: null,
- ageFormatted: 'Never',
+ ageFormatted: 'No completed backup reported',
});
});
diff --git a/frontend-modern/src/components/Workloads/__tests__/backupTimestampFlow.test.tsx b/frontend-modern/src/components/Workloads/__tests__/backupTimestampFlow.test.tsx
index 2e036a7b26..80c02925e2 100644
--- a/frontend-modern/src/components/Workloads/__tests__/backupTimestampFlow.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/backupTimestampFlow.test.tsx
@@ -42,7 +42,11 @@ const valid = '2026-10-04T13:00:00.123456789+02:00';
const iso = '2026-10-04T11:00:00.123Z';
const malformed = ['2026-09-31T11:00:00Z', '2026-10-04T11:00:00', '2026-10-04'];
-const rawResource = (lastBackup: string, type: 'vm' | 'system-container', running: boolean) => ({
+const rawResource = (
+ lastBackup: string | undefined,
+ type: 'vm' | 'system-container',
+ running: boolean,
+) => ({
id: 'east-100',
name: 'backup-time-guest',
type,
@@ -59,8 +63,12 @@ const rawResource = (lastBackup: string, type: 'vm' | 'system-container', runnin
},
});
-function mount(transport: 'api' | 'snapshot', type: 'vm' | 'system-container') {
- let raw = rawResource(malformed[0], type, false);
+function mount(
+ transport: 'api' | 'snapshot',
+ type: 'vm' | 'system-container',
+ initialBackup: string | undefined = malformed[0],
+) {
+ let raw = rawResource(initialBackup, type, false);
api.json.mockImplementation(() => Promise.resolve({ data: [raw], meta: { totalPages: 1 } }));
const [snapshot, setSnapshot] = createSignal<Resource[]>([raw as unknown as Resource]);
let source!: ReturnType<typeof useWorkloads>;
@@ -87,7 +95,7 @@ function mount(transport: 'api' | 'snapshot', type: 'vm' | 'system-container') {
});
return {
source: () => source,
- update: async (value: string, running = false) => {
+ update: async (value: string | undefined, running = false) => {
raw = rawResource(value, type, running);
if (transport === 'snapshot') setSnapshot([raw as unknown as Resource]);
else await source.refetch();
@@ -116,6 +124,61 @@ afterEach(() => {
describe.each(['api', 'snapshot'] as const)(
'backup time through %s resource producer',
(transport) => {
+ it.each(['vm', 'system-container'] as const)(
+ '[regression] missing %s completion evidence never claims all-time absence or a first backup',
+ async (type) => {
+ const view = mount(transport, type, '');
+ const badge = await screen.findByRole('button', {
+ name: 'Backup status: no completed backup reported',
+ });
+ const details = screen.getByTestId('guest-technical-details') as HTMLDetailsElement;
+ details.open = true;
+ badge.focus();
+ fireEvent.click(badge);
+ const dialog = screen.getByRole('dialog', { name: /^Backup status details/ });
+ const close = within(dialog).getByRole('button', { name: 'Close backup details' });
+ close.focus();
+ for (const value of [undefined, '', '0001-01-01T00:00:00Z']) {
+ for (const running of [true, false]) {
+ await view.update(value, running);
+ await waitFor(() => expect(badge).toHaveTextContent(running ? 'Running' : 'Unknown'));
+ expect(badge).toHaveAccessibleName(/no completed backup reported/);
+ expect(badge.className).toContain(running ? 'blue' : 'yellow');
+ expect(badge.className).not.toMatch(/red|green/);
+ expect(dialog).toHaveTextContent(
+ 'No completed backup is reported in the current inventory',
+ );
+ expect(dialog).toHaveTextContent('Missing data does not mean no backups exist');
+ expect(dialog).not.toHaveTextContent(/ever|first backup|no completed backup yet/i);
+ expect(dialog.querySelector('time')).toBeNull();
+ expect(backupRow()).toHaveTextContent('No completed backup reported');
+ expect(backupRow().querySelector('td')).toHaveClass('text-amber-700');
+ expect(screen.getByTestId('guest-drawer-overview').textContent).not.toContain('never');
+ expect(
+ within(dialog).queryByRole('link', { name: 'Change when backups count as old' }),
+ ).toBeNull();
+ expect(close).toHaveFocus();
+ }
+ }
+ await view.update(valid);
+ await waitFor(() => expect(badge).toHaveAccessibleName(/fresh/));
+ expect(badge.className).toContain('green');
+ expect(dialog.querySelector('time')).toHaveAttribute('datetime', iso);
+ expect(backupRow().querySelector('time')).toHaveAttribute('datetime', iso);
+ await view.update('');
+ await waitFor(() => expect(badge).toHaveAccessibleName(/no completed backup reported/));
+ expect(dialog.querySelector('time')).toBeNull();
+ expect(backupRow().querySelector('time')).toBeNull();
+ expect(screen.getByRole('dialog', { name: /^Backup status details/ })).toBe(dialog);
+ expect(screen.getByTestId('guest-technical-details')).toBe(details);
+ expect(close).toHaveFocus();
+ fireEvent.click(close);
+ expect(badge).toHaveFocus();
+ if (transport === 'snapshot') expect(api.json).not.toHaveBeenCalled();
+ else expect(api.json).toHaveBeenCalledTimes(9);
+ },
+ );
+
it.each(['vm', 'system-container'] as const)(
'[regression] keeps malformed %s evidence unknown through live recovery and recurrence',
async (type) => {
@@ -178,7 +241,7 @@ describe.each(['api', 'snapshot'] as const)(
const badge = await screen.findByRole('button', { name: /^Backup status:/ });
for (const value of ['', '0001-01-01T00:00:00Z', '0001-01-01T00:00:00.000000000Z']) {
await view.update(value);
- await waitFor(() => expect(badge).toHaveTextContent('None'));
+ await waitFor(() => expect(badge).toHaveTextContent('Unknown'));
expect(view.source().workloads()[0].lastBackup).toBe(0);
}
await view.update('2026-10-04T04:00:00-07:00');
diff --git a/frontend-modern/src/components/Workloads/__tests__/mountedEvidenceClock.test.tsx b/frontend-modern/src/components/Workloads/__tests__/mountedEvidenceClock.test.tsx
index d3646ff68c..69dd7e47fe 100644
--- a/frontend-modern/src/components/Workloads/__tests__/mountedEvidenceClock.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/mountedEvidenceClock.test.tsx
@@ -75,8 +75,8 @@ describe('mounted workload evidence clock', () => {
expect(running).toHaveAccessibleName(/last completed backup 2 hours ago/);
expect(screen.getByRole('button', { name: /invalid timestamp/ })).toHaveTextContent('Unknown');
expect(
- screen.getByRole('button', { name: 'Backup status: no backup found' }),
- ).toHaveTextContent('None');
+ screen.getByRole('button', { name: 'Backup status: no completed backup reported' }),
+ ).toHaveTextContent('Unknown');
expect(screen.getAllByRole('button')).toHaveLength(3);
cleanup();
expect(vi.getTimerCount()).toBe(0);
diff --git a/frontend-modern/src/components/Workloads/guestDrawerModel.ts b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
index 4494e7b495..ed5bd4451f 100644
--- a/frontend-modern/src/components/Workloads/guestDrawerModel.ts
+++ b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
@@ -705,7 +705,7 @@ export const getGuestDrawerBackupPresentation = (
if (info.ageMs === null) {
return {
ageClass: statusPresentation.color,
- ageLabel: info.status === 'never' ? 'No completed backup found' : info.ageFormatted,
+ ageLabel: info.ageFormatted,
dateLabel: 'Unknown',
};
}
diff --git a/frontend-modern/src/utils/__tests__/format.test.ts b/frontend-modern/src/utils/__tests__/format.test.ts
index 422886dd12..deb545acb0 100644
--- a/frontend-modern/src/utils/__tests__/format.test.ts
+++ b/frontend-modern/src/utils/__tests__/format.test.ts
@@ -339,12 +339,12 @@ describe('getBackupInfo', () => {
expect(getBackupInfo(null)).toEqual({
status: 'never',
ageMs: null,
- ageFormatted: 'Never',
+ ageFormatted: 'No completed backup reported',
});
expect(getBackupInfo(undefined)).toEqual({
status: 'never',
ageMs: null,
- ageFormatted: 'Never',
+ ageFormatted: 'No completed backup reported',
});
});
@@ -357,7 +357,7 @@ describe('getBackupInfo', () => {
expect(getBackupInfo(0)).toEqual({
status: 'never',
ageMs: null,
- ageFormatted: 'Never',
+ ageFormatted: 'No completed backup reported',
});
});
diff --git a/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts b/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
index ed73ca5277..4276acf21c 100644
--- a/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
+++ b/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
@@ -103,9 +103,9 @@ describe('workloadGuestPresentation', () => {
icon: 'check',
});
expect(getWorkloadsGuestBackupStatusPresentation('never')).toEqual({
- color: 'text-red-600 dark:text-red-400',
- bgColor: 'bg-red-100 dark:bg-red-900/25',
- icon: 'x',
+ color: 'text-yellow-600 dark:text-yellow-400',
+ bgColor: 'bg-yellow-100 dark:bg-yellow-900/25',
+ icon: 'warning',
});
expect(getWorkloadsGuestBackupStatusPresentation('overdue')).toEqual({
color: 'text-yellow-600 dark:text-yellow-400',
@@ -115,7 +115,7 @@ describe('workloadGuestPresentation', () => {
});
it('returns canonical guest backup tooltip copy', () => {
- expect(getWorkloadsGuestBackupTooltip('never')).toBe('No backup found');
+ expect(getWorkloadsGuestBackupTooltip('never')).toBe('No completed backup reported');
expect(getWorkloadsGuestBackupTooltip('stale', '3d')).toBe('Last backup: 3d');
});
@@ -134,8 +134,8 @@ describe('workloadGuestPresentation', () => {
it('returns canonical compact protection context for object drawers', () => {
expect(getWorkloadsGuestProtectionPresentation({})).toEqual({
- label: 'No completed backup found',
- tone: 'danger',
+ label: 'No completed backup reported',
+ tone: 'warning',
});
expect(
getWorkloadsGuestProtectionPresentation({
@@ -163,7 +163,7 @@ describe('workloadGuestPresentation', () => {
'Backup running now · last backup: 3d',
);
expect(getWorkloadsGuestBackupTooltip('never', undefined, true)).toBe(
- 'Backup running now · no completed backup found',
+ 'Backup running now · no completed backup reported',
);
});
diff --git a/frontend-modern/src/utils/format.ts b/frontend-modern/src/utils/format.ts
index 02e5162276..f7534ed581 100644
--- a/frontend-modern/src/utils/format.ts
+++ b/frontend-modern/src/utils/format.ts
@@ -340,10 +340,11 @@ export function getBackupInfo(
thresholds?: BackupThresholds,
now: number | Date = Date.now(),
): BackupInfo {
- // Only the explicit absence sentinels mean no completed backup was found.
- // A present but unusable timestamp is uncertainty, not absence or freshness.
+ // These sentinels mean the current inventory reports no completion time,
+ // not that no backup exists or that this guest has never been backed up.
+ // Keep the legacy 'never' key distinct from a present, unusable timestamp.
if (lastBackup === null || lastBackup === undefined || lastBackup === '' || lastBackup === 0) {
- return { status: 'never', ageMs: null, ageFormatted: 'Never' };
+ return { status: 'never', ageMs: null, ageFormatted: 'No completed backup reported' };
}
const timestamp =
diff --git a/frontend-modern/src/utils/workloadGuestPresentation.ts b/frontend-modern/src/utils/workloadGuestPresentation.ts
index 6192d52a8f..1248ae3b50 100644
--- a/frontend-modern/src/utils/workloadGuestPresentation.ts
+++ b/frontend-modern/src/utils/workloadGuestPresentation.ts
@@ -36,9 +36,11 @@ const BACKUP_STATUS_PRESENTATION: Record<
icon: 'warning',
},
never: {
- color: 'text-red-600 dark:text-red-400',
- bgColor: 'bg-red-100 dark:bg-red-900/25',
- icon: 'x',
+ // The legacy key means no completion time in current inventory, not
+ // independently established absence of every backup or restore point.
+ color: 'text-yellow-600 dark:text-yellow-400',
+ bgColor: 'bg-yellow-100 dark:bg-yellow-900/25',
+ icon: 'warning',
},
unknown: {
color: 'text-yellow-600 dark:text-yellow-400',
@@ -95,16 +97,13 @@ export function getWorkloadsGuestBackupTooltip(
): string {
const base =
status === 'never'
- ? 'No completed backup found'
+ ? 'No completed backup reported'
: status === 'unknown'
? ageFormatted || 'Backup age unavailable'
: `Last backup: ${ageFormatted || 'Unknown'}`;
if (backupRunning) {
return `Backup running now · ${base.toLowerCase()}`;
}
- if (status === 'never') {
- return 'No backup found';
- }
return base;
}
@@ -113,7 +112,7 @@ export function getWorkloadsGuestProtectionPresentation(options: {
ageClass?: string | null;
}): WorkloadsGuestProtectionPresentation {
if (!options.ageLabel) {
- return { label: 'No completed backup found', tone: 'danger' };
+ return { label: 'No completed backup reported', tone: 'warning' };
}
return {
label: options.ageLabel,