Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

State the shared backup context guarantee precisely

pulse-triage[bot]1514fb23d4c9
diff --git a/docs/release-control/v6/internal/subsystems/monitoring.md b/docs/release-control/v6/internal/subsystems/monitoring.md
index 30d2d2dd79..2c02e8fd88 100644
--- a/docs/release-control/v6/internal/subsystems/monitoring.md
+++ b/docs/release-control/v6/internal/subsystems/monitoring.md
@@ -24,7 +24,7 @@ jobs are selected by least recent attempt within the connection, with never-read
jobs first and provider order breaking ties. While ended work waits, admission keeps up to 24 running
reads and reserves at least one of the 25 turns for pending ended history;
unused turns serve either queue. Execution starts with the queue not served by
-the last actual request (live first on a new connection), then uses the admitted
+the last actual request (live first without a prior request), then uses the admitted
live-first order. Thus a read exhausting the shared context cannot indefinitely
prevent the other queue from running. When both queues exhaust it on every
request, their first turns alternate; when just one queue exhausts it, the
diff --git a/internal/monitoring/monitor_backups.go b/internal/monitoring/monitor_backups.go
index 53d86cfe4c..a9eaadd456 100644
--- a/internal/monitoring/monitor_backups.go
+++ b/internal/monitoring/monitor_backups.go
@@ -2868,8 +2868,8 @@ func (m *Monitor) selectVzdumpJobLogReads(instance string, jobs []models.BackupT
// Admission reserves live capacity and an ended turn; execution must share
// the context too. Move only the oldest selected ended read ahead of live
// work when the last actual request was live. If either queue exhausts the
- // context, the other starts next poll. Fast live reads still run every poll,
- // without waiting behind a whole backlog of slow ended reads (or vice versa).
+ // context, the other starts next poll, rather than waiting behind an entire
+ // slow backlog. The shared time budget can still defer admitted live reads.
if historyFirst {
for _, read := range pending {
if rank := selected[read.key]; !read.running && rank > 0 {