Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Align onboarding contract tests with verified saved installers

pulse-triage[bot]16aad56c4146
diff --git a/frontend-modern/src/features/docs/__tests__/externalAgentGuide.test.ts b/frontend-modern/src/features/docs/__tests__/externalAgentGuide.test.ts
index 9c95b01596..c7ff6abfaa 100644
--- a/frontend-modern/src/features/docs/__tests__/externalAgentGuide.test.ts
+++ b/frontend-modern/src/features/docs/__tests__/externalAgentGuide.test.ts
@@ -10,6 +10,19 @@ const article = (name: string) => {
return element;
};
const text = (element: Element) => element.textContent?.replace(/\s+/g, ' ').trim() ?? '';
+const section = (guide: Element, id: string) => {
+ const heading = guide.querySelector(`#${id}`);
+ expect(heading?.tagName).toBe('H2');
+ const content = document.createElement('section');
+ for (
+ let node = heading!.nextElementSibling;
+ node && node.tagName !== 'H2';
+ node = node.nextElementSibling
+ ) {
+ content.append(node.cloneNode(true));
+ }
+ return content;
+};
describe('external-agent operator guidance', () => {
it('puts read-only trust and private credentials before advertised controls', () => {
@@ -27,11 +40,33 @@ describe('external-agent operator guidance', () => {
expect(text(setup!.nextElementSibling!)).toContain('not the minimum for a read-only client');
expect(text(setup!.nextElementSibling!)).toContain('project-shared .mcp.json');
expect(text(guide)).toContain('only the protected fleet read checks token access');
- expect([...guide.querySelectorAll('pre')].map((node) => text(node))).toEqual([
+ const connection = section(guide, 'connect-without-granting-control');
+ expect([...connection.querySelectorAll('pre')].map((node) => text(node))).toEqual([
'pulse_api GET /api/agent/capabilities pulse_api GET /api/agent/fleet-context',
]);
});
+ it('renders saved-installer verification separately from connection checks', () => {
+ const install = section(article('AGENT_SUBSTRATE'), 'install-the-mcp-adapter-safely');
+ const recipes = [...install.querySelectorAll('pre')].map((node) => text(node));
+ expect(recipes).toHaveLength(2);
+ expect(recipes[0]).toContain('set -eu');
+ expect(recipes[1]).toContain('$LASTEXITCODE -ne 0');
+ for (const recipe of recipes) {
+ expect(recipe).toContain('gh release download');
+ expect(recipe).toContain('gh release verify');
+ expect(recipe).toContain('gh release verify-asset');
+ expect(recipe).not.toContain('pulse_api');
+ expect(recipe).not.toMatch(/\|\s*(bash|sh|iex|Invoke-Expression)\b/i);
+ }
+ expect(text(install)).toContain('after verification and before running it');
+ expect(text(install)).toContain('PULSE_MCP_VERSION=vX.Y.Z');
+ expect(text(install)).toContain('-Version $version');
+ expect(text(install)).toContain('normal software approval path');
+ const link = install.querySelector('a[href="/docs/INSTALL#verify-release-build-provenance"]');
+ expect(link?.hasAttribute('data-doc-link')).toBe(true);
+ });
+
it('shows terminal-event, partial-verification and legacy-probe limits', () => {
const guide = article('AGENT_SUBSTRATE');
const table = guide.querySelector('table');
diff --git a/internal/api/contract_test.go b/internal/api/contract_test.go
index baad97a216..16a4c2dc92 100644
--- a/internal/api/contract_test.go
+++ b/internal/api/contract_test.go
@@ -20371,7 +20371,10 @@ func TestContract_AgentSubstrateDocReflectsCurrentMCPOnboarding(t *testing.T) {
"`cmd/pulse-mcp`",
"projects each manifest capability into one MCP tool",
"`--emit-notifications`",
- "The one-line installers `install-mcp.sh` and `install-mcp.ps1`",
+ "The saved installers `install-mcp.sh` and `install-mcp.ps1`",
+ "Do not pipe a remote download into Bash or PowerShell",
+ "gh release verify-asset",
+ "after verification and before running it",
"verify the checksum manifest against Pulse's pinned release key",
"then verify the binary's checksum",
"refuse installation when any integrity evidence is unavailable or invalid",