Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Keep prune retention distinct from backup verification
pulse-triage[bot]195d6a2f0a28
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.mdindex cb517ca4a5..568df52dc6 100644--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md@@ -20,6 +20,25 @@## Purpose+### Backup retention never substitutes for verification++The existing restore-point State cell and drawer status prioritise running or+failed completion and then the reported verification result. A point kept when+pruning still says Unverified or Verified as reported. Retention without a+verification verdict says Kept with an informational tone, never Protected.+The existing detail names Prune protection separately and says Not reported+when backup verification is unavailable. Guest snapshots retain their existing+informational state. The shared Coverage evidence uses the same state wording.+Canonical workload protection, freshness, policy and inventory counts are not+inferred from prune retention or an individual verified file.++The normal-suite `backupRetentionPresentation.test.tsx` exercises the real+inventory consumer, independent assessment, explicit/missing verification,+search compatibility and same-point polling with an open drawer and focus.+Shared badge and drawer tests retain completion precedence and reactive tones.+Desktop/narrow consuming browser proof checks the existing rows and details.+No provider data, route, access, retention operation or guest recovery changes.+### Backup filters also scope activityThe existing Proxmox By date chart and date warning consume the samediff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.mdindex b96caf3ecc..e7f850365f 100644--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md@@ -21,6 +21,25 @@## Purpose+### Backup retention never substitutes for verification++The existing restore-point State cell and drawer status prioritise running or+failed completion and then the reported verification result. A point kept when+pruning still says Unverified or Verified as reported. Retention without a+verification verdict says Kept with an informational tone, never Protected.+The existing detail names Prune protection separately and says Not reported+when backup verification is unavailable. Guest snapshots retain their existing+informational state. The shared Coverage evidence uses the same state wording.+Canonical workload protection, freshness, policy and inventory counts are not+inferred from prune retention or an individual verified file.++The normal-suite `backupRetentionPresentation.test.tsx` exercises the real+inventory consumer, independent assessment, explicit/missing verification,+search compatibility and same-point polling with an open drawer and focus.+Shared badge and drawer tests retain completion precedence and reactive tones.+Desktop/narrow consuming browser proof checks the existing rows and details.+No provider data, route, access, retention operation or guest recovery changes.+### Archive guest kinds come from artifact discriminatorsPVE archive type detection ignores the storage-name prefix and incidentaldiff --git a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsxindex 52f1604f3f..4ea4532f5e 100644--- a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx+++ b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx@@ -93,16 +93,16 @@ const artifactStateIndicator = (artifact: RecoverableArtifact): StatusIndicatorif (artifact.running) return { variant: 'info', label };if (artifact.failed) return { variant: 'danger', label };if (artifact.sourceKind === 'snapshot') return { variant: 'info', label };- if (artifact.protected) return { variant: 'warning', label };if (artifact.verified === true) return { variant: 'success', label };if (artifact.verified === false) return { variant: 'warning', label };+ if (artifact.protected) return { variant: 'info', label };return { variant: 'muted', label };};const artifactVerificationText = (artifact: RecoverableArtifact): string => {if (artifact.verified === true) return 'Verified';if (artifact.verified === false) return 'Not verified';- return '';+ return artifact.sourceKind === 'snapshot' ? '' : 'Not reported';};// Phones drop the location, size and details columns, so the drawer is where@@ -137,7 +137,7 @@ const buildRecoverableDetailSections = (artifact: RecoverableArtifact): DetailSemakeDetailRow('Verification', artifactVerificationText(artifact), {tone: artifact.verified === false ? 'warning' : undefined,}),- makeDetailRow('Protected', artifact.protected ? 'Yes, kept when pruning' : ''),+ makeDetailRow('Prune protection', artifact.protected ? 'Kept when pruning' : ''),]),},{diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsxindex c5f639d55f..5857e7f27d 100644--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx@@ -265,7 +265,7 @@ describe('ProxmoxBackupsTable', () => {};await within(table).findByText('Unavailable');await waitFor(() => expect(backupCount()).toBe('1'));- await screen.findAllByText('Protected');+ await screen.findAllByText('Verified');expect(container.innerHTML).not.toContain('PRIVATE_PROVIDER_ERROR_SENTINEL');expect(apiFetchMock.mock.calls.filter(([url]) => url === '/api/backups/pbs')).toHaveLength(1);diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsxindex ebbf9f91fb..d4a7d18874 100644--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx@@ -91,7 +91,9 @@ describe('ProxmoxRecoverableTable record drawer', () => {expect(within(panel).getByRole('heading', { level: 2, name: /web/ })).toBeInTheDocument();expect(within(panel).getByText('PBS snapshot in main / pve1')).toBeInTheDocument();expect(within(panel).getByText('main / pve1', { selector: 'span' })).toBeInTheDocument();- expect(within(panel).getByText('Verified')).toBeInTheDocument();+ expect(within(panel).getAllByText('Verified')).toHaveLength(2);+ expect(within(panel).getByText('Prune protection')).toBeInTheDocument();+ expect(within(panel).getByText('Kept when pruning')).toBeInTheDocument();expect(within(panel).getByText('5 PBS files')).toBeInTheDocument();expect(within(panel).getByRole('link', { name: 'Open web' })).toHaveAttribute('href',diff --git a/frontend-modern/src/features/proxmox/__tests__/backupRetentionPresentation.test.tsx b/frontend-modern/src/features/proxmox/__tests__/backupRetentionPresentation.test.tsxindex da6ba0fcac..71d1338a95 100644--- a/frontend-modern/src/features/proxmox/__tests__/backupRetentionPresentation.test.tsx+++ b/frontend-modern/src/features/proxmox/__tests__/backupRetentionPresentation.test.tsx@@ -12,9 +12,9 @@ const api = vi.hoisted(() => ({ fetch: vi.fn(), json: vi.fn() }));vi.mock('@/utils/apiClient', () => ({ apiFetch: api.fetch, apiFetchJSON: api.json }));const guest = {- ...identityGuest('vm-kept', 'east', 'pve-1'),- name: 'kept-guest',- displayName: 'kept-guest',+ ...identityGuest('vm-retention', 'east', 'pve-1'),+ name: 'retention-guest',+ displayName: 'retention-guest',};const point = (fields: Partial<PBSBackup> = {}) => identityPBS({ protected: true, ...fields });const jsonResponse = (data: unknown) =>@@ -43,7 +43,7 @@ function mount(getPoint: () => PBSBackup) {}async function restorePointRow() {- await screen.findAllByText('kept-guest');+ await screen.findAllByText('retention-guest');return document.querySelector('[data-proxmox-backup-row="recoverable"]') as HTMLElement;}@@ -107,7 +107,7 @@ describe('prune protection is independent of backup verification', () => {fireEvent.input(search, { target: { value: query } });await waitFor(() => {const row = document.querySelector('[data-proxmox-backup-row="recoverable"]');- expect(row).toHaveTextContent('kept-guest');+ expect(row).toHaveTextContent('retention-guest');});}expect(api.fetch).toHaveBeenCalledTimes(2);diff --git a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTableShared.test.tsx b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTableShared.test.tsxindex c116ae17e1..6e9e1929ed 100644--- a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTableShared.test.tsx+++ b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTableShared.test.tsx@@ -58,14 +58,14 @@ describe('proxmoxBackupsTableShared', () => {render(() => (<><ArtifactSourceBadge artifact={artifact({ sourceKind: 'pbs', sourceLabel: 'PBS' })} />- <ArtifactStateBadge artifact={artifact({ protected: true })} label="Protected" />+ <ArtifactStateBadge artifact={artifact({ protected: true })} label="Kept" /><ArtifactStateBadge artifact={artifact({ verified: true })} label="Verified" /></>));expect(screen.getByText('PBS').className).toContain('whitespace-nowrap');expect(screen.getByText('PBS').className).toContain('bg-sky-100');- expect(screen.getByText('Protected').className).toContain('bg-amber-100');+ expect(screen.getByText('Kept').className).toContain('bg-blue-100');expect(screen.getByText('Verified').className).toContain('bg-emerald-100');});@@ -89,16 +89,23 @@ describe('proxmoxBackupsTableShared', () => {'indigo',],[- 'pruning protection is not verification',+ 'pruning protection does not hide verification',{ protected: true, verified: true },- 'Protected',- 'warning',+ 'Verified',+ 'success',],+ ['retained unverified point', { protected: true, verified: false }, 'Unverified', 'warning'],+ ['retention without verification', { protected: true }, 'Kept', 'info'],['verification passed', { verified: true }, 'Verified', 'success'],['verification absent or failed', { verified: false }, 'Unverified', 'warning'],['unknown verification stays neutral', {}, 'Backup file', 'muted'],] as const)('keeps state wording and tone consistent: %s', (_name, fields, label, tone) => {- render(() => <ArtifactStateBadge artifact={artifact(fields)} label={label} />);+ render(() => (+ <ArtifactStateBadge+ artifact={artifact(fields)}+ label={artifactStateLabel(artifact(fields))}+ />+ ));expect(screen.getByText(label).className).toBe(getMetadataBadgeClass({tone,@@ -116,7 +123,9 @@ describe('proxmoxBackupsTableShared', () => {[{ verified: false }, 'Unverified', 'warning'],[{ running: true, verified: true }, 'Running', 'info'],[{ failed: true, protected: true }, 'Failed', 'danger'],- [{ protected: true, verified: true }, 'Protected', 'warning'],+ [{ protected: true, verified: true }, 'Verified', 'success'],+ [{ protected: true }, 'Kept', 'info'],+ [{ protected: true, verified: false }, 'Unverified', 'warning'],[{}, 'Backup file', 'muted'],[{ verified: true }, 'Verified', 'success'],] as const) {diff --git a/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts b/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.tsindex 1d4b594a7e..cf69509864 100644--- a/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts+++ b/frontend-modern/src/features/proxmox/proxmoxBackupRecoveryModel.ts@@ -845,7 +845,8 @@ export function recoverableArtifactMatchesSearch(: undefined,artifact.running ? 'running' : undefined,artifact.failed ? 'failed incomplete' : undefined,- artifact.protected ? 'protected' : 'unprotected',+ // Keep legacy saved searches while matching the visible retention wording.+ artifact.protected ? 'protected kept pruning' : 'unprotected',];return haystack.filter(Boolean).join(' ').toLowerCase().includes(normalizedTerm);}diff --git a/frontend-modern/src/features/proxmox/proxmoxBackupsTableShared.tsx b/frontend-modern/src/features/proxmox/proxmoxBackupsTableShared.tsxindex bb90210ef6..0dbed21c4f 100644--- a/frontend-modern/src/features/proxmox/proxmoxBackupsTableShared.tsx+++ b/frontend-modern/src/features/proxmox/proxmoxBackupsTableShared.tsx@@ -262,7 +262,7 @@ export function ProxmoxBackupAgeText(props: { artifact: RecoverableArtifact; com}// Short state label for a recoverable artifact, paired with ArtifactStateBadge-// for colour. Snapshot and protected take precedence over verification state.+// for colour. Prune retention is not verification or workload protection.export function artifactStateLabel(artifact: RecoverableArtifact): string {if (artifact.sourceKind === 'snapshot') {return getProxmoxBackupSourcePresentation('snapshot').stateFallbackLabel;@@ -270,9 +270,9 @@ export function artifactStateLabel(artifact: RecoverableArtifact): string {// Runtime/terminal incompleteness outranks every completed-artifact state.if (artifact.running) return 'Running';if (artifact.failed) return 'Failed';- if (artifact.protected) return 'Protected';if (artifact.verified === true) return 'Verified';if (artifact.verified === false) return 'Unverified';+ if (artifact.protected) return 'Kept';return getProxmoxBackupSourcePresentation(artifact.sourceKind).stateFallbackLabel;}@@ -280,9 +280,9 @@ const artifactStateTone = (artifact: RecoverableArtifact): MetadataBadgeTone =>if (artifact.running) return 'info';if (artifact.failed) return 'danger';if (artifact.sourceKind === 'snapshot') return 'indigo';- if (artifact.protected) return 'warning';if (artifact.verified === true) return 'success';if (artifact.verified === false) return 'warning';+ if (artifact.protected) return 'info';return 'muted';};@@ -294,6 +294,11 @@ export function ArtifactStateBadge(props: { artifact: RecoverableArtifact; label<MetadataBadge{...PROXMOX_BACKUP_METADATA_BADGE_PROPS}tone={artifactStateTone(props.artifact)}+ title={+ props.artifact.protected+ ? 'Kept when pruning. This does not establish verification or workload protection.'+ : undefined+ }>{props.label}</MetadataBadge>