Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Drop the dead recovery serializer and its stale contract prose (#2728)

rcourtman19b963be7104
diff --cc docs/release-control/v6/internal/subsystems/storage-recovery.md
index 52cf1b0e22,63d6356644..547dd9c033
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@@ -3494,40 -3475,40 +3486,44 @@@ the platform-first migration. The chip
inside the alert resource-incidents panel and Patrol findings panel were
retired in the same pass; storage and recovery drilldowns now stay inside
the platform-page sub-tabs rather than offering external surface jumps.
-Future cross-surface storage or recovery affordances must compose against
-the embedded `StorageSurface` / `RecoverySurface` consumers rather than
-reintroducing top-level URL builders.
+Future cross-surface storage or recovery affordances must link into the
+platform tab that owns those rows (the Proxmox Storage tab's embedded
+`StorageSurface`, `/truenas/storage`, the Proxmox Backups tab, or the TrueNAS
+Protection tab) rather than reintroducing top-level URL builders.
The remaining storage and recovery route builders in
- `frontend-modern/src/routing/resourceLinks.ts` are query-state serializers, not
- destination builders: callers must append `buildStorageRouteSearch()` or
- `buildRecoveryRouteSearch()` to the current platform-owned pathname such as
- `/proxmox/storage`, `/proxmox/backups`, or `/truenas/protection`. They must not
- emit `/storage` or `/recovery` as hidden compatibility paths.
+ `frontend-modern/src/routing/resourceLinks.ts` come down to one query-state
+ serializer, not a destination builder: `buildStorageRouteSearch()` is appended
+ to the current platform-owned pathname, today only by the Storage surface's
+ own filter state on the Proxmox Storage tab, and must not emit `/storage` as a
+ hidden compatibility path. The recovery serializer (`RECOVERY_QUERY_PARAMS`,
+ `parseRecoveryLinkSearch`, `buildRecoveryRouteSearch`) was deleted once
+ nothing read it: the Proxmox Backups tab keeps its view in the
+ `/proxmox/backups/:view` segment and its filters in
+ `PROXMOX_BACKUPS_QUERY_PARAMS`, and nothing emits `/recovery`.
Adjacent route-query constants for other platform surfaces, including
`STANDALONE_QUERY_PARAMS`, must remain namespaced and must not be reused as
storage source, node, resource, workspace, rollup, or day state. Adding a
shareable filter query to another surface must not broaden or reinterpret the
- storage and recovery serializer contract.
+ storage serializer contract or the Proxmox Backups query.
-Storage and Recovery can now be embedded by a platform page in table-only mode
-with a forced platform source/filter. Proxmox uses that embedding for
-source-scoped storage and recovery history, while the TrueNAS Protection tab
-uses the same Recovery surface with a forced `truenas` platform filter and the
-protection-coverage workspace as its default entry point. The embedded mode
-suppresses standalone page chrome, summary charts, and full filter chrome, but
-the Storage surface must keep the canonical Storage / Physical Disks view
-selector inside the table header unless the embedding explicitly locks a
-`forcedView`, and the Recovery surface must keep protection/events workspace
-state in `frontend-modern/src/features/recovery/useRecoverySurfaceState.ts`.
-The canonical route-backed filter state, fetch builders, table rendering, and
-storage/recovery vocabulary remain owned by the Storage and Recovery surfaces.
-Platform pages must compose those owners rather than cloning storage pools,
-physical disks, recovery events, or protected-inventory tables under
-platform-specific data contracts.
+A platform page embeds `StorageSurface` with a forced source filter; there is
+no table-only mode, and no Recovery surface exists to embed. The Proxmox
+Storage tab is the only embedder: it passes `forcedSourceFilter`, and the
+surface keeps the canonical Storage / Physical Disks view selector because
+Proxmox locks no `forcedView`. Recovery rows render in platform-owned tabs.
+The Proxmox Backups tab (`frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx`)
+reads `/api/backups/pve`, `/api/backups/pbs`, and protection postures itself,
+and the TrueNAS Protection tab feeds
+`frontend-modern/src/features/truenas/TrueNASProtectionTable.tsx` from
+`useRecoveryPoints` with the `truenas` platform forced. `/truenas/storage`
+renders `TrueNASStorageTopologyTable`, not `StorageSurface`. The Storage
+surface keeps owning its route-backed filter state, fetch builders, table
+rendering, and storage vocabulary for its embedder. The Proxmox Storage tab
+must keep its storage pools and physical disks on that embed rather than a
+Proxmox-local copy; TrueNAS storage is deliberately a TrueNAS-owned topology
+table built from the TrueNAS page model. Platform recovery tables must read
+the canonical backup, posture, and recovery-point transports rather than a
+platform-specific recovery data contract.
The investigation enrichment path reads operator-state from the
in-memory provider already wired against the durable