Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Treat a denied update check as a setting and wrap node details

rcourtman19f1052321b2
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 8d4b66fd10..3a1c03e22d 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -8741,7 +8741,14 @@ return, active state, badges, and narrow-layout containment remain unchanged.
The Proxmox node drawer presents checked zero, current positive, stale,
unavailable, and not-checked package evidence as a labelled detail row with
bounded copy and checked time. The compact table badge remains reserved for a
-current positive observation. Provider errors are never rendered. Component
+current positive observation. Provider errors are never rendered. An
+unavailable check whose reason is `permission_denied` reads neutral, so the
+node Overview keeps it in Details rather than Worth checking: Proxmox gates the
+package list on `Sys.Modify`, and `docs/TROUBLESHOOTING.md` calls keeping the
+narrower monitoring role a valid choice. Other unavailable reasons stay warnings.
+Node Details rows wrap their values (`wrap: true`) rather than truncating them,
+because Details is where a reader goes for the full value: the update reason,
+the linked agent ID and the CPU model read whole at desktop and phone widths. Component
and browser evidence covers both 1440px and 390px layouts in
`NodeDrawerOverview.updateEvidence.test.tsx`, `ProxmoxNodesTable.test.tsx`, and
`frontend-modern/browser-verification.json`.
diff --git a/frontend-modern/browser-verification/471857243932cdab.json b/frontend-modern/browser-verification/471857243932cdab.json
new file mode 100644
index 0000000000..302a207f2e
--- /dev/null
+++ b/frontend-modern/browser-verification/471857243932cdab.json
@@ -0,0 +1,48 @@
+{
+ "version": 1,
+ "base_sha": "588b48b4cf158c6d03aa9cc076deedee3b7cd860",
+ "verified_at": "2026-10-13T14:41:10Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/Workloads/DrawerTrendCards.tsx",
+ "frontend-modern/src/components/Workloads/GuestDrawerHistory.tsx",
+ "frontend-modern/src/components/Workloads/NodeDrawer.tsx",
+ "frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx",
+ "frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts",
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts",
+ "frontend-modern/src/components/Workloads/useGuestDrawerState.ts",
+ "frontend-modern/src/utils/proxmoxUpdateEvidence.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/Workloads/DrawerTrendCards.tsx": "4761f86943587f997b99fc5be572f24038003926123702722d4d63dd68e6bd2f",
+ "frontend-modern/src/components/Workloads/GuestDrawerHistory.tsx": "751bdc1f976171edfad5f340d60c08e6163a30cbfa8f16d5ee55ed81ced6858a",
+ "frontend-modern/src/components/Workloads/NodeDrawer.tsx": "236e7520d3461e36a8223e4c3abca6c09b4a359796c236271501fba7e375e5c2",
+ "frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx": "cbd22eb98704675d504f0ab6b2fda387b89448c30b1fde2d1b76ecbd87d94ea1",
+ "frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts": "480828c88b3a7a957d9a908f125324ca301ba586d2f0fe21e00c6ce16717b4d7",
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts": "5b2692573a15459652a4feaea31703eb22af3056ed599a551d1a5e23577c5639",
+ "frontend-modern/src/components/Workloads/useGuestDrawerState.ts": "93cf7b37056e5397704106b2edb65441fec75ace95ef9c9b410c4e8bb4427ccb",
+ "frontend-modern/src/utils/proxmoxUpdateEvidence.ts": "571beff7a87d1167e76462fa8891250ad7bc74b253976ba1c040866b7e298efc"
+ },
+ "routes": [
+ "/proxmox/overview"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "private preview build with these files, mock mode; headless Chromium on pulse-dev through a reverse tunnel, websocket closed and /api/resources rewritten so every Proxmox node carries pendingUpdatesStatus=unavailable with the reason under test",
+ "permission_denied at 1440px: node Analytics A Overview has no Worth checking section; Details Summary shows 'Updates: Unavailable \u00b7 Update check access denied' wrapped over two lines in neutral text; Pulse coverage agent ID and CPU model also wrap in full (full-resolution screenshots reviewed)",
+ "source_unavailable at 1440px: Worth checking lists 'Updates: Unavailable \u00b7 Proxmox source unavailable' in warning tone",
+ "permission_denied at 390px: Details table rows wrap the update reason, agent ID and CPU model; no horizontal overflow"
+ ],
+ "interactions": [
+ "expanded the first node row and opened Details by clicking its summary in each scenario"
+ ]
+}
diff --git a/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx b/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
index 57467f8f0c..940c179873 100644
--- a/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
+++ b/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
@@ -210,9 +210,12 @@ const getDetailTone = (valueClass: string | undefined): DetailValueTone => {
const toDetailRows = (rows: NodeOverviewRow[]): DetailRow[] =>
compactDetailRows(
rows.map((row) =>
+ // Details is where a reader goes for the full value; wrap rather than
+ // cut it off behind an ellipsis and a hover-only title.
makeDetailRow(row.label, row.value, {
title: row.title,
tone: getDetailTone(row.valueClass),
+ wrap: true,
}),
),
);
@@ -404,11 +407,13 @@ export function NodeDrawerOverview(props: NodeDrawerOverviewProps) {
makeDetailRow(
'Pulse coverage',
linkedAgentId() ? `Agent ${stripAgentPrefix(linkedAgentId())}` : 'PVE API only',
+ { wrap: true },
),
updates
? makeDetailRow('Updates', updates.value, {
tone: updates.tone,
title: updates.title,
+ wrap: true,
})
: null,
typeof primaryTemperature === 'number' &&
diff --git a/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx b/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
index bd997514f5..ba1d59bd77 100644
--- a/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
@@ -81,4 +81,37 @@ describe('NodeDrawerOverview update evidence', () => {
expect(screen.getByText('Unavailable · Update check access denied')).toBeInTheDocument();
});
+
+ it('keeps a denied update check in Details, not under Worth checking', () => {
+ render(() => (
+ <NodeDrawerOverview
+ node={makeNode({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'permission_denied',
+ })}
+ />
+ ));
+ expect(screen.queryByTestId('node-drawer-exceptions')).toBeNull();
+ // Details shows the whole reason, wrapped, not cut off behind an ellipsis.
+ expect(screen.getByText('Unavailable · Update check access denied')).toHaveClass(
+ 'whitespace-normal',
+ );
+ expect(screen.getByTestId('node-technical-details').textContent).toContain(
+ 'Unavailable · Update check access denied',
+ );
+ });
+
+ it('lists an update check that failed under Worth checking', () => {
+ render(() => (
+ <NodeDrawerOverview
+ node={makeNode({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'source_unavailable',
+ })}
+ />
+ ));
+ expect(screen.getByTestId('node-drawer-exceptions').textContent).toContain(
+ 'Unavailable · Proxmox source unavailable',
+ );
+ });
});
diff --git a/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts b/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
index f2dabdf3bb..31ba1c2248 100644
--- a/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
+++ b/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
@@ -52,10 +52,20 @@ describe('Proxmox update evidence presentation', () => {
}),
).toMatchObject({
value: 'Unavailable · Update check access denied',
+ tone: 'default',
current: false,
});
});
+ it('keeps an unavailable check that is not a permission choice as a warning', () => {
+ expect(
+ getProxmoxUpdateEvidencePresentation({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'source_unavailable',
+ }),
+ ).toMatchObject({ value: 'Unavailable · Proxmox source unavailable', tone: 'warning' });
+ });
+
it('only treats checked or legacy-positive evidence as current', () => {
expect(hasCurrentProxmoxUpdateEvidence({ pendingUpdates: 3 })).toBe(true);
expect(
diff --git a/frontend-modern/src/utils/proxmoxUpdateEvidence.ts b/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
index 4b90f7a1d8..b426da4f10 100644
--- a/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
+++ b/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
@@ -78,7 +78,11 @@ export const getProxmoxUpdateEvidencePresentation = (
return {
value: ['Unavailable', reason].filter(Boolean).join(' · '),
title: reason || 'Update evidence is unavailable',
- tone: 'warning',
+ // Proxmox requires Sys.Modify for the package-update list, which is
+ // broader than monitoring needs; docs/TROUBLESHOOTING.md calls keeping
+ // the narrower role a valid choice. That is a setting, not a fault, so
+ // it reads neutral. A source outage or failed check stays a warning.
+ tone: node.pendingUpdatesReason === 'permission_denied' ? 'default' : 'warning',
current: false,
};
case 'not_checked':