Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Select a supported Python for native macOS contract checks

pulse-triage[bot]1cdd61c4e209
diff --git a/.github/workflows/unified-agent-native.yml b/.github/workflows/unified-agent-native.yml
index 5768a9ebef..abe58523b1 100644
--- a/.github/workflows/unified-agent-native.yml
+++ b/.github/workflows/unified-agent-native.yml
@@ -149,16 +149,21 @@ jobs:
run: go test -count=1 -timeout 3m -run '^TestIntegrationContainer' ./scripts/installtests
# The complete Go installer inventory also executes Python workflow
- # contracts. Hosted macOS has Python but does not supply PyYAML; isolate
- # that fixture prerequisite instead of skipping the registered proof or
- # modifying Homebrew's externally managed interpreter.
+ # contracts. The runner's unversioned Python is not a wheel compatibility
+ # contract (ARM64 could not obtain the pinned parser). Select supported
+ # CPython before creating the isolated venv; never build a parser from
+ # source, skip the registered proof or modify the managed interpreter.
- name: Supply YAML parser for native Unix contract checks
if: runner.os == 'macOS'
shell: bash
run: |
set -euo pipefail
+ brew install [email protected]
+ contract_runtime="$(brew --prefix [email protected])/bin/python3.13"
+ test -x "$contract_runtime"
+ "$contract_runtime" -c 'import sys; assert sys.version_info[:2] == (3, 13); print(sys.version)'
contract_python="$(mktemp -d "$RUNNER_TEMP/pulse-contract-python.XXXXXX")"
- python3 -m venv "$contract_python"
+ "$contract_runtime" -m venv "$contract_python"
"$contract_python/bin/python3" -m pip install \
--disable-pip-version-check --no-input --only-binary=:all: 'PyYAML==6.0.3'
"$contract_python/bin/python3" -c 'import yaml; assert yaml.__version__ == "6.0.3"'
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index e98a38e107..dfdbbdf69d 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -20,14 +20,19 @@
The native Unix installer inventory invokes the registered frontend workflow
contract through `python3`. Both hosted macOS architectures must supply PyYAML
-before that inventory: their standard Python does not include it. The workflow
-installs the fixed `PyYAML==6.0.3` binary distribution in an owned temporary
+before that inventory: their standard Python does not include it, and the
+unversioned ARM64 runtime could not obtain the pinned wheel. The workflow
+selects Homebrew `[email protected]` by its explicit prefix, requires Python 3.13,
+then installs the fixed `PyYAML==6.0.3` binary distribution in an owned temporary
virtual environment, checks its import/version and publishes only its bin path
to subsequent steps. It does not alter Homebrew's interpreter or skip a test.
-Venv, acquisition or import failures stop before path publication. Linux and
+Runtime installation, prefix lookup, executable/version, venv, wheel acquisition
+or import failures stop before path publication, with no ambient-Python or
+source-build fallback. Linux and
Windows keep their existing tools and all native checks/deadlines remain.
`TestNativeMacOSContractPythonPrerequisite` executes the actual shell with
-bounded command doubles for success and each prerequisite failure; native
+bounded command doubles for success, an unusable ambient Python, a selected
+prefix containing spaces and each prerequisite failure; native
macOS CI remains the real installation/execution proof.
### Duplicate-free Docker payload layers (29 October 2026)
diff --git a/scripts/installtests/build_release_assets_test.go b/scripts/installtests/build_release_assets_test.go
index 64f653534b..7df27ad976 100644
--- a/scripts/installtests/build_release_assets_test.go
+++ b/scripts/installtests/build_release_assets_test.go
@@ -5865,7 +5865,10 @@ func TestNativeMacOSContractPythonPrerequisite(t *testing.T) {
}
var workflow struct {
Jobs map[string]struct {
- Steps []struct{ Name, If, Run string }
+ Steps []struct {
+ Name, If, Run, Shell string
+ ContinueOnError bool `yaml:"continue-on-error"`
+ }
}
}
if err := yaml.Unmarshal(content, &workflow); err != nil {
@@ -5874,7 +5877,7 @@ func TestNativeMacOSContractPythonPrerequisite(t *testing.T) {
recipe := ""
for _, step := range workflow.Jobs["native-agent"].Steps {
if step.Name == "Supply YAML parser for native Unix contract checks" {
- if step.If != "runner.os == 'macOS'" {
+ if step.If != "runner.os == 'macOS'" || step.Shell != "bash" || step.ContinueOnError {
t.Fatal("Python acquisition is the missing macOS prerequisite, not a platform-wide tool replacement")
}
recipe = step.Run
@@ -5884,22 +5887,51 @@ func TestNativeMacOSContractPythonPrerequisite(t *testing.T) {
}
}
if recipe == "" || !strings.Contains(recipe, "--only-binary=:all: 'PyYAML==6.0.3'") ||
- !strings.Contains(recipe, `assert yaml.__version__ == "6.0.3"`) {
+ !strings.Contains(recipe, `assert yaml.__version__ == "6.0.3"`) ||
+ !strings.Contains(recipe, `brew install [email protected]`) ||
+ !strings.Contains(recipe, `contract_runtime="$(brew --prefix [email protected])/bin/python3.13"`) ||
+ !strings.Contains(recipe, `assert sys.version_info[:2] == (3, 13)`) {
t.Fatal("missing isolated fixed-version prerequisite and import check")
}
- for _, fault := range []string{"", "venv", "pip", "import"} {
+ for _, fault := range []string{"", "brew", "prefix", "missing-runtime", "version", "venv", "pip", "import"} {
t.Run("failure="+fault, func(t *testing.T) {
root := t.TempDir()
tools := filepath.Join(root, "tools")
if err := os.Mkdir(tools, 0700); err != nil {
t.Fatal(err)
}
+ // An ambient python3 must never create the venv. The selected
+ // Homebrew prefix can contain spaces and is unrelated to PATH.
+ runtime := filepath.Join(root, "selected Python")
+ if err := os.MkdirAll(filepath.Join(runtime, "bin"), 0700); err != nil {
+ t.Fatal(err)
+ }
+ brew := `#!/bin/sh
+set -eu
+if [ "$*" = 'install [email protected]' ]; then
+ [ "$FAULT" != brew ] || exit 24
+ printf 'installed\n' > "$BREW_CALLED"
+elif [ "$*" = '--prefix [email protected]' ]; then
+ [ "$FAULT" != prefix ] || exit 25
+ test -f "$BREW_CALLED" || exit 93
+ printf '%s\n' "$SELECTED_PYTHON"
+else
+ exit 94
+fi
+`
python := `#!/bin/sh
set -eu
+if [ "$1" = -c ] && [ ! -f "$VENV_CREATED" ]; then
+ [ "$FAULT" != version ] || exit 26
+ printf '%s\n' "$2" > "$VERSION_CODE"
+ exit 0
+fi
if [ "$1 $2" = '-m venv' ]; then
+ test -f "$VERSION_CODE" || exit 95
[ "$FAULT" != venv ] || exit 21
mkdir -p "$3/bin"
cp "$0" "$3/bin/python3"
+ printf 'created\n' > "$VENV_CREATED"
exit 0
fi
if [ "$1 $2" = '-m pip' ]; then
@@ -5911,13 +5943,23 @@ fi
[ "$FAULT" != import ] || exit 23
printf '%s\n' "$2" > "$IMPORT_CODE"
`
- if err := os.WriteFile(filepath.Join(tools, "python3"), []byte(python), 0700); err != nil {
+ if err := os.WriteFile(filepath.Join(tools, "brew"), []byte(brew), 0700); err != nil {
+ t.Fatal(err)
+ }
+ if err := os.WriteFile(filepath.Join(tools, "python3"), []byte("#!/bin/sh\nexit 92\n"), 0700); err != nil {
t.Fatal(err)
}
+ if fault != "missing-runtime" {
+ if err := os.WriteFile(filepath.Join(runtime, "bin", "python3.13"), []byte(python), 0700); err != nil {
+ t.Fatal(err)
+ }
+ }
path := filepath.Join(root, "github-path")
cmd := exec.Command("bash", "--noprofile", "--norc", "-c", recipe)
cmd.Env = append(os.Environ(), "PATH="+tools+string(os.PathListSeparator)+os.Getenv("PATH"),
"RUNNER_TEMP="+root, "GITHUB_PATH="+path, "FAULT="+fault,
+ "SELECTED_PYTHON="+runtime, "BREW_CALLED="+filepath.Join(root, "brew-called"),
+ "VERSION_CODE="+filepath.Join(root, "version-code"), "VENV_CREATED="+filepath.Join(root, "venv-created"),
"INSTALL_ARGS="+filepath.Join(root, "install-args"), "IMPORT_CODE="+filepath.Join(root, "import-code"))
output, err := cmd.CombinedOutput()
if (err == nil) != (fault == "") {
@@ -5938,6 +5980,10 @@ printf '%s\n' "$2" > "$IMPORT_CODE"
if err != nil || !strings.Contains(string(installed), "--only-binary=:all: PyYAML==6.0.3") {
t.Fatalf("wrong prerequisite install: %q, %v", installed, err)
}
+ version, err := os.ReadFile(filepath.Join(root, "version-code"))
+ if err != nil || !strings.Contains(string(version), "assert sys.version_info[:2] == (3, 13)") {
+ t.Fatalf("selected runtime version was not checked: %q, %v", version, err)
+ }
})
}
}