Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Format the workload metadata lifetime repair
pulse-triage[bot]1dec3e1053b3
diff --git a/frontend-modern/src/__tests__/useAppRuntimeState.test.ts b/frontend-modern/src/__tests__/useAppRuntimeState.test.tsindex 6ea891c368..6f1b76cf11 100644--- a/frontend-modern/src/__tests__/useAppRuntimeState.test.ts+++ b/frontend-modern/src/__tests__/useAppRuntimeState.test.ts@@ -801,7 +801,8 @@ describe('useAppRuntimeState', () => {expect(clearAuthMock).not.toHaveBeenCalled();expect(shutdownGlobalWebSocketStoreMock).not.toHaveBeenCalled();expect(localStorage.getItem('auth')).toBe('synthetic-cache');- for (const key of scopedMetadataKeys) expect(localStorage.getItem(key)).toBe('synthetic-scoped-cache');+ for (const key of scopedMetadataKeys)+ expect(localStorage.getItem(key)).toBe('synthetic-scoped-cache');expect(window.location.hash).toBe('');await hookState.handleLogout();expect(apiFetchMock.mock.calls.filter(([url]) => url === '/api/logout')).toHaveLength(1);@@ -964,12 +965,18 @@ describe('useAppRuntimeState', () => {localStorage.setItem('guest_metadata.default', 'synthetic-cache');localStorage.setItem('guest_metadata.other', 'synthetic-cache');const remove = Storage.prototype.removeItem;- const spy = failure === 'scoped-key'- ? vi.spyOn(Storage.prototype, 'removeItem').mockImplementation(function (this: Storage, key: string) {- if (key === 'guest_metadata.default') throw new Error('Synthetic blocked cache');- remove.call(this, key);- })- : vi.spyOn(Storage.prototype, 'key').mockImplementation(() => { throw new Error('Synthetic blocked enumeration'); });+ const spy =+ failure === 'scoped-key'+ ? vi.spyOn(Storage.prototype, 'removeItem').mockImplementation(function (+ this: Storage,+ key: string,+ ) {+ if (key === 'guest_metadata.default') throw new Error('Synthetic blocked cache');+ remove.call(this, key);+ })+ : vi.spyOn(Storage.prototype, 'key').mockImplementation(() => {+ throw new Error('Synthetic blocked enumeration');+ });const fallback = apiFetchMock.getMockImplementation()!;apiFetchMock.mockImplementation((url: string) =>url === '/api/logout' ? new Response('{"success":true}') : fallback(url),@@ -985,7 +992,9 @@ describe('useAppRuntimeState', () => {expect(hookState.needsAuth()).toBe(true);expect(window.location.hash).toBe('');expect(showToastMock).toHaveBeenCalledWith(- 'error', 'Browser cleanup incomplete', expect.stringContaining('could not finish browser cleanup'),+ 'error',+ 'Browser cleanup incomplete',+ expect.stringContaining('could not finish browser cleanup'),);},);diff --git a/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsx b/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsxindex 53fc2033a9..6460082c49 100644--- a/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsx+++ b/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsx@@ -503,7 +503,11 @@ describe('Workloads performance contract', () => {it('cannot carry a disposed platform metadata read into its replacement workload state', async () => {const read = vi.mocked(GuestMetadataAPI.getAllMetadata);let finish!: (metadata: Record<string, GuestMetadata>) => void;- read.mockReturnValueOnce(new Promise((resolve) => { finish = resolve; }));+ read.mockReturnValueOnce(+ new Promise((resolve) => {+ finish = resolve;+ }),+ );const first = renderHook(() => useWorkloadsState({}));first.result.handleCustomUrlUpdate('guest', 'https://confirmed.example');first.cleanup();diff --git a/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.branchcov0722am.test.ts b/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.branchcov0722am.test.tsindex c0ab21db0e..62f977a334 100644--- a/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.branchcov0722am.test.ts+++ b/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.branchcov0722am.test.ts@@ -294,7 +294,9 @@ describe('useWorkloadGuestMetadataState (branch coverage 0722am)', () => {mocks.orgSwitchedHandler.current?.('org-target');expect(result.guestMetadata()).toEqual({});await vi.waitFor(() => {- expect(result.guestMetadata()['guest:target']?.customUrl).toBe('https://authorised.example');+ expect(result.guestMetadata()['guest:target']?.customUrl).toBe(+ 'https://authorised.example',+ );});cleanup();});@@ -321,5 +323,4 @@ describe('useWorkloadGuestMetadataState (branch coverage 0722am)', () => {expect(mocks.unsubscribeOrgSwitched).toHaveBeenCalledTimes(1);});});-});diff --git a/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.lifetime.test.ts b/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.lifetime.test.tsindex e5a9d42d75..38edeef9df 100644--- a/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.lifetime.test.ts+++ b/frontend-modern/src/components/Workloads/__tests__/useWorkloadGuestMetadataState.lifetime.test.ts@@ -16,7 +16,9 @@ type Metadata = Record<string, GuestMetadata>;const record = (url: string): Metadata => ({ guest: { id: 'guest', customUrl: url } });const deferred = () => {let resolve!: (value: Metadata) => void;- const promise = new Promise<Metadata>((finish) => { resolve = finish; });+ const promise = new Promise<Metadata>((finish) => {+ resolve = finish;+ });return { promise, resolve };};@@ -33,12 +35,17 @@ describe('Workloads metadata owner lifetime', () => {});it.each(['resolve', 'deny'])(- 'does not expose a previous credential\'s disk data while the new read will %s',+ "does not expose a previous credential's disk data while the new read will %s",async (result) => {localStorage.setItem('pulseGuestMetadata', JSON.stringify(record('https://legacy.example')));- localStorage.setItem('pulseGuestMetadata.default', JSON.stringify(record('https://private.example')));+ localStorage.setItem(+ 'pulseGuestMetadata.default',+ JSON.stringify(record('https://private.example')),+ );const pending = deferred();- mocks.read.mockImplementation(() => result === 'deny' ? Promise.reject(new Error('Forbidden')) : pending.promise);+ mocks.read.mockImplementation(() =>+ result === 'deny' ? Promise.reject(new Error('Forbidden')) : pending.promise,+ );const { result: state, cleanup } = renderHook(() => useWorkloadGuestMetadataState());expect(state.guestMetadata()).toEqual({});await Promise.resolve();@@ -52,21 +59,24 @@ describe('Workloads metadata owner lifetime', () => {},);- it.each(['idle', 'timeout'])('never queues a %s write that can restore removed metadata', async (scheduler) => {- vi.useFakeTimers();- const idle = vi.fn();- vi.stubGlobal('requestIdleCallback', scheduler === 'idle' ? idle : undefined);- const writes = vi.spyOn(Storage.prototype, 'setItem');- const { result, cleanup } = renderHook(() => useWorkloadGuestMetadataState());- await Promise.resolve();- result.handleCustomUrlUpdate('guest', 'https://confirmed.example');- expect(result.guestMetadata()).toEqual(record('https://confirmed.example'));- cleanup();- vi.runAllTimers();- expect(idle).not.toHaveBeenCalled();- expect(writes).not.toHaveBeenCalled();- expect(localStorage.length).toBe(0);- });+ it.each(['idle', 'timeout'])(+ 'never queues a %s write that can restore removed metadata',+ async (scheduler) => {+ vi.useFakeTimers();+ const idle = vi.fn();+ vi.stubGlobal('requestIdleCallback', scheduler === 'idle' ? idle : undefined);+ const writes = vi.spyOn(Storage.prototype, 'setItem');+ const { result, cleanup } = renderHook(() => useWorkloadGuestMetadataState());+ await Promise.resolve();+ result.handleCustomUrlUpdate('guest', 'https://confirmed.example');+ expect(result.guestMetadata()).toEqual(record('https://confirmed.example'));+ cleanup();+ vi.runAllTimers();+ expect(idle).not.toHaveBeenCalled();+ expect(writes).not.toHaveBeenCalled();+ expect(localStorage.length).toBe(0);+ },+ );it('rejects a disposed read and callback without seeding the next owner in the same org', async () => {const old = deferred();@@ -89,7 +99,8 @@ describe('Workloads metadata owner lifetime', () => {});it('does not reuse even a completed read in a new owner, or disturb an independent owner', async () => {- mocks.read.mockResolvedValueOnce(record('https://first.example'))+ mocks.read+ .mockResolvedValueOnce(record('https://first.example')).mockResolvedValueOnce(record('https://independent.example')).mockReturnValueOnce(new Promise(() => {}));const first = renderHook(() => useWorkloadGuestMetadataState());@@ -107,7 +118,10 @@ describe('Workloads metadata owner lifetime', () => {const oldA = deferred();const b = deferred();const newA = deferred();- mocks.read.mockReturnValueOnce(oldA.promise).mockReturnValueOnce(b.promise).mockReturnValueOnce(newA.promise);+ mocks.read+ .mockReturnValueOnce(oldA.promise)+ .mockReturnValueOnce(b.promise)+ .mockReturnValueOnce(newA.promise);const { result, cleanup } = renderHook(() => useWorkloadGuestMetadataState());result.handleCustomUrlUpdate('guest', 'https://confirmed.example');eventBus.emit('org_switched', 'b');@@ -131,7 +145,11 @@ describe('Workloads metadata owner lifetime', () => {mocks.read.mockClear();setIds(new Set(['moved-guest']));eventBus.emit('org_switched', 'another');- window.dispatchEvent(new CustomEvent(RESOURCE_METADATA_CHANGED_EVENT, { detail: { metadataId: 'guest', customUrl: 'https://late.example' } }));+ window.dispatchEvent(+ new CustomEvent(RESOURCE_METADATA_CHANGED_EVENT, {+ detail: { metadataId: 'guest', customUrl: 'https://late.example' },+ }),+ );expect(mocks.read).not.toHaveBeenCalled();expect(result.guestMetadata()).toEqual({});});diff --git a/frontend-modern/src/components/Workloads/useWorkloadGuestMetadataState.ts b/frontend-modern/src/components/Workloads/useWorkloadGuestMetadataState.tsindex d577759894..6fd63b134e 100644--- a/frontend-modern/src/components/Workloads/useWorkloadGuestMetadataState.ts+++ b/frontend-modern/src/components/Workloads/useWorkloadGuestMetadataState.ts@@ -1,11 +1,4 @@-import {- createEffect,- createSignal,- on,- onCleanup,- onMount,- type Accessor,-} from 'solid-js';+import { createEffect, createSignal, on, onCleanup, onMount, type Accessor } from 'solid-js';import { GuestMetadataAPI } from '@/api/guestMetadata';import type { GuestMetadata } from '@/api/guestMetadata';import { getOrgID } from '@/utils/apiClient';@@ -38,7 +31,9 @@ export function useWorkloadGuestMetadataState(metadataIds?: Accessor<ReadonlySetsetGuestMetadata({});});- const updateGuestMetadataState = (updater: (prev: GuestMetadataRecord) => GuestMetadataRecord) => {+ const updateGuestMetadataState = (+ updater: (prev: GuestMetadataRecord) => GuestMetadataRecord,+ ) => {if (!disposed) setGuestMetadata(updater);};