Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Remove the unreachable Workloads chart visibility toggle (#2734)

rcourtman217ebc3db5b6
diff --cc docs/release-control/v6/internal/subsystems/frontend-primitives.md
index fc70eddf45,3239ebb1c3..7f06ac497f
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@@ -730,14 -730,11 +730,14 @@@ history, and must not discard the save
Platform-owned workload controls extend the shared `WorkloadsFilter` view
options rather than creating page-local toolbar shells. Persistent presentation
choices compose the shared `ViewOptionsDisclosure` instead of occupying the
- primary filter rail: layout, metric style, chart visibility, memory basis, and
- columns remain discoverable behind one `View` trigger. The history range stays
+ primary filter rail: layout, metric style, row hover, memory basis, inventory
+ totals, and columns remain discoverable behind one `View` trigger. The history range stays
inline in both metric modes because bars now expose an intent-driven row
-history lens and Trends keeps the same charts persistent. That inline range
-must carry a visible contextual label.
+history lens and Trends keeps the same charts persistent. In Bars the range
+renders only at desktop widths while Row hover is set to `History`, the mode
+that drives that lens; `Details` hover and the phone (`isMobile`) layout hide
+it. The inline range carries the visible `History` label that
+`WorkloadsFilter` passes to `MetricHistoryRangeSegmentedControl`.
Controls inside the View disclosure must expand in place rather than opening
nested absolute panels that can clip or create competing overlay stacks. The
Proxmox page owns and persists the `Guest` / `Host` memory basis;
@@@ -2652,15 -2635,20 +2652,20 @@@ not a replacement status card, CTA band
drifting off-screen from page-local flex behavior. The shared action rail
must align to the trailing edge at wrapped desktop widths and remain
separate from the filter-control wrap zone instead of waiting for a wide
- breakpoint, so Recovery events, Workloads, Storage, Infrastructure, and
+ breakpoint, so Workloads, Storage, Infrastructure, and
future dense toolbars do not strand Filter/Columns/Reset actions as an
isolated second-row fragment. Shared `FilterToolbarPanel` owns
- default filter-popover geometry, and `FilterToolbar` owns the shared chart
- visibility display action: Workloads, Storage, Infrastructure, and future
- summary-bearing pages must use `ChartVisibilityToggleButton` so the
- affordance exposes one `Show charts` / `Hide charts` pressed-state contract
- instead of rebuilding a one-option segmented control or an in-summary
- collapse chevron page by page. Feature state hooks under
+ default filter-popover geometry. The workload summary chart section that the
+ shared chart show/hide action toggled is deleted and no other page exposes
+ one, so the shared toolbar carries no chart show/hide action: the
+ `ChartVisibilityToggleButton` primitive, its
+ `chart-visibility-toggle-button` rule, and its
+ `chart-visibility-local-toggle-labels` pattern guard are retired, and
+ `SharedPrimitives.guardrails.test.ts` keeps them out. A summary section that
+ returns through a governed product decision must register one shared
+ show/hide primitive with an explicit pressed state rather than a page-local
+ one-option segmented control or in-summary collapse chevron.
+ Feature state hooks under
`frontend-modern/src/features/` own route-backed query state, selected item
state, and data-window selection for their product surfaces; shared
primitives and reusable presentation helpers may own viewport-safe chrome,