Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Ask for the node endpoint before its name

rcourtman29b9ecc9d156
diff --git a/docs/release-control/v6/internal/subsystems/agent-lifecycle.md b/docs/release-control/v6/internal/subsystems/agent-lifecycle.md
index af0c3c5b55..02d1f7610b 100644
--- a/docs/release-control/v6/internal/subsystems/agent-lifecycle.md
+++ b/docs/release-control/v6/internal/subsystems/agent-lifecycle.md
@@ -571,6 +571,17 @@ remain subject to the existing approval guard. Preview generation is local UI
state, not an agent identity, enrollment token or liveness signal.
+### Node setup asks for the endpoint before the name
+
+`NodeModalBasicInfoSection.tsx` puts Endpoint URL first and marks Node Name
+optional, because the name is derived and never a separate gate. Typing an
+endpoint fills an empty or still-derived name from `deriveNameFromHost`; manual
+and password saves fall back to that derivation; assisted setup omits an empty
+name and registration uses the host's reported name; and the server suffixes
+duplicates with the host IP. The help copy therefore says only that an empty
+name is named after the host, and makes no uniqueness demand. This adds no
+agent authority and changes no setup or save payload.
+
### Explicit filesystem selections survive the report boundary
Disk reports carry optional `explicitlyIncluded` evidence when the collector
diff --git a/docs/release-control/v6/internal/subsystems/api-contracts.md b/docs/release-control/v6/internal/subsystems/api-contracts.md
index 95476c02fc..7472788178 100644
--- a/docs/release-control/v6/internal/subsystems/api-contracts.md
+++ b/docs/release-control/v6/internal/subsystems/api-contracts.md
@@ -352,6 +352,16 @@ check accompany desktop/narrow browser interaction proof.
The delivery-log response redacts embedded webhook URLs in errorMessage rather than treating the entire diagnostic as a URL. Non-secret operation and failure context survive alongside notificationId, destinationId, outcome, failureClass and attempts; malformed URL diagnostics fail closed. The HTTP payload proof is TestContract_DeliveryDiagnosticPayload; notification handler tests pin plain, credential-bearing and malformed errors. No response keys or route permissions change.
+### Node form name stays an optional label
+
+The add/edit node form no longer marks `name` required. Every client save
+path already sends a non-empty name (`data.name.trim() ||
+deriveNameFromHost(data.host)`), the setup-command request omits an empty name
+so registration falls back to the reported server name, and
+`disambiguateNodeName` keeps duplicate names distinct, so the node APIs see no
+new empty-name request shape. `NodeCredentialSlot.test.tsx` pins endpoint-first
+order, the optional name and the derivation as the endpoint is typed.
+
### Canonical incident-history query contract
Incident APIs discover canonical-only occurrences and retain exact-start
diff --git a/frontend-modern/browser-verification/22cd3cb68bb17985.json b/frontend-modern/browser-verification/22cd3cb68bb17985.json
new file mode 100644
index 0000000000..583cddb64a
--- /dev/null
+++ b/frontend-modern/browser-verification/22cd3cb68bb17985.json
@@ -0,0 +1,36 @@
+{
+ "version": 1,
+ "base_sha": "159803974f55ac3fe651f07a9d7cfede3d7978e6",
+ "verified_at": "2026-10-15T19:05:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/Settings/NodeModalBasicInfoSection.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/Settings/NodeModalBasicInfoSection.tsx": "b3acd71eb39706382e547be502f0ab1755ad08522d888100bdd5a4c1c8a66924"
+ },
+ "routes": [
+ "/settings/infrastructure?add=pve"
+ ],
+ "viewports": [
+ {
+ "width": 1024,
+ "height": 768
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "Before (main): Add Proxmox VE asked for Node Name first, marked it required with a red asterisk, and its help said Required and must be unique while also offering to auto-fill it if left blank",
+ "After: Endpoint URL is the first field (required); Node Name follows, labelled (Optional), not required, with help saying an empty name is named after the host",
+ "Typing https://pve-lab.local:8006 into Endpoint URL filled Node Name with pve-lab.local; at 1024px the fields sit side by side, endpoint left",
+ "At 375px Endpoint URL stacks above Node Name and the page has no sideways scroll (scrollWidth 375)"
+ ],
+ "interactions": [
+ "Signed in to a private mock stack, opened Add infrastructure, chose Proxmox VE",
+ "Typed an endpoint with real keystrokes and read the filled name, label text and required state from the DOM",
+ "Resized to the mobile preset and checked field order and page width"
+ ]
+}
diff --git a/frontend-modern/src/components/Settings/ConnectionEditor/CredentialSlots/__tests__/NodeCredentialSlot.test.tsx b/frontend-modern/src/components/Settings/ConnectionEditor/CredentialSlots/__tests__/NodeCredentialSlot.test.tsx
index c36fb7276d..b2d18291fb 100644
--- a/frontend-modern/src/components/Settings/ConnectionEditor/CredentialSlots/__tests__/NodeCredentialSlot.test.tsx
+++ b/frontend-modern/src/components/Settings/ConnectionEditor/CredentialSlots/__tests__/NodeCredentialSlot.test.tsx
@@ -201,6 +201,31 @@ describe('NodeCredentialSlot', () => {
});
});
+ it('asks for the endpoint first and names the node from it', () => {
+ render(() => (
+ <NodeCredentialSlot
+ nodeType="pve"
+ settings={createSettings()}
+ onCancel={vi.fn()}
+ onSaved={vi.fn()}
+ />
+ ));
+
+ const endpoint = screen.getByLabelText(/^Endpoint URL/);
+ const name = screen.getByLabelText(/^Node Name/);
+ expect(endpoint.compareDocumentPosition(name) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
+ expect(endpoint).toBeRequired();
+ expect(name).not.toBeRequired();
+ expect(screen.queryByText(/must be unique/)).not.toBeInTheDocument();
+
+ fireEvent.input(endpoint, { target: { value: 'https://pve1.local:8006' } });
+ expect(name).toHaveValue('pve1.local');
+
+ fireEvent.input(name, { target: { value: 'Rack A' } });
+ fireEvent.input(endpoint, { target: { value: 'https://pve2.local:8006' } });
+ expect(name).toHaveValue('Rack A');
+ });
+
it('requires candidate import plan approval before guided setup handoff or manual save', () => {
render(() => (
<NodeCredentialSlot
diff --git a/frontend-modern/src/components/Settings/NodeModalBasicInfoSection.tsx b/frontend-modern/src/components/Settings/NodeModalBasicInfoSection.tsx
index 3818c27427..d5307f60c6 100644
--- a/frontend-modern/src/components/Settings/NodeModalBasicInfoSection.tsx
+++ b/frontend-modern/src/components/Settings/NodeModalBasicInfoSection.tsx
@@ -26,25 +26,6 @@ export const NodeModalBasicInfoSection: Component<NodeModalBasicInfoSectionProps
titleClass="text-base-content"
/>
<div class="grid grid-cols-1 gap-4 md:grid-cols-2">
- <div class={formField}>
- <label for="node-name" class={labelClass('flex items-center gap-2')}>
- Node Name <span class="text-red-500">*</span>
- </label>
- <input
- id="node-name"
- type="text"
- value={state.formData().name}
- onInput={(event) => state.updateField('name', event.currentTarget.value)}
- placeholder="Pulse uses this label across monitoring views"
- required
- class={controlClass()}
- />
- <p class={formHelpText}>
- Required and must be unique. We can auto-fill it from the Endpoint URL if you leave it
- blank.
- </p>
- </div>
-
<div class={formField}>
<label for="node-endpoint-url" class={labelClass('flex items-center gap-1')}>
Endpoint URL <span class="text-red-500">*</span>
@@ -63,6 +44,24 @@ export const NodeModalBasicInfoSection: Component<NodeModalBasicInfoSectionProps
</Show>
</div>
+ <div class={formField}>
+ <label for="node-name" class={labelClass('flex items-center gap-1')}>
+ Node Name <span class="text-slate-500 text-xs font-normal">(Optional)</span>
+ </label>
+ <input
+ id="node-name"
+ type="text"
+ value={state.formData().name}
+ onInput={(event) => state.updateField('name', event.currentTarget.value)}
+ placeholder="Defaults to the host name"
+ class={controlClass()}
+ />
+ <p class={formHelpText}>
+ Pulse shows this name across its monitoring views. If you leave it empty, Pulse names it
+ after the host.
+ </p>
+ </div>
+
<div class={formField}>
<label for="node-guest-url" class={labelClass('flex items-center gap-1')}>
Guest URL <span class="text-slate-500 text-xs font-normal">(Optional)</span>
diff --git a/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts b/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts
index c4caf16e3e..eb50c72394 100644
--- a/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts
+++ b/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts
@@ -1358,6 +1358,9 @@ describe('settings architecture guardrails', () => {
expect(normalize(networkBoundarySettingsSectionSource)).not.toContain('Dashboard URL');
expect(normalize(nodeModalBasicInfoSectionSource)).toContain('monitoring views');
expect(normalize(nodeModalBasicInfoSectionSource)).not.toContain('dashboards');
+ // The server names an unnamed node from its host and disambiguates
+ // duplicates, so the form must not claim either is the user's job.
+ expect(normalize(nodeModalBasicInfoSectionSource)).not.toContain('must be unique');
expect(normalize(nodeModalMonitoringSectionSource)).toContain('trim workload noise');
expect(normalize(nodeModalMonitoringSectionSource)).toContain('Existing monitoring readings');
expect(normalize(nodeModalMonitoringSectionSource)).not.toContain('dashboard readings');