Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep incomplete backup explanations within the observed write evidence

pulse-triage[bot]2c2a19b31f99
diff --git a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
index 845830e101..29124d12d4 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
@@ -117,10 +117,10 @@ const artifactEvidenceLimit = (artifact: RecoverableArtifact): string => {
return "This guest snapshot shares the guest's storage. It is not a separate backup and does not count towards backup protection.";
}
if (artifact.running) {
- return 'This backup is still being written. It is not a completed restore point.';
+ return 'This backup is incomplete and may still be in progress. It is not a completed restore point.';
}
if (artifact.failed) {
- return 'This backup is incomplete after a failed task. It is not a completed restore point.';
+ return 'No current writer is reported for this incomplete backup. It is not a completed restore point.';
}
if (artifact.verified === true) {
return "Verified is the provider's reported backup check, not a tested restore.";
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 5def674bcd..896836b355 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -3133,19 +3133,25 @@ describe('By date recovery evidence limits', () => {
name: 'running PBS snapshot',
pve: emptyPVE.data,
pbs: [identityPBS({ inProgress: true, writeActivityObserved: true, writeActive: true })],
- explanation: /still being written.*not a completed restore point/,
+ explanation: /incomplete and may still be in progress.*not a completed restore point/,
+ },
+ {
+ name: 'incomplete PBS snapshot with unread write activity',
+ pve: emptyPVE.data,
+ pbs: [identityPBS({ inProgress: true })],
+ explanation: /incomplete and may still be in progress.*not a completed restore point/,
},
{
name: 'failed PBS snapshot',
pve: emptyPVE.data,
pbs: [identityPBS({ inProgress: true, writeActivityObserved: true, writeActive: false })],
- explanation: /incomplete after a failed task.*not a completed restore point/,
+ explanation: /No current writer is reported.*not a completed restore point/,
},
{
name: 'running PVE file',
pve: { ...emptyPVE.data, storageBackups: [identityArchive({ inProgress: true })] },
pbs: [],
- explanation: /still being written.*not a completed restore point/,
+ explanation: /incomplete and may still be in progress.*not a completed restore point/,
},
])('explains $name without claiming a tested recovery', async ({ pve, pbs, explanation }) => {
apiFetchMock.mockImplementation((url: string) =>
@@ -3211,11 +3217,11 @@ describe('By date recovery evidence limits', () => {
for (const [next, message] of [
[
identityPBS({ inProgress: true, writeActivityObserved: true, writeActive: true }),
- 'still being written',
+ 'incomplete and may still be in progress',
],
[
identityPBS({ inProgress: true, writeActivityObserved: true, writeActive: false }),
- 'incomplete after a failed task',
+ 'No current writer is reported',
],
[identityPBS({ verified: false }), 'not reported as verified'],
[identityPBS({ verified: true }), "provider's reported backup check"],