Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Align SSO inventory assertions with persistent read feedback

pulse-triage[bot]2dc8d7c3c7a4
diff --git a/frontend-modern/src/components/Settings/__tests__/SSOProviderLifetimes.test.tsx b/frontend-modern/src/components/Settings/__tests__/SSOProviderLifetimes.test.tsx
index 4fda3c2829..e90aeb51dc 100644
--- a/frontend-modern/src/components/Settings/__tests__/SSOProviderLifetimes.test.tsx
+++ b/frontend-modern/src/components/Settings/__tests__/SSOProviderLifetimes.test.tsx
@@ -82,8 +82,9 @@ describe('SSO provider read and editor ownership', () => {
fetchMock.mockResolvedValueOnce(json(body));
render(() => <SSOProvidersPanel />);
expect(await screen.findByRole('alert')).toHaveTextContent(
- 'Configured providers are unknown',
+ 'Unable to load SSO providers. Configured providers are unknown.',
);
+ expect(notices.error).not.toHaveBeenCalled();
expect(screen.queryByText('No SSO providers configured')).toBeNull();
expect(screen.getByRole('button', { name: 'Add OIDC' })).toBeDisabled();
expect(listCalls()).toHaveLength(1);
@@ -92,13 +93,17 @@ describe('SSO provider read and editor ownership', () => {
expect(listCalls()).toHaveLength(2);
expect(writes()).toHaveLength(0);
expect(screen.queryByRole('alert')).toBeNull();
+ expect(notices.error).not.toHaveBeenCalled();
},
);
it('reports refused inventory without private text or a false empty state, including read-only recovery', async () => {
fetchMock.mockResolvedValueOnce(json({ error: 'PRIVATE_SSO_CANARY' }, 403));
render(() => <SSOProvidersPanel canManage={false} />);
- expect(await screen.findByRole('alert')).toHaveTextContent('Configured providers are unknown');
+ expect(await screen.findByRole('alert')).toHaveTextContent(
+ 'Unable to load SSO providers. Configured providers are unknown.',
+ );
+ expect(notices.error).not.toHaveBeenCalled();
expect(document.body).not.toHaveTextContent('PRIVATE_SSO_CANARY');
expect(screen.queryByText('No SSO providers configured')).toBeNull();
fireEvent.click(screen.getByRole('button', { name: 'Retry' }));
@@ -106,6 +111,7 @@ describe('SSO provider read and editor ownership', () => {
expect(screen.getAllByRole('button', { name: 'Edit provider' })[0]).toBeDisabled();
expect(listCalls()).toHaveLength(2);
expect(writes()).toHaveLength(0);
+ expect(notices.error).not.toHaveBeenCalled();
});
it('accepts only the latest requested provider details, even if aborted fetch completes', async () => {
diff --git a/frontend-modern/src/utils/__tests__/frontendResourceTypeBoundaries.test.ts b/frontend-modern/src/utils/__tests__/frontendResourceTypeBoundaries.test.ts
index d0ebb9b779..163e8b67ab 100644
--- a/frontend-modern/src/utils/__tests__/frontendResourceTypeBoundaries.test.ts
+++ b/frontend-modern/src/utils/__tests__/frontendResourceTypeBoundaries.test.ts
@@ -3178,7 +3178,13 @@ describe('frontend resource type boundaries', () => {
);
expect(ssoProvidersStateSource).toContain('@/components/Settings/ssoProvidersModel');
expect(ssoProvidersStateSource).toContain('getSSOTestResultPresentation');
- expect(ssoProvidersStateSource).toContain('getSSOProvidersLoadErrorMessage');
+ // Inventory failure belongs to the panel's persistent unknown state,
+ // not a background toast emitted by the request owner.
+ expect(ssoProvidersPanelSource).toContain('getSSOProvidersLoadErrorMessage()');
+ expect(ssoProvidersStateSource).toContain('setLoadError(true)');
+ expect(ssoProvidersStateSource).not.toContain(
+ 'notificationStore.error(getSSOProvidersLoadErrorMessage()',
+ );
expect(ssoProvidersStateSource).toContain('getSSOProviderDetailsLoadErrorMessage');
expect(ssoProvidersStateSource).toContain('getSSOProviderSaveSuccessMessage');
expect(ssoProvidersStateSource).toContain('getSSOProviderDeleteSuccessMessage');