Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Preserve the staged installer's signed lifecycle handoff

pulse-triage[bot]2fe4eb089e33
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index d9be2d2735..a314713cd1 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -6247,9 +6247,12 @@ successful, nonempty, syntactically valid Bash response before executing any
of it. A failed or truncated transfer, an empty response, or a trailing syntax
error must not execute an otherwise valid prefix. The local installer route,
literal argument forwarding, explicit TLS opt-out and installer exit status
-remain intact; temporary download files are removed on ordinary completion or
-failure. This is transfer/syntax admission, not a replacement for the canonical
-installer's artifact signature checks or proof of installed recovery.
+remain intact. Remote execution keeps the stdin identity so the canonical
+installer still verifies its signed offline-removal copy rather than trusting
+the temporary transport file as a local installer. Temporary download files
+are removed on ordinary completion or failure. This is transfer/syntax
+admission, not a replacement for the canonical installer's artifact signature
+checks or proof of installed recovery.
That same update-runtime boundary now also owns bounded rollback retention and
disk-space fail-closed behavior for self-hosted app updates. `internal/updates/`
must prune stale retained rollback snapshots, clear history references when an
diff --git a/scripts/install-container-agent.sh b/scripts/install-container-agent.sh
index 5edef2d7d5..924838c344 100755
--- a/scripts/install-container-agent.sh
+++ b/scripts/install-container-agent.sh
@@ -143,5 +143,7 @@ if [[ ! -s "$download_file" ]] || ! bash -n -- "$download_file" >/dev/null 2>&1;
exit 1
fi
-# Do not exec: the wrapper still owns cleanup and preserves the installer's exit.
-bash -- "$download_file" "${forward_args[@]}"
+# Keep the stdin identity: the canonical installer must still obtain and verify
+# its signed offline-removal copy, not trust this temporary transport file as a
+# locally supplied installer. Do not exec; the wrapper still owns cleanup.
+bash -s -- "${forward_args[@]}" < "$download_file"
diff --git a/scripts/installtests/install_sh_test.go b/scripts/installtests/install_sh_test.go
index 7c1bb7fe58..e65d7ada42 100644
--- a/scripts/installtests/install_sh_test.go
+++ b/scripts/installtests/install_sh_test.go
@@ -70,7 +70,8 @@ func containerAgentWrapperCommand(t *testing.T, arguments ...string) (*exec.Cmd,
cmd.Env = append(os.Environ(), "TMPDIR="+temporaryDir,
"CURL_HOME="+root, "NO_PROXY=*", "no_proxy=*",
"WRAPPER_MARKER="+filepath.Join(root, "executed"),
- "WRAPPER_ARGS="+filepath.Join(root, "arguments"))
+ "WRAPPER_ARGS="+filepath.Join(root, "arguments"),
+ "WRAPPER_SOURCE="+filepath.Join(root, "source-identity"))
return cmd, root
}
@@ -122,7 +123,7 @@ func TestContainerAgentCompatibilityWrapperRejectsIncompleteDownloadBeforeExecut
}
func TestContainerAgentCompatibilityWrapperPreservesRemoteArgumentsAndExit(t *testing.T) {
- const body = "printf touched > \"$WRAPPER_MARKER\"\nprintf '%s\\0' \"$@\" > \"$WRAPPER_ARGS\"\nexit 37\n"
+ const body = "printf touched > \"$WRAPPER_MARKER\"\nprintf '%s\\0' \"$@\" > \"$WRAPPER_ARGS\"\nprintf '%s' \"$0\" > \"$WRAPPER_SOURCE\"\nexit 37\n"
for _, uninstall := range []bool{false, true} {
t.Run(fmt.Sprintf("uninstall=%t", uninstall), func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
@@ -147,6 +148,13 @@ func TestContainerAgentCompatibilityWrapperPreservesRemoteArgumentsAndExit(t *te
if err != nil || string(actual) != strings.Join(expected, "\x00")+"\x00" {
t.Fatalf("installer arguments changed: %q (%v)", actual, err)
}
+ // save_connection_info in the canonical installer requires a signed
+ // lifecycle download when $0 is bash. A temporary pathname would
+ // instead be trusted and persisted as a local installer source.
+ identity, err := os.ReadFile(filepath.Join(root, "source-identity"))
+ if err != nil || string(identity) != "bash" {
+ t.Fatalf("remote installer lost stdin/signature identity: %q (%v)", identity, err)
+ }
assertContainerWrapperDownloadRemoved(t, root)
})
}