Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Show Backup health as an overview-style table card

rcourtman357ae7a0ed3e
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 217b3cfd89..11d1f192a7 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -9378,13 +9378,17 @@ must not reintroduce a raw border-token class for dataset rows.
### Coverage strip exception groups are filter toggles
-`ProxmoxBackupsCoverageStrip` renders a `BackupVerdict`: one headline with a
-tone dot, then one line per exception group. With `onSelectGroup`, a group
-renders as a button with `aria-pressed`, 28px tall below `sm` and 24px from
-`sm`, whose accessible name is its count and reason ("163 no successful backup");
-the colour dot is decorative and the preview names, shown from `sm`, are
-visual context only. Without `onSelectGroup` a group stays plain text. The
-strip owns no filter state; its caller maps a group key to a filter.
+`ProxmoxBackupsCoverageStrip` renders a `BackupVerdict` as a `TableCard` in
+the platform overview's vocabulary: the `TableCardHeader` strip carries the
+tone dot and "0 / 929 protected" (the headline sentence stays as screen-reader
+text), with the caller's tail muted on the right from `sm`. Each exception
+group is one 32px row of dot, reason, count pill and a `ProgressBar` for its
+share of rated targets, and a green Protected row closes the list. With
+`onSelectGroup`, a group row is a button with `aria-pressed` whose accessible
+name is its count and reason ("163 no successful backup"); workload names are
+a hover title only, because the filtered Coverage table lists them. Without
+`onSelectGroup` a row stays plain. The card owns no filter state; its caller
+maps a group key to a filter.
### The settings nav gates Infrastructure, and the blocked-route fallback is capability-aware
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index ea3c81b0be..85838c232e 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -5014,9 +5014,11 @@ authority. Pinned by `proxmoxBackupRecoveryModel.test.ts` and
### Backup health states a verdict and groups exceptions by reason (1 November 2026)
-The Backups health strip opens with one sentence, "47 of 49 protected" (or
-"All 49 protected"), then one line per cause for everything that is not:
-"No successful backup 2", "Not verified recently 723". The cause is the
+The Backups health card states "47 / 49 protected" in its header strip, then
+one row per cause for everything that is not, each with a count pill and a bar
+for its share of rated targets ("No successful backup 2", "Not verified
+recently 723"), and a Protected row last, matching the platform overview
+tables rather than prose. The cause is the
protection posture's server-owned `reason`, set in `DeriveProtectionPostureAt`
beside the explanation it summarizes, so the page groups workloads without
parsing sentences or re-deriving the posture rules. Each reason belongs to
diff --git a/frontend-modern/browser-verification/53d23669a88ded21.json b/frontend-modern/browser-verification/53d23669a88ded21.json
new file mode 100644
index 0000000000..2737fdbe01
--- /dev/null
+++ b/frontend-modern/browser-verification/53d23669a88ded21.json
@@ -0,0 +1,38 @@
+{
+ "version": 1,
+ "base_sha": "b59e047b126bf323da9ad42769f9de15571bb134",
+ "verified_at": "2026-11-02T00:25:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx": "25a02e7fc735a589edeaeafd787e55de5098c3a90645abecf2be0b0a30e8f6be"
+ },
+ "routes": [
+ "/proxmox/backups/date",
+ "/proxmox/backups/coverage?reason=no-backup"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 1000
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "mock rig with 932 Proxmox backup targets: 0 protected, 3 not evaluated, five posture reasons",
+ "posture reasons added to the rig's /api/recovery/postures responses from each explanation, as the evaluator sets them",
+ "dark theme, desktop and phone layouts"
+ ],
+ "interactions": [
+ "signed in and opened Backups By date at 1440x1000 and 375x812",
+ "read the header strip (0 / 929 protected, 3 not evaluated from sm, restore-point totals on the right from sm) and five reason rows with count pills and share bars",
+ "compared the card against the Proxmox overview nodes table: same header strip, pill and bar primitives",
+ "clicked the No successful backup row: Coverage opened with ?reason=no-backup",
+ "measured reason rows at 32px with none clipped and no horizontal page overflow on either width"
+ ]
+}
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx
index e76015919f..ede482ddbb 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupsCoverageStrip.tsx
@@ -1,22 +1,27 @@
import { For, Show, type Component, type JSX } from 'solid-js';
import ChevronRightIcon from 'lucide-solid/icons/chevron-right';
+import { ProgressBar } from '@/components/shared/ProgressBar';
+import { TableCard } from '@/components/shared/TableCard';
+import { TableCardHeader } from '@/components/shared/TableCardHeader';
import type {
BackupExceptionGroup,
+ BackupExceptionTone,
BackupVerdict,
BackupVerdictTone,
} from './proxmoxBackupVerdict';
-// The Backup health strip answers "is everything backed up?" in one sentence,
-// then names what is not: one line per posture reason with its count, so the
-// answer never depends on counting rows. Each line toggles a Coverage filter
-// to exactly those workloads; the strip owns no filter state itself.
+// The Backup health card answers "is everything backed up?" the way the
+// Proxmox overview tables do: the protected count sits in the header strip,
+// and each posture reason is one single-line row with a count pill and a bar
+// for its share of rated targets. Each reason row toggles a Coverage filter
+// to exactly those workloads; the card owns no filter state itself.
export interface CoverageStripProps {
title: string;
verdict: BackupVerdict;
- // Compact context shown to the right of the title (e.g. "1.2 TB on disk").
+ // Compact context shown on the right of the header strip.
tail?: JSX.Element;
- // The rule behind the verdict. Collapsed by default: the sentence is the
+ // The rule behind the verdict. Collapsed by default: the counts are the
// answer, and each workload's own drawer explains its state.
rule?: JSX.Element;
isGroupPressed?: (key: string) => boolean;
@@ -31,91 +36,165 @@ const TONE_DOT_CLASS: Record<BackupVerdictTone, string> = {
checking: 'bg-blue-400',
};
-const PREVIEW_NAMES = 3;
+type RowTone = BackupExceptionTone | 'protected';
+const PILL_BASE =
+ 'inline-flex min-w-8 justify-center items-center rounded-md px-1.5 py-0.5 text-[11px] font-semibold tabular-nums';
+
+const ROW_TONE: Record<RowTone, { dot: string; pill: string; fill: string }> = {
+ unprotected: {
+ dot: 'bg-red-500',
+ pill: 'bg-red-100 text-red-700 dark:bg-red-900/40 dark:text-red-300',
+ fill: 'bg-red-500/80',
+ },
+ attention: {
+ dot: 'bg-amber-500',
+ pill: 'bg-amber-100 text-amber-800 dark:bg-amber-900/40 dark:text-amber-300',
+ fill: 'bg-amber-500/80',
+ },
+ unknown: {
+ dot: 'bg-slate-400',
+ pill: 'bg-surface-alt text-muted',
+ fill: 'bg-slate-400/80',
+ },
+ protected: {
+ dot: 'bg-emerald-500',
+ pill: 'bg-emerald-100 text-emerald-700 dark:bg-emerald-900/40 dark:text-emerald-300',
+ fill: 'bg-emerald-500/80',
+ },
+};
+
+const ROW_GRID =
+ 'grid w-full min-w-0 grid-cols-[0.5rem_minmax(0,1fr)_auto_5rem] items-center gap-x-3 px-3 text-xs sm:grid-cols-[0.5rem_minmax(0,16rem)_3rem_minmax(0,22rem)] sm:justify-start';
+
+const PREVIEW_NAMES = 5;
+
+// Names stay out of the row: a hover title previews them, and the filtered
+// Coverage table lists them all.
const previewNames = (group: BackupExceptionGroup): string => {
const names = group.rows.slice(0, PREVIEW_NAMES).map((row) => row.workload.label);
const more = group.rows.length - names.length;
return more > 0 ? `${names.join(', ')} and ${more} more` : names.join(', ');
};
-// The preview names are visual context; the button's name is its count and
-// reason ("163 no successful backup"), which stays stable as names change.
const accessibleName = (group: BackupExceptionGroup): string =>
`${group.rows.length} ${group.label.charAt(0).toLowerCase()}${group.label.slice(1)}`;
+const percentOf = (count: number, total: number): number =>
+ total > 0 ? Math.round((count / total) * 100) : 0;
+
+const RowCells: Component<{ tone: RowTone; label: string; count: number; total: number }> = (
+ props,
+) => {
+ const share = () => percentOf(props.count, props.total);
+ return (
+ <>
+ <span class={`h-2 w-2 rounded-full ${ROW_TONE[props.tone].dot}`} aria-hidden="true" />
+ <span class="min-w-0 truncate text-left text-base-content">{props.label}</span>
+ <span class={`${PILL_BASE} ${ROW_TONE[props.tone].pill}`}>{props.count}</span>
+ <ProgressBar
+ value={share()}
+ class="h-4"
+ fillClass={ROW_TONE[props.tone].fill}
+ label={
+ <span class="absolute inset-0 flex items-center justify-center text-[10px] font-semibold leading-none text-base-content">
+ {share()}%
+ </span>
+ }
+ />
+ </>
+ );
+};
+
export const ProxmoxBackupsCoverageStrip: Component<CoverageStripProps> = (props) => {
const asides = () =>
[
props.verdict.checking > 0 ? `${props.verdict.checking} checking` : null,
props.verdict.notEvaluated > 0 ? `${props.verdict.notEvaluated} not evaluated` : null,
].filter(Boolean) as string[];
+ const rated = () => props.verdict.rated;
return (
- <div class="rounded-lg border border-border-subtle px-3 py-2" data-coverage-strip>
- <div class="flex flex-wrap items-baseline gap-x-3 gap-y-1">
- <div class="text-[11px] font-semibold uppercase tracking-[0.18em] text-muted">
- {props.title}
- </div>
- <Show when={props.tail}>
- <div class="w-full text-[11px] text-muted sm:ml-auto sm:w-auto">{props.tail}</div>
- </Show>
- </div>
- <p
- class="mt-1.5 flex flex-wrap items-center gap-x-2 gap-y-0.5"
- data-backup-verdict={props.verdict.tone}
- >
- <span
- class={`h-2 w-2 shrink-0 rounded-full ${TONE_DOT_CLASS[props.verdict.tone]}`}
- aria-hidden="true"
- />
- <span class="text-sm font-medium text-base-content">{props.verdict.headline}</span>
- <Show when={asides().length > 0}>
- <span class="text-[11px] text-muted">{asides().join(' · ')}</span>
- </Show>
- </p>
- <Show when={props.verdict.exceptions.length > 0}>
- <ul class="mt-1 space-y-0.5" aria-label="Backups that are not protected">
+ <TableCard data-coverage-strip>
+ <TableCardHeader
+ title={
+ <span class="inline-flex items-center gap-2 whitespace-nowrap">
+ {props.title}
+ <span
+ class="inline-flex items-center gap-1.5 normal-case tracking-normal"
+ data-backup-verdict={props.verdict.tone}
+ >
+ <span
+ class={`h-2 w-2 shrink-0 rounded-full ${TONE_DOT_CLASS[props.verdict.tone]}`}
+ aria-hidden="true"
+ />
+ <span class="sr-only">{props.verdict.headline}</span>
+ <Show
+ when={rated() > 0}
+ fallback={
+ <span class="font-medium text-base-content" aria-hidden="true">
+ {props.verdict.headline}
+ </span>
+ }
+ >
+ <span aria-hidden="true">
+ <span class="font-semibold tabular-nums text-base-content">
+ {props.verdict.protected} / {rated()}
+ </span>{' '}
+ <span class="font-medium">protected</span>
+ </span>
+ </Show>
+ <Show when={asides().length > 0}>
+ <span class="hidden font-medium text-muted sm:inline">
+ · {asides().join(' · ')}
+ </span>
+ </Show>
+ </span>
+ </span>
+ }
+ actions={
+ <Show when={props.tail}>
+ <span class="hidden text-[10px] font-medium text-muted sm:inline">{props.tail}</span>
+ </Show>
+ }
+ />
+ <Show when={rated() > 0}>
+ <ul class="divide-y divide-border" aria-label="Backups that are not protected">
<For each={props.verdict.exceptions}>
{(group) => {
const pressed = () => props.isGroupPressed?.(group.key) ?? false;
- const content = () => (
- <>
- <span
- class={`h-2 w-2 shrink-0 rounded-xs ${TONE_DOT_CLASS[group.tone]}`}
- aria-hidden="true"
- />
- <span class="min-w-0 truncate text-base-content">{group.label}</span>
- <span class="shrink-0 tabular-nums text-muted">{group.rows.length}</span>
- {/* Names help on a wide screen; a phone keeps the reason and count. */}
- <span class="hidden min-w-0 flex-1 truncate text-muted sm:block">
- {previewNames(group)}
- </span>
- </>
- );
return (
<li class="flex" data-backup-exception={group.key}>
<Show
when={props.onSelectGroup}
fallback={
- <span class="flex min-h-7 w-full min-w-0 items-center gap-2 px-1.5 text-xs sm:min-h-6">
- {content()}
+ <span class={`${ROW_GRID} h-8`}>
+ <RowCells
+ tone={group.tone}
+ label={group.label}
+ count={group.rows.length}
+ total={rated()}
+ />
</span>
}
>
{(onSelect) => (
<button
type="button"
- class={`flex min-h-7 w-full min-w-0 items-center gap-2 rounded-md border px-1.5 text-left text-xs hover:bg-surface-hover focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-blue-500 sm:min-h-6 ${
- pressed()
- ? 'border-blue-400 bg-blue-50 dark:border-blue-500 dark:bg-blue-900/30'
- : 'border-transparent'
+ class={`${ROW_GRID} h-8 hover:bg-surface-hover focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-blue-500 ${
+ pressed() ? 'bg-blue-50 dark:bg-blue-900/30' : ''
}`}
aria-pressed={pressed()}
aria-label={accessibleName(group)}
+ title={previewNames(group)}
onClick={() => onSelect()(group.key)}
>
- {content()}
+ <RowCells
+ tone={group.tone}
+ label={group.label}
+ count={group.rows.length}
+ total={rated()}
+ />
</button>
)}
</Show>
@@ -124,9 +203,22 @@ export const ProxmoxBackupsCoverageStrip: Component<CoverageStripProps> = (props
}}
</For>
</ul>
+ <Show when={props.verdict.protected > 0}>
+ <div class={`${ROW_GRID} h-8 border-t border-border`} data-backup-protected-row>
+ <RowCells
+ tone="protected"
+ label="Protected"
+ count={props.verdict.protected}
+ total={rated()}
+ />
+ </div>
+ </Show>
</Show>
<Show when={props.rule}>
- <details class="group mt-1 text-[11px] text-muted" data-coverage-strip-rule>
+ <details
+ class="group border-t border-border px-3 py-1.5 text-[11px] text-muted"
+ data-coverage-strip-rule
+ >
<summary class="inline-flex cursor-pointer list-none items-center gap-1 rounded-sm hover:text-base-content focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-blue-500 [&::-webkit-details-marker]:hidden">
<ChevronRightIcon
class="h-3 w-3 transition-transform group-open:rotate-90"
@@ -137,8 +229,6 @@ export const ProxmoxBackupsCoverageStrip: Component<CoverageStripProps> = (props
<p class="mt-1 leading-4">{props.rule}</p>
</details>
</Show>
- </div>
+ </TableCard>
);
};
-
-export default ProxmoxBackupsCoverageStrip;
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index e4d2240bc4..5be2529c70 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -609,8 +609,9 @@ describe('ProxmoxBackupsTable', () => {
await screen.findAllByText('pbs-docker');
const healthSummary = screen.getByText(/^\d+ completed restore point/);
- expect(healthSummary.parentElement).toHaveClass('w-full', 'sm:ml-auto', 'sm:w-auto');
- expect(healthSummary.parentElement).not.toHaveClass('ml-auto');
+ // Restore-point totals sit in the header strip from sm up; a phone keeps
+ // the protected count and reason rows.
+ expect(healthSummary.parentElement).toHaveClass('hidden', 'sm:inline');
expect(proxmoxBackupsTableSource).toContain('<PlatformSectionTabs');
expect(proxmoxBackupsTableSource).not.toContain('FilterSegmentedControl');
@@ -778,7 +779,9 @@ describe('ProxmoxBackupsTable', () => {
const exceptions = within(screen.getByRole('list', { name: 'Backups that are not protected' }));
const group = exceptions.getByRole('button', { name: '1 backup source reported a failure' });
expect(group).toHaveTextContent('Backup source reported a failure');
- expect(group).toHaveTextContent('pbs-docker');
+ // Names preview on hover; the filtered Coverage table lists them all.
+ expect(group).toHaveAttribute('title', 'pbs-docker (LXC 112)');
+ expect(group).not.toHaveTextContent('pbs-docker');
// The old posture bar and per-posture counts are gone: the sentence is the answer.
expect(screen.queryByRole('button', { name: '1 attention' })).toBeNull();
});