Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep issuer identity controls separate from success qualification

pulse-triage[bot]39a29ccc55d8
diff --git a/internal/api/contract_test.go b/internal/api/contract_test.go
index af88125c40..a964421d36 100644
--- a/internal/api/contract_test.go
+++ b/internal/api/contract_test.go
@@ -28326,6 +28326,9 @@ func TestContractSSOOIDCIssuerConsumer(t *testing.T) {
t.Fatalf("%s: misleading result: %+v", tt.name, response)
}
if response.Success {
+ if !strings.Contains(response.Message, "Client credentials and sign-in have not been tested.") {
+ t.Fatal("discovery success must not claim tested client credentials or sign-in")
+ }
if response.Details == nil || response.Details.Certificates == nil || response.Details.SupportedScopes == nil {
t.Fatal("successful details must have canonical empty collections")
}
diff --git a/internal/api/sso_oidc_issuer_test.go b/internal/api/sso_oidc_issuer_test.go
index a78e196632..2a04f719d4 100644
--- a/internal/api/sso_oidc_issuer_test.go
+++ b/internal/api/sso_oidc_issuer_test.go
@@ -62,7 +62,6 @@ func TestOIDCConnectionIssuerParity(t *testing.T) {
require.Equal(t, tt.wantError, response.Error)
if tt.wantError == "" {
require.Equal(t, issuer, response.Details.EntityID)
- require.Contains(t, response.Message, "Client credentials and sign-in have not been tested.")
} else {
require.Nil(t, response.Details, "untrusted discovery values must not be presented as validated details")
require.NotContains(t, response.Message, server.URL)