Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Declare the shared reporting telemetry adapter boundary

[email protected]3c6f9846b5c4
diff --git a/docs/release-control/v6/internal/subsystems/api-contracts.md b/docs/release-control/v6/internal/subsystems/api-contracts.md
index d6b68f088c..f137680bcc 100644
--- a/docs/release-control/v6/internal/subsystems/api-contracts.md
+++ b/docs/release-control/v6/internal/subsystems/api-contracts.md
@@ -39,6 +39,10 @@ changes. The activity adapter cannot block a report on tally failure. Scheduler
restart/retry, distinct-period reuse, complete download and mock-suppression proof
lives in `internal/api/reporting_activity_test.go`. Notifications retains SMTP
acceptance authority, and the activity recorder never claims inbox delivery.
+The shared adapter is declared by exact path in the paid-surface allowlist.
+The real boundary regression rejects sibling reporting implementation files and
+private licensing imports added to this observer, preserving the private renderer
+and licensing bridge boundaries.
### Container verification distinguishes transitional health
diff --git a/internal/api/code_standards_test.go b/internal/api/code_standards_test.go
index 0a47272163..f7bc893a8e 100644
--- a/internal/api/code_standards_test.go
+++ b/internal/api/code_standards_test.go
@@ -229,6 +229,9 @@ func TestPaidDomainBoundaryAudit(t *testing.T) {
// Shared tenant/history adapter only. New paid PDF/CSV rendering lives
// in pulse-enterprise behind GenerateBackupHealthReportFunc.
"reporting_backup_health.go": true,
+ // Shared content-free usage observation for manual and scheduled reports.
+ // No renderer, endpoint, entitlement decision or private import.
+ "reporting_activity.go": true,
}
for name := range goFiles {
diff --git a/internal/api/reporting_boundary_test.go b/internal/api/reporting_boundary_test.go
index afd17c5e8a..221958e71c 100644
--- a/internal/api/reporting_boundary_test.go
+++ b/internal/api/reporting_boundary_test.go
@@ -26,6 +26,20 @@ func TestReportingSubjectBoundaryExemptionIsExact(t *testing.T) {
name, file, content, goMarker string
}{
{name: "shared subject pipeline"},
+ {
+ name: "activity observer exemption is exact", file: "reporting_activity_extra.go", content: "package api\n",
+ goMarker: "untracked paid-domain file reporting_activity_extra.go",
+ },
+ {
+ name: "activity observer private import denied", file: "reporting_activity.go",
+ content: "package api\nimport _ \"github.com/rcourtman/pulse-go-rewrite/internal/license\"\n",
+ goMarker: "direct internal/license import",
+ },
+ {
+ name: "activity observer licensing bridge required", file: "reporting_activity.go",
+ content: "package api\nimport _ \"github.com/rcourtman/pulse-go-rewrite/pkg/licensing\"\n",
+ goMarker: "reporting_activity.go",
+ },
{
name: "backup adapter exemption is exact", file: "reporting_backup_health_extra.go", content: "package api\n",
goMarker: "untracked paid-domain file reporting_backup_health_extra.go",
diff --git a/scripts/repo-boundary-paid-surface.allowlist b/scripts/repo-boundary-paid-surface.allowlist
index 7354392ce0..f94b1b1900 100644
--- a/scripts/repo-boundary-paid-surface.allowlist
+++ b/scripts/repo-boundary-paid-surface.allowlist
@@ -5,6 +5,9 @@ internal/api/licensing_bridge.go
internal/api/licensing_handlers.go
internal/api/magic_link.go
internal/api/reporting_runtime_snapshot.go
+# Shared content-free usage observer, with no renderer or entitlement logic.
+# Exact path only. Private imports remain subject to the bridge checks.
+internal/api/reporting_activity.go
# Shared subject enrichment behind the existing reporting admin binder/gates;
# not a new paid endpoint or entitlement implementation. Exact path only.
internal/api/reporting_subject_alerts.go
diff --git a/scripts/repo-boundary-regression.py b/scripts/repo-boundary-regression.py
index f3756f2a92..ddb2731a43 100644
--- a/scripts/repo-boundary-regression.py
+++ b/scripts/repo-boundary-regression.py
@@ -16,6 +16,20 @@ class ReportingSubjectBoundaryTests(unittest.TestCase):
def test_shared_exemption_is_exact_and_preserves_import_boundaries(self):
variants = [
("shared pipeline", None, None, None),
+ (
+ "activity observer exact path", "reporting_activity_extra.go",
+ "package api\n", "new production paid-domain implementation files are not baselined",
+ ),
+ (
+ "activity observer private root import", "reporting_activity.go",
+ 'package api\nimport _ "github.com/rcourtman/pulse-go-rewrite/internal/license"\n',
+ "API root imports of internal/license remain",
+ ),
+ (
+ "activity observer licensing bridge required", "reporting_activity.go",
+ 'package api\nimport _ "github.com/rcourtman/pulse-go-rewrite/pkg/licensing"\n',
+ "API files outside bridge allowlist still import pkg/licensing",
+ ),
(
"backup adapter exact path", "reporting_backup_health_extra.go",
"package api\n", "new production paid-domain implementation files are not baselined",