Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep access warnings until backup enumeration actually recovers

pulse-triage[bot]3d12965167f7
diff --git a/docs/release-control/v6/internal/subsystems/monitoring.md b/docs/release-control/v6/internal/subsystems/monitoring.md
index 779a3a990e..5657928078 100644
--- a/docs/release-control/v6/internal/subsystems/monitoring.md
+++ b/docs/release-control/v6/internal/subsystems/monitoring.md
@@ -26,7 +26,7 @@ provider read starts after expiry. Remaining known local repositories and
unlisted nodes retain their last live rows without renewing durable evidence;
only accepted rows advance. An accepted empty repository can remove its raw
rows, but incomplete instance-wide history cannot reconcile durable absence or
-claim complete protection. PBS attribution without node provenance survives an
+claim complete protection or clear an earlier access warning. PBS attribution without node provenance survives an
unread node until an accepted storage or complete enumeration replaces it.
Explicit request cancellation withdraws the enumeration. Dropping an expired
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 93044ceeae..00bead1567 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -30,7 +30,7 @@ provider read starts after expiry. Remaining known local repositories and
unlisted nodes retain their last live rows without renewing durable evidence;
only accepted rows advance. An accepted empty repository can remove its raw
rows, but incomplete instance-wide history cannot reconcile durable absence or
-claim complete protection. PBS attribution without node provenance survives an
+claim complete protection or clear an earlier access warning. PBS attribution without node provenance survives an
unread node until an accepted storage or complete enumeration replaces it.
Explicit request cancellation withdraws the enumeration. Dropping an expired
diff --git a/internal/monitoring/monitor_backups.go b/internal/monitoring/monitor_backups.go
index b3575600f2..bd82dd4e04 100644
--- a/internal/monitoring/monitor_backups.go
+++ b/internal/monitoring/monitor_backups.go
@@ -768,8 +768,10 @@ func (m *Monitor) pollStorageBackupsWithNodes(ctx context.Context, instanceName
m.checkBackupAlerts(ctx)
- // Clear permission warning if no permission errors occurred this cycle
- if !hadPermissionError {
+ // Only a complete accepted enumeration can clear an earlier access
+ // warning. An unread scope has not demonstrated permission recovery.
+ if !hadPermissionError && protectionObservationErr == nil &&
+ protectionObservation.HistoryCompleteness == recovery.ProtectionHistoryComplete {
m.mu.Lock()
delete(m.backupPermissionWarnings, instanceName)
m.mu.Unlock()
diff --git a/internal/monitoring/pve_storage_budget_test.go b/internal/monitoring/pve_storage_budget_test.go
index 9d2650f918..ccbde88bf7 100644
--- a/internal/monitoring/pve_storage_budget_test.go
+++ b/internal/monitoring/pve_storage_budget_test.go
@@ -139,6 +139,7 @@ func TestPVEStorageBudgetPublishesAcceptedListings(t *testing.T) {
}
c.at = c.at.Add(15 * time.Minute)
c.phase, c.calls = phase, nil
+ f.m.backupPermissionWarnings = map[string]string{"cluster": "previous access warning"}
// The timeout starts only after fixture/storage preparation.
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
@@ -204,6 +205,9 @@ func TestPVEStorageBudgetPublishesAcceptedListings(t *testing.T) {
}
}
f.assertHistory(t, recovery.ProtectionHistoryPartial, operationaltrust.EvidencePermissionsUnknown)
+ if f.m.backupPermissionWarnings["cluster"] != "previous access warning" {
+ t.Error("unread scope cleared its prior access warning")
+ }
frames["partial"] = storageBudgetFrame(t, f)
c.phase, c.calls = "", nil
pollStorageBudget(t, f, c, context.Background())
@@ -213,6 +217,9 @@ func TestPVEStorageBudgetPublishesAcceptedListings(t *testing.T) {
}
}
f.assertHistory(t, recovery.ProtectionHistoryComplete, operationaltrust.EvidencePermissionsSufficient)
+ if f.m.backupPermissionWarnings["cluster"] != "" {
+ t.Error("complete accepted enumeration failed to clear the recovered access warning")
+ }
frames["recovered"] = storageBudgetFrame(t, f)
if os.Getenv("PULSE_STORAGE_BUDGET_FRAMES") == "1" && kind == "qemu" && phase == "content/node-b/local" && !cold {
source, err := os.ReadFile("monitor_backups.go")